algorithm/JavaScript
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/JavaScript.git synced 2025-07-05 16:26:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixing incorrect substring indexes (#431)

Browse Source 
Substring indexes were all off by 1, creating an incorrect output.
Also removed unnecessary `toUpperCase()` calls.
This commit is contained in:
abney317
2020-10-10 12:53:09 -05:00
committed by GitHub
parent 8ffe9cebb9
commit e833b3fd40
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Conversions/HexToRGB.js
View File

@ -1,7 +1,7 @@
function hexStringToRGB (hexString) { function hexStringToRGB (hexString) {
var r = (hexString.substring(1, 3)).toUpperCase() var r = hexString.substring(0, 2)
var g = hexString.substring(3, 5).toUpperCase() var g = hexString.substring(2, 4)
var b = hexString.substring(5, 7).toUpperCase() var b = hexString.substring(4, 6)
r = parseInt(r, 16) r = parseInt(r, 16)
g = parseInt(g, 16) g = parseInt(g, 16)
@ -11,4 +11,4 @@ function hexStringToRGB (hexString) {
return obj return obj
} }
console.log(hexStringToRGB('javascript rock !!')) console.log(hexStringToRGB('ffffff'))