From e833b3fd40f96d888ccc1bd6804e6c3914107ec1 Mon Sep 17 00:00:00 2001 From: abney317 Date: Sat, 10 Oct 2020 12:53:09 -0500 Subject: [PATCH] Fixing incorrect substring indexes (#431) Substring indexes were all off by 1, creating an incorrect output. Also removed unnecessary `toUpperCase()` calls. --- Conversions/HexToRGB.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Conversions/HexToRGB.js b/Conversions/HexToRGB.js index f8f1662f5..5ee820b81 100644 --- a/Conversions/HexToRGB.js +++ b/Conversions/HexToRGB.js @@ -1,7 +1,7 @@ function hexStringToRGB (hexString) { - var r = (hexString.substring(1, 3)).toUpperCase() - var g = hexString.substring(3, 5).toUpperCase() - var b = hexString.substring(5, 7).toUpperCase() + var r = hexString.substring(0, 2) + var g = hexString.substring(2, 4) + var b = hexString.substring(4, 6) r = parseInt(r, 16) g = parseInt(g, 16) @@ -11,4 +11,4 @@ function hexStringToRGB (hexString) { return obj } -console.log(hexStringToRGB('javascript rock !!')) +console.log(hexStringToRGB('ffffff'))