algorithm/Java
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/Java.git synced 2025-07-09 20:20:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed bug with an infinite loop when an array doesn't contain a key

Browse Source 
Fulfilled the code style request
This commit is contained in:
nik
2018-04-19 09:44:48 +03:00
parent c0020903e2
commit 014bfda4f9
1 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
Searches/src/search/IterativeTernarySearch.java
View File

@ -34,19 +34,26 @@ public class IterativeTernarySearch implements SearchAlgorithm {
public <T extends Comparable<T>> int find(T[] array, T key) {
int left = 0;
int right = array.length - 1;
while (true) {
while (right > left) {
int leftCmp = array[left].compareTo(key);
int rightCmp = array[right].compareTo(key);
if (leftCmp == 0) return left;
if (rightCmp == 0) return right;
int leftThird = left + (right - left) / 3;
int rightThird = right - (right - left) /3;
int leftThird = left + (right - left) / 3 + 1;
int rightThird = right - (right - left) / 3 - 1;
if (array[leftThird].compareTo(key) <= 0) left = leftThird;
else right = rightThird;
if (array[leftThird].compareTo(key) <= 0) {
left = leftThird;
} else {
right = rightThird;
}
}
return -1;
}
@ -64,11 +71,12 @@ public class IterativeTernarySearch implements SearchAlgorithm {
IterativeTernarySearch search = new IterativeTernarySearch();
int atIndex = search.find(integers, shouldBeFound);
System.out.println(format("Should be found: %d. Found %d at index %d. An array length %d"
, shouldBeFound, integers[atIndex], atIndex, size));
System.out.println(format("Should be found: %d. Found %d at index %d. An array length %d",
shouldBeFound, integers[atIndex], atIndex, size));
int toCheck = Arrays.binarySearch(integers, shouldBeFound);
System.out.println(format("Found by system method at an index: %d. Is equal: %b", toCheck, toCheck == atIndex));
System.out.println(format("Found by system method at an index: %d. Is equal: %b",
toCheck, toCheck == atIndex));
}