From ec859eabbfb8a511f0fffd30a47a144fb07f2886 Mon Sep 17 00:00:00 2001
From: DEEPANSHU BANSAL <41580413+deepanshu-iiitu@users.noreply.github.com>
Date: Thu, 25 Jan 2024 16:16:03 +0530
Subject: [PATCH] fix(connector): [HELCIM] Handle 4XX Errors (#3458)

---
 crates/router/src/connector/helcim.rs              | 9 ++++++---
 crates/router/src/connector/helcim/transformers.rs | 9 ++++++++-
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/crates/router/src/connector/helcim.rs b/crates/router/src/connector/helcim.rs
index c3a6c5e9f5..0b2cac5d76 100644
--- a/crates/router/src/connector/helcim.rs
+++ b/crates/router/src/connector/helcim.rs
@@ -128,9 +128,12 @@ impl ConnectorCommon for Helcim {
             .response
             .parse_struct("HelcimErrorResponse")
             .change_context(errors::ConnectorError::ResponseDeserializationFailed)?;
-        let error_string = match response.errors {
-            transformers::HelcimErrorTypes::StringType(error) => error,
-            transformers::HelcimErrorTypes::JsonType(error) => error.to_string(),
+        let error_string = match response {
+            transformers::HelcimErrorResponse::Payment(response) => match response.errors {
+                transformers::HelcimErrorTypes::StringType(error) => error,
+                transformers::HelcimErrorTypes::JsonType(error) => error.to_string(),
+            },
+            transformers::HelcimErrorResponse::General(error_string) => error_string,
         };
 
         Ok(ErrorResponse {
diff --git a/crates/router/src/connector/helcim/transformers.rs b/crates/router/src/connector/helcim/transformers.rs
index 599054163c..5e076be651 100644
--- a/crates/router/src/connector/helcim/transformers.rs
+++ b/crates/router/src/connector/helcim/transformers.rs
@@ -756,6 +756,13 @@ pub enum HelcimErrorTypes {
 }
 
 #[derive(Debug, Deserialize)]
-pub struct HelcimErrorResponse {
+pub struct HelcimPaymentsErrorResponse {
     pub errors: HelcimErrorTypes,
 }
+
+#[derive(Debug, Deserialize)]
+#[serde(untagged)]
+pub enum HelcimErrorResponse {
+    Payment(HelcimPaymentsErrorResponse),
+    General(String),
+}