rust/hyperswitch
1
0
Fork 0
mirror of https://github.com/juspay/hyperswitch.git synced 2025-10-31 10:06:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use Debug impl instead of Display impl for logging errors (#5301)

Browse Source
This commit is contained in:
Sanchith Hegde
2024-07-12 13:21:22 +05:30
committed by GitHub
parent d65d7b5cca
commit e835706ad6
27 changed files with 192 additions and 153 deletions
Download Patch File Download Diff File Expand all files Collapse all files

66
crates/scheduler/src/utils.rs
View File

@ -34,7 +34,7 @@ where
let result = update_status_and_append(state, flow, batch).await;
match result {
Ok(_) => (),
Err(error) => logger::error!(error=%error.current_context()),
Err(error) => logger::error!(?error),
}
}
Ok(())
@ -54,23 +54,25 @@ where
.map(|process| process.id.to_owned())
.collect();
match flow {
SchedulerFlow::Producer => {
state
.process_tracker_update_process_status_by_ids(
process_ids,
storage::ProcessTrackerUpdate::StatusUpdate {
status: ProcessTrackerStatus::Processing,
business_status: None,
},
)
.await.map_or_else(|error| {
logger::error!(error=%error.current_context(),"Error while updating process status");
SchedulerFlow::Producer => state
.process_tracker_update_process_status_by_ids(
process_ids,
storage::ProcessTrackerUpdate::StatusUpdate {
status: ProcessTrackerStatus::Processing,
business_status: None,
},
)
.await
.map_or_else(
|error| {
logger::error!(?error, "Error while updating process status");
Err(error.change_context(errors::ProcessTrackerError::ProcessUpdateFailed))
}, |count| {
},
|count| {
logger::debug!("Updated status of {count} processes");
Ok(())
})
}
},
),
SchedulerFlow::Cleaner => {
let res = state
.reinitialize_limbo_processes(process_ids, common_utils::date_time::now())
@ -81,15 +83,15 @@ where
Ok(())
}
Err(error) => {
logger::error!(error=%error.current_context(),"Error while reinitializing processes");
logger::error!(?error, "Error while reinitializing processes");
Err(error.change_context(errors::ProcessTrackerError::ProcessUpdateFailed))
}
}
}
_ => {
let error_msg = format!("Unexpected scheduler flow {flow:?}");
logger::error!(error = %error_msg);
Err(report!(errors::ProcessTrackerError::UnexpectedFlow).attach_printable(error_msg))
let error = format!("Unexpected scheduler flow {flow:?}");
logger::error!(%error);
Err(report!(errors::ProcessTrackerError::UnexpectedFlow).attach_printable(error))
}
}?;
@ -108,19 +110,27 @@ where
Err(mut err) => {
let update_res = state
.process_tracker_update_process_status_by_ids(
pt_batch.trackers.iter().map(|process| process.id.clone()).collect(),
pt_batch
.trackers
.iter()
.map(|process| process.id.clone())
.collect(),
storage::ProcessTrackerUpdate::StatusUpdate {
status: ProcessTrackerStatus::Processing,
business_status: None,
},
)
.await.map_or_else(|error| {
logger::error!(error=%error.current_context(),"Error while updating process status");
Err(error.change_context(errors::ProcessTrackerError::ProcessUpdateFailed))
}, |count| {
logger::debug!("Updated status of {count} processes");
Ok(())
});
.await
.map_or_else(
|error| {
logger::error!(?error, "Error while updating process status");
Err(error.change_context(errors::ProcessTrackerError::ProcessUpdateFailed))
},
|count| {
logger::debug!("Updated status of {count} processes");
Ok(())
},
);
match update_res {
Ok(_) => (),
@ -275,7 +285,7 @@ pub fn add_histogram_metrics(
#[warn(clippy::option_map_unit_fn)]
if let Some((schedule_time, runner)) = task.schedule_time.as_ref().zip(task.runner.as_ref()) {
let pickup_schedule_delta = (*pickup_time - *schedule_time).as_seconds_f64();
logger::error!(%pickup_schedule_delta, "<- Time delta for scheduled tasks");
logger::error!("Time delta for scheduled tasks: {pickup_schedule_delta} seconds");
let runner_name = runner.clone();
metrics::CONSUMER_STATS.record(
&metrics::CONTEXT,