chore: address some clippy lints arising from v2 code (#6015)

This commit is contained in:
Sanchith Hegde
2024-09-25 16:21:27 +05:30
committed by GitHub
parent 4dac86cebf
commit dec0a57f76
16 changed files with 115 additions and 112 deletions

View File

@ -109,8 +109,8 @@ pub enum SurchargeCalculationOverride {
impl From<Option<bool>> for TaxCalculationOverride {
fn from(value: Option<bool>) -> Self {
match value {
Some(true) => TaxCalculationOverride::Calculate,
_ => TaxCalculationOverride::Skip,
Some(true) => Self::Calculate,
_ => Self::Skip,
}
}
}
@ -119,8 +119,8 @@ impl From<Option<bool>> for TaxCalculationOverride {
impl From<Option<bool>> for SurchargeCalculationOverride {
fn from(value: Option<bool>) -> Self {
match value {
Some(true) => SurchargeCalculationOverride::Calculate,
_ => SurchargeCalculationOverride::Skip,
Some(true) => Self::Calculate,
_ => Self::Skip,
}
}
}
@ -235,7 +235,7 @@ pub struct PaymentIntent {
/// The details of the customer in a denormalized form. Only a subset of fields are stored.
pub customer_details: Option<Encryptable<Secret<serde_json::Value>>>,
/// The reference id for the order in the merchant's system. This value can be passed by the merchant.
pub merchant_reference_id: Option<common_utils::id_type::PaymentId>,
pub merchant_reference_id: Option<id_type::PaymentId>,
/// The billing address for the order in a denormalized form.
pub billing_address: Option<Encryptable<Secret<serde_json::Value>>>,
/// The shipping address for the order in a denormalized form.

View File

@ -1481,7 +1481,7 @@ impl behaviour::Conversion for PaymentIntent {
type NewDstType = DieselPaymentIntentNew;
async fn convert(self) -> CustomResult<Self::DstType, ValidationError> {
let PaymentIntent {
let Self {
merchant_id,
amount_details,
status,
@ -1585,7 +1585,7 @@ impl behaviour::Conversion for PaymentIntent {
async fn convert_back(
state: &KeyManagerState,
storage_model: Self::DstType,
key: &masking::Secret<Vec<u8>>,
key: &Secret<Vec<u8>>,
key_manager_identifier: keymanager::Identifier,
) -> CustomResult<Self, ValidationError>
where