chore: enable clippy::trivially_copy_pass_by_ref lint and address it (#6724)

This commit is contained in:
Sanchith Hegde
2024-12-05 20:11:40 +05:30
committed by GitHub
parent e5dde6acc0
commit d17d2fe075
154 changed files with 423 additions and 429 deletions

View File

@ -280,7 +280,7 @@ pub trait DataModelExt {
}
pub(crate) fn diesel_error_to_data_error(
diesel_error: &diesel_models::errors::DatabaseError,
diesel_error: diesel_models::errors::DatabaseError,
) -> StorageError {
match diesel_error {
diesel_models::errors::DatabaseError::DatabaseConnectionError => {
@ -293,7 +293,7 @@ pub(crate) fn diesel_error_to_data_error(
entity: "entity ",
key: None,
},
_ => StorageError::DatabaseError(error_stack::report!(*diesel_error)),
_ => StorageError::DatabaseError(error_stack::report!(diesel_error)),
}
}

View File

@ -44,7 +44,7 @@ impl<T: DatabaseStore> ReverseLookupInterface for RouterStore<T> {
.await
.change_context(errors::StorageError::DatabaseConnectionError)?;
new.insert(&conn).await.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
}
@ -58,7 +58,7 @@ impl<T: DatabaseStore> ReverseLookupInterface for RouterStore<T> {
DieselReverseLookup::find_by_lookup_id(id, &conn)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
}

View File

@ -60,7 +60,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
.insert(&conn)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(PaymentAttempt::from_storage_model)
@ -83,7 +83,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
.insert(&conn)
.await
.map_err(|error| {
let new_error = diesel_error_to_data_error(error.current_context());
let new_error = diesel_error_to_data_error(*error.current_context());
error.change_context(new_error)
})?
.convert(
@ -108,7 +108,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
.update_with_attempt_id(&conn, payment_attempt.to_storage_model())
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(PaymentAttempt::from_storage_model)
@ -135,7 +135,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
)
.await
.map_err(|error| {
let new_error = diesel_error_to_data_error(error.current_context());
let new_error = diesel_error_to_data_error(*error.current_context());
error.change_context(new_error)
})?
.convert(
@ -165,7 +165,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(PaymentAttempt::from_storage_model)
@ -187,7 +187,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(PaymentAttempt::from_storage_model)
@ -209,7 +209,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(PaymentAttempt::from_storage_model)
@ -231,7 +231,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(PaymentAttempt::from_storage_model)
@ -255,7 +255,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})?
.convert(
@ -286,7 +286,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(PaymentAttempt::from_storage_model)
@ -313,7 +313,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
DieselPaymentAttempt::get_filters_for_payments(&conn, intents.as_slice(), merchant_id)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(
@ -352,7 +352,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(PaymentAttempt::from_storage_model)
@ -370,7 +370,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
DieselPaymentAttempt::find_by_merchant_id_payment_id(&conn, merchant_id, payment_id)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(|a| {
@ -393,7 +393,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
DieselPaymentAttempt::find_by_merchant_id_attempt_id(&conn, merchant_id, attempt_id)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(PaymentAttempt::from_storage_model)
@ -413,7 +413,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
DieselPaymentAttempt::find_by_id(&conn, attempt_id)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})?
.convert(
@ -464,7 +464,7 @@ impl<T: DatabaseStore> PaymentAttemptInterface for RouterStore<T> {
)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
}

View File

@ -297,7 +297,7 @@ impl<T: DatabaseStore> PaymentIntentInterface for KVRouterStore<T> {
DieselPaymentIntent::find_by_payment_id_merchant_id(&conn, payment_id, merchant_id)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
};
@ -358,7 +358,7 @@ impl<T: DatabaseStore> PaymentIntentInterface for KVRouterStore<T> {
let diesel_payment_intent = DieselPaymentIntent::find_by_global_id(&conn, id)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})?;
@ -481,7 +481,7 @@ impl<T: DatabaseStore> PaymentIntentInterface for crate::RouterStore<T> {
.insert(&conn)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})?;
@ -515,7 +515,7 @@ impl<T: DatabaseStore> PaymentIntentInterface for crate::RouterStore<T> {
.update(&conn, diesel_payment_intent_update)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})?;
@ -550,7 +550,7 @@ impl<T: DatabaseStore> PaymentIntentInterface for crate::RouterStore<T> {
.update(&conn, diesel_payment_intent_update)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})?;
@ -579,7 +579,7 @@ impl<T: DatabaseStore> PaymentIntentInterface for crate::RouterStore<T> {
DieselPaymentIntent::find_by_payment_id_merchant_id(&conn, payment_id, merchant_id)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.async_and_then(|diesel_payment_intent| async {
@ -608,7 +608,7 @@ impl<T: DatabaseStore> PaymentIntentInterface for crate::RouterStore<T> {
let diesel_payment_intent = DieselPaymentIntent::find_by_global_id(&conn, id)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})?;

View File

@ -395,7 +395,7 @@ impl<T: DatabaseStore> PayoutAttemptInterface for crate::RouterStore<T> {
.insert(&conn)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(PayoutAttempt::from_storage_model)
@ -415,7 +415,7 @@ impl<T: DatabaseStore> PayoutAttemptInterface for crate::RouterStore<T> {
.update_with_attempt_id(&conn, payout.to_storage_model())
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(PayoutAttempt::from_storage_model)
@ -437,7 +437,7 @@ impl<T: DatabaseStore> PayoutAttemptInterface for crate::RouterStore<T> {
.await
.map(PayoutAttempt::from_storage_model)
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
}
@ -458,7 +458,7 @@ impl<T: DatabaseStore> PayoutAttemptInterface for crate::RouterStore<T> {
.await
.map(PayoutAttempt::from_storage_model)
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
}
@ -479,7 +479,7 @@ impl<T: DatabaseStore> PayoutAttemptInterface for crate::RouterStore<T> {
DieselPayoutAttempt::get_filters_for_payouts(&conn, payouts.as_slice(), merchant_id)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(

View File

@ -235,7 +235,7 @@ impl<T: DatabaseStore> PayoutsInterface for KVRouterStore<T> {
DieselPayouts::find_by_merchant_id_payout_id(&conn, merchant_id, payout_id)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
};
@ -283,7 +283,7 @@ impl<T: DatabaseStore> PayoutsInterface for KVRouterStore<T> {
DieselPayouts::find_optional_by_merchant_id_payout_id(&conn, merchant_id, payout_id)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
};
@ -423,7 +423,7 @@ impl<T: DatabaseStore> PayoutsInterface for crate::RouterStore<T> {
.insert(&conn)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(Payouts::from_storage_model)
@ -443,7 +443,7 @@ impl<T: DatabaseStore> PayoutsInterface for crate::RouterStore<T> {
.update(&conn, payout.to_storage_model())
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
.map(Payouts::from_storage_model)
@ -461,7 +461,7 @@ impl<T: DatabaseStore> PayoutsInterface for crate::RouterStore<T> {
.await
.map(Payouts::from_storage_model)
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
}
@ -478,7 +478,7 @@ impl<T: DatabaseStore> PayoutsInterface for crate::RouterStore<T> {
.await
.map(|x| x.map(Payouts::from_storage_model))
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
}
@ -814,7 +814,7 @@ impl<T: DatabaseStore> PayoutsInterface for crate::RouterStore<T> {
)
.await
.map_err(|er| {
let new_err = diesel_error_to_data_error(er.current_context());
let new_err = diesel_error_to_data_error(*er.current_context());
er.change_context(new_err)
})
}