rust/hyperswitch
1
0
Fork 0
mirror of https://github.com/juspay/hyperswitch.git synced 2025-11-04 05:59:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(connector): [Shift4] change error message from NotSupported to NotImplemented (#2880)

Browse Source
This commit is contained in:
Brian Silah
2023-11-30 21:53:37 +03:00
committed by GitHub
parent 668b943403
commit bc79d522c3
1 changed files with 31 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

89
crates/router/src/connector/shift4/transformers.rs
View File

@ -168,10 +168,9 @@ impl<T> TryFrom<&types::RouterData<T, types::PaymentsAuthorizeData, types::Payme
| payments::PaymentMethodData::Reward | payments::PaymentMethodData::Reward
| payments::PaymentMethodData::Upi(_) | payments::PaymentMethodData::Upi(_)
| payments::PaymentMethodData::CardToken(_) => { | payments::PaymentMethodData::CardToken(_) => {
Err(errors::ConnectorError::NotSupported { Err(errors::ConnectorError::NotImplemented(
message: utils::SELECTED_PAYMENT_METHOD.to_string(), utils::get_unimplemented_payment_method_error_message("Shift4"),
connector: "Shift4", )
}
.into()) .into())
} }
} }
@ -184,13 +183,8 @@ impl TryFrom<&api_models::payments::WalletData> for Shift4PaymentMethod {
match wallet_data { match wallet_data {
payments::WalletData::AliPayRedirect(_) payments::WalletData::AliPayRedirect(_)
| payments::WalletData::ApplePay(_) | payments::WalletData::ApplePay(_)
| payments::WalletData::WeChatPayRedirect(_) => { | payments::WalletData::WeChatPayRedirect(_)
Err(errors::ConnectorError::NotImplemented( | payments::WalletData::AliPayQr(_)
utils::get_unimplemented_payment_method_error_message("Shift4"),
)
.into())
}
payments::WalletData::AliPayQr(_)
| payments::WalletData::AliPayHkRedirect(_) | payments::WalletData::AliPayHkRedirect(_)
| payments::WalletData::MomoRedirect(_) | payments::WalletData::MomoRedirect(_)
| payments::WalletData::KakaoPayRedirect(_) | payments::WalletData::KakaoPayRedirect(_)
@ -212,10 +206,9 @@ impl TryFrom<&api_models::payments::WalletData> for Shift4PaymentMethod {
| payments::WalletData::TouchNGoRedirect(_) | payments::WalletData::TouchNGoRedirect(_)
| payments::WalletData::WeChatPayQr(_) | payments::WalletData::WeChatPayQr(_)
| payments::WalletData::CashappQr(_) | payments::WalletData::CashappQr(_)
| payments::WalletData::SwishQr(_) => Err(errors::ConnectorError::NotSupported { | payments::WalletData::SwishQr(_) => Err(errors::ConnectorError::NotImplemented(
message: utils::SELECTED_PAYMENT_METHOD.to_string(), utils::get_unimplemented_payment_method_error_message("Shift4"),
connector: "Shift4", )
}
.into()), .into()),
} }
} }
@ -227,13 +220,8 @@ impl TryFrom<&api_models::payments::BankTransferData> for Shift4PaymentMethod {
bank_transfer_data: &api_models::payments::BankTransferData, bank_transfer_data: &api_models::payments::BankTransferData,
) -> Result<Self, Self::Error> { ) -> Result<Self, Self::Error> {
match bank_transfer_data { match bank_transfer_data {
payments::BankTransferData::MultibancoBankTransfer { .. } => { payments::BankTransferData::MultibancoBankTransfer { .. }
Err(errors::ConnectorError::NotImplemented( | payments::BankTransferData::AchBankTransfer { .. }
utils::get_unimplemented_payment_method_error_message("Shift4"),
)
.into())
}
payments::BankTransferData::AchBankTransfer { .. }
| payments::BankTransferData::SepaBankTransfer { .. } | payments::BankTransferData::SepaBankTransfer { .. }
| payments::BankTransferData::BacsBankTransfer { .. } | payments::BankTransferData::BacsBankTransfer { .. }
| payments::BankTransferData::PermataBankTransfer { .. } | payments::BankTransferData::PermataBankTransfer { .. }
@ -244,10 +232,9 @@ impl TryFrom<&api_models::payments::BankTransferData> for Shift4PaymentMethod {
| payments::BankTransferData::DanamonVaBankTransfer { .. } | payments::BankTransferData::DanamonVaBankTransfer { .. }
| payments::BankTransferData::MandiriVaBankTransfer { .. } | payments::BankTransferData::MandiriVaBankTransfer { .. }
| payments::BankTransferData::Pix {} | payments::BankTransferData::Pix {}
| payments::BankTransferData::Pse {} => Err(errors::ConnectorError::NotSupported { | payments::BankTransferData::Pse {} => Err(errors::ConnectorError::NotImplemented(
message: utils::SELECTED_PAYMENT_METHOD.to_string(), utils::get_unimplemented_payment_method_error_message("Shift4"),
connector: "Shift4", )
}
.into()), .into()),
} }
} }
@ -257,11 +244,8 @@ impl TryFrom<&api_models::payments::VoucherData> for Shift4PaymentMethod {
type Error = Error; type Error = Error;
fn try_from(voucher_data: &api_models::payments::VoucherData) -> Result<Self, Self::Error> { fn try_from(voucher_data: &api_models::payments::VoucherData) -> Result<Self, Self::Error> {
match voucher_data { match voucher_data {
payments::VoucherData::Boleto(_) => Err(errors::ConnectorError::NotImplemented( payments::VoucherData::Boleto(_)
utils::get_unimplemented_payment_method_error_message("Shift4"), | payments::VoucherData::Efecty
)
.into()),
payments::VoucherData::Efecty
| payments::VoucherData::PagoEfectivo | payments::VoucherData::PagoEfectivo
| payments::VoucherData::RedCompra | payments::VoucherData::RedCompra
| payments::VoucherData::RedPagos | payments::VoucherData::RedPagos
@ -273,10 +257,9 @@ impl TryFrom<&api_models::payments::VoucherData> for Shift4PaymentMethod {
| payments::VoucherData::MiniStop(_) | payments::VoucherData::MiniStop(_)
| payments::VoucherData::FamilyMart(_) | payments::VoucherData::FamilyMart(_)
| payments::VoucherData::Seicomart(_) | payments::VoucherData::Seicomart(_)
| payments::VoucherData::PayEasy(_) => Err(errors::ConnectorError::NotSupported { | payments::VoucherData::PayEasy(_) => Err(errors::ConnectorError::NotImplemented(
message: utils::SELECTED_PAYMENT_METHOD.to_string(), utils::get_unimplemented_payment_method_error_message("Shift4"),
connector: "Shift4", )
}
.into()), .into()),
} }
} }
@ -286,15 +269,12 @@ impl TryFrom<&api_models::payments::GiftCardData> for Shift4PaymentMethod {
type Error = Error; type Error = Error;
fn try_from(gift_card_data: &api_models::payments::GiftCardData) -> Result<Self, Self::Error> { fn try_from(gift_card_data: &api_models::payments::GiftCardData) -> Result<Self, Self::Error> {
match gift_card_data { match gift_card_data {
payments::GiftCardData::Givex(_) => Err(errors::ConnectorError::NotSupported { payments::GiftCardData::Givex(_) | payments::GiftCardData::PaySafeCard {} => {
message: utils::SELECTED_PAYMENT_METHOD.to_string(), Err(errors::ConnectorError::NotImplemented(
connector: "Shift4", utils::get_unimplemented_payment_method_error_message("Shift4"),
)
.into())
} }
.into()),
payments::GiftCardData::PaySafeCard {} => Err(errors::ConnectorError::NotImplemented(
utils::get_unimplemented_payment_method_error_message("Shift4"),
)
.into()),
} }
} }
} }
@ -401,10 +381,9 @@ impl<T> TryFrom<&types::RouterData<T, types::CompleteAuthorizeData, types::Payme
| Some(payments::PaymentMethodData::Reward) | Some(payments::PaymentMethodData::Reward)
| Some(payments::PaymentMethodData::Upi(_)) | Some(payments::PaymentMethodData::Upi(_))
| Some(api::PaymentMethodData::CardToken(_)) | Some(api::PaymentMethodData::CardToken(_))
| None => Err(errors::ConnectorError::NotSupported { | None => Err(errors::ConnectorError::NotImplemented(
message: "Flow".to_string(), utils::get_unimplemented_payment_method_error_message("Shift4"),
connector: "Shift4", )
}
.into()), .into()),
} }
} }
@ -421,13 +400,8 @@ impl TryFrom<&payments::BankRedirectData> for PaymentMethodType {
payments::BankRedirectData::BancontactCard { .. } payments::BankRedirectData::BancontactCard { .. }
| payments::BankRedirectData::Blik { .. } | payments::BankRedirectData::Blik { .. }
| payments::BankRedirectData::Trustly { .. } | payments::BankRedirectData::Trustly { .. }
| payments::BankRedirectData::Przelewy24 { .. } => { | payments::BankRedirectData::Przelewy24 { .. }
Err(errors::ConnectorError::NotImplemented( | payments::BankRedirectData::Bizum {}
utils::get_unimplemented_payment_method_error_message("Shift4"),
)
.into())
}
payments::BankRedirectData::Bizum {}
| payments::BankRedirectData::Interac { .. } | payments::BankRedirectData::Interac { .. }
| payments::BankRedirectData::OnlineBankingCzechRepublic { .. } | payments::BankRedirectData::OnlineBankingCzechRepublic { .. }
| payments::BankRedirectData::OnlineBankingFinland { .. } | payments::BankRedirectData::OnlineBankingFinland { .. }
@ -436,10 +410,9 @@ impl TryFrom<&payments::BankRedirectData> for PaymentMethodType {
| payments::BankRedirectData::OpenBankingUk { .. } | payments::BankRedirectData::OpenBankingUk { .. }
| payments::BankRedirectData::OnlineBankingFpx { .. } | payments::BankRedirectData::OnlineBankingFpx { .. }
| payments::BankRedirectData::OnlineBankingThailand { .. } => { | payments::BankRedirectData::OnlineBankingThailand { .. } => {
Err(errors::ConnectorError::NotSupported { Err(errors::ConnectorError::NotImplemented(
message: utils::SELECTED_PAYMENT_METHOD.to_string(), utils::get_unimplemented_payment_method_error_message("Shift4"),
connector: "Shift4", )
}
.into()) .into())
} }
} }