rust/hyperswitch
1
0
Fork 0
mirror of https://github.com/juspay/hyperswitch.git synced 2025-10-28 04:04:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(connector): [Adyen] refactor adyen payment method not implemented errors (#1950)

Browse Source
This commit is contained in:
Swangi Kumari
2023-09-08 19:27:48 +05:30
committed by GitHub
parent fea075e32e
commit 955534e953
3 changed files with 75 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

96
crates/router/src/connector/adyen/transformers.rs
View File

@ -1340,10 +1340,15 @@ impl<'a> TryFrom<&types::PaymentsAuthorizeRouterData> for AdyenPaymentRequest<'a
api_models::payments::PaymentMethodData::GiftCard(ref gift_card_data) => { api_models::payments::PaymentMethodData::GiftCard(ref gift_card_data) => {
AdyenPaymentRequest::try_from((item, gift_card_data.as_ref())) AdyenPaymentRequest::try_from((item, gift_card_data.as_ref()))
} }
_ => Err(errors::ConnectorError::NotSupported { payments::PaymentMethodData::Crypto(_)
message: format!("{:?}", item.request.payment_method_type), | payments::PaymentMethodData::MandatePayment
connector: "Adyen", | payments::PaymentMethodData::Reward
})?, | payments::PaymentMethodData::Upi(_) => {
Err(errors::ConnectorError::NotSupported {
message: utils::SELECTED_PAYMENT_METHOD.to_string(),
connector: "Adyen",
})?
}
}, },
} }
} }
@ -1365,10 +1370,12 @@ impl<'a> TryFrom<&types::PaymentsBalanceRouterData> for AdyenBalanceRequest<'a>
balance_pm, balance_pm,
))) )))
} }
_ => Err(errors::ConnectorError::FlowNotSupported { payments::GiftCardData::PaySafeCard {} => {
flow: "Balance".to_string(), Err(errors::ConnectorError::FlowNotSupported {
connector: "adyen".to_string(), flow: "Balance".to_string(),
}), connector: "adyen".to_string(),
})
}
} }
} }
_ => Err(errors::ConnectorError::FlowNotSupported { _ => Err(errors::ConnectorError::FlowNotSupported {
@ -1631,7 +1638,13 @@ impl<'a> TryFrom<&api_models::payments::BankDebitData> for AdyenPaymentMethod<'a
)?, )?,
}, },
))), ))),
_ => Err(errors::ConnectorError::NotImplemented("Payment method".to_string()).into()), payments::BankDebitData::BecsBankDebit { .. } => {
Err(errors::ConnectorError::NotSupported {
message: utils::SELECTED_PAYMENT_METHOD.to_string(),
connector: "Adyen",
}
.into())
}
} }
} }
} }
@ -1677,9 +1690,10 @@ impl<'a> TryFrom<&api_models::payments::VoucherData> for AdyenPaymentMethod<'a>
payments::VoucherData::Efecty payments::VoucherData::Efecty
| payments::VoucherData::PagoEfectivo | payments::VoucherData::PagoEfectivo
| payments::VoucherData::RedCompra | payments::VoucherData::RedCompra
| payments::VoucherData::RedPagos => Err(errors::ConnectorError::NotImplemented( | payments::VoucherData::RedPagos => Err(errors::ConnectorError::NotSupported {
"this payment method".to_string(), message: utils::SELECTED_PAYMENT_METHOD.to_string(),
) connector: "Adyen",
}
.into()), .into()),
} }
} }
@ -1754,7 +1768,7 @@ impl TryFrom<&storage_enums::PaymentMethodType> for PaymentType {
| storage_enums::PaymentMethodType::Walley => Ok(Self::Scheme), | storage_enums::PaymentMethodType::Walley => Ok(Self::Scheme),
storage_enums::PaymentMethodType::Paypal => Ok(Self::Paypal), storage_enums::PaymentMethodType::Paypal => Ok(Self::Paypal),
_ => Err(errors::ConnectorError::NotImplemented( _ => Err(errors::ConnectorError::NotImplemented(
"Payment Method Type".to_string(), utils::get_unimplemented_payment_method_error_message("Adyen"),
))?, ))?,
} }
} }
@ -1856,7 +1870,18 @@ impl<'a> TryFrom<&api::WalletData> for AdyenPaymentMethod<'a> {
api_models::payments::WalletData::VippsRedirect { .. } => Ok(AdyenPaymentMethod::Vipps), api_models::payments::WalletData::VippsRedirect { .. } => Ok(AdyenPaymentMethod::Vipps),
api_models::payments::WalletData::DanaRedirect { .. } => Ok(AdyenPaymentMethod::Dana), api_models::payments::WalletData::DanaRedirect { .. } => Ok(AdyenPaymentMethod::Dana),
api_models::payments::WalletData::SwishQr(_) => Ok(AdyenPaymentMethod::Swish), api_models::payments::WalletData::SwishQr(_) => Ok(AdyenPaymentMethod::Swish),
_ => Err(errors::ConnectorError::NotImplemented("Payment method".to_string()).into()), payments::WalletData::AliPayQr(_)
| payments::WalletData::ApplePayRedirect(_)
| payments::WalletData::ApplePayThirdPartySdk(_)
| payments::WalletData::GooglePayRedirect(_)
| payments::WalletData::GooglePayThirdPartySdk(_)
| payments::WalletData::PaypalSdk(_)
| payments::WalletData::WeChatPayQr(_)
| payments::WalletData::CashappQr(_) => Err(errors::ConnectorError::NotSupported {
message: utils::SELECTED_PAYMENT_METHOD.to_string(),
connector: "Adyen",
}
.into()),
} }
} }
} }
@ -1912,7 +1937,11 @@ impl<'a> TryFrom<(&api::PayLaterData, Option<api_enums::CountryAlpha2>)>
api_models::payments::PayLaterData::AtomeRedirect { .. } => { api_models::payments::PayLaterData::AtomeRedirect { .. } => {
Ok(AdyenPaymentMethod::Atome) Ok(AdyenPaymentMethod::Atome)
} }
_ => Err(errors::ConnectorError::NotImplemented("Payment method".to_string()).into()), payments::PayLaterData::KlarnaSdk { .. } => Err(errors::ConnectorError::NotSupported {
message: utils::SELECTED_PAYMENT_METHOD.to_string(),
connector: "Adyen",
}
.into()),
} }
} }
} }
@ -2037,7 +2066,14 @@ impl<'a> TryFrom<&api_models::payments::BankRedirectData> for AdyenPaymentMethod
api_models::payments::BankRedirectData::Trustly { .. } => { api_models::payments::BankRedirectData::Trustly { .. } => {
Ok(AdyenPaymentMethod::Trustly) Ok(AdyenPaymentMethod::Trustly)
} }
_ => Err(errors::ConnectorError::NotImplemented("Payment method".to_string()).into()), payments::BankRedirectData::Interac { .. }
| payments::BankRedirectData::Przelewy24 { .. } => {
Err(errors::ConnectorError::NotSupported {
message: utils::SELECTED_PAYMENT_METHOD.to_string(),
connector: "Adyen",
}
.into())
}
} }
} }
} }
@ -2106,9 +2142,10 @@ impl<'a> TryFrom<&api_models::payments::BankTransferData> for AdyenPaymentMethod
| api_models::payments::BankTransferData::SepaBankTransfer { .. } | api_models::payments::BankTransferData::SepaBankTransfer { .. }
| api_models::payments::BankTransferData::BacsBankTransfer { .. } | api_models::payments::BankTransferData::BacsBankTransfer { .. }
| api_models::payments::BankTransferData::MultibancoBankTransfer { .. } | api_models::payments::BankTransferData::MultibancoBankTransfer { .. }
| payments::BankTransferData::Pse {} => { | payments::BankTransferData::Pse {} => Err(errors::ConnectorError::NotImplemented(
Err(errors::ConnectorError::NotImplemented("Payment method".to_string()).into()) utils::get_unimplemented_payment_method_error_message("Adyen"),
} )
.into()),
} }
} }
} }
@ -2179,10 +2216,23 @@ impl<'a>
}; };
Ok(AdyenPaymentMethod::AdyenCard(Box::new(adyen_card))) Ok(AdyenPaymentMethod::AdyenCard(Box::new(adyen_card)))
} }
_ => Err(errors::ConnectorError::NotSupported { payments::PaymentMethodData::CardRedirect(_)
message: format!("mandate_{:?}", item.payment_method), | payments::PaymentMethodData::Wallet(_)
connector: "Adyen", | payments::PaymentMethodData::PayLater(_)
})?, | payments::PaymentMethodData::BankRedirect(_)
| payments::PaymentMethodData::BankDebit(_)
| payments::PaymentMethodData::BankTransfer(_)
| payments::PaymentMethodData::Crypto(_)
| payments::PaymentMethodData::MandatePayment
| payments::PaymentMethodData::Reward
| payments::PaymentMethodData::Upi(_)
| payments::PaymentMethodData::Voucher(_)
| payments::PaymentMethodData::GiftCard(_) => {
Err(errors::ConnectorError::NotSupported {
message: "Network tokenization for payment method".to_string(),
connector: "Adyen",
})?
}
} }
} }
}?; }?;

2
crates/router/src/connector/utils.rs
View File

@ -80,7 +80,7 @@ pub trait RouterData {
pub const SELECTED_PAYMENT_METHOD: &str = "Selected payment method"; pub const SELECTED_PAYMENT_METHOD: &str = "Selected payment method";
pub fn get_unimplemented_payment_method_error_message(connector: &str) -> String { pub fn get_unimplemented_payment_method_error_message(connector: &str) -> String {
format!("Selected payment method through {}", connector) format!("{} through {}", SELECTED_PAYMENT_METHOD, connector)
} }
impl<Flow, Request, Response> RouterData for types::RouterData<Flow, Request, Response> { impl<Flow, Request, Response> RouterData for types::RouterData<Flow, Request, Response> {

1
crates/test_utils/tests/connectors/adyen_uk_ui.rs
View File

@ -852,6 +852,7 @@ fn should_make_adyen_touch_n_go_payment_test() {
tester!(should_make_adyen_touch_n_go_payment); tester!(should_make_adyen_touch_n_go_payment);
} }
#[ignore]
#[test] #[test]
#[serial] #[serial]
fn should_make_adyen_momo_atm_payment_test() { fn should_make_adyen_momo_atm_payment_test() {