From 90e8de18a854a7f83470e84a954ed365078c24c2 Mon Sep 17 00:00:00 2001 From: chikke srujan <121822803+srujanchikke@users.noreply.github.com> Date: Tue, 17 Sep 2024 17:53:41 +0530 Subject: [PATCH] fix(connector): add field types for bank debits (#5908) Co-authored-by: Chikke Srujan Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com> --- api-reference-v2/openapi_spec.json | 6 ++++ api-reference/openapi_spec.json | 6 ++++ crates/api_models/src/enums.rs | 1 + crates/router/src/configs/defaults.rs | 48 +++++++++++++-------------- 4 files changed, 37 insertions(+), 24 deletions(-) diff --git a/api-reference-v2/openapi_spec.json b/api-reference-v2/openapi_spec.json index 94cffcd75a..117c9d2e9e 100644 --- a/api-reference-v2/openapi_spec.json +++ b/api-reference-v2/openapi_spec.json @@ -7190,6 +7190,12 @@ "user_bank" ] }, + { + "type": "string", + "enum": [ + "user_bank_account_number" + ] + }, { "type": "string", "enum": [ diff --git a/api-reference/openapi_spec.json b/api-reference/openapi_spec.json index cf02aefcf7..c542f3491a 100644 --- a/api-reference/openapi_spec.json +++ b/api-reference/openapi_spec.json @@ -10846,6 +10846,12 @@ "user_bank" ] }, + { + "type": "string", + "enum": [ + "user_bank_account_number" + ] + }, { "type": "string", "enum": [ diff --git a/crates/api_models/src/enums.rs b/crates/api_models/src/enums.rs index 64af2349f7..bb2860acb0 100644 --- a/crates/api_models/src/enums.rs +++ b/crates/api_models/src/enums.rs @@ -507,6 +507,7 @@ pub enum FieldType { UserShippingAddressCountry { options: Vec }, UserBlikCode, UserBank, + UserBankAccountNumber, Text, DropDown { options: Vec }, UserDateOfBirth, diff --git a/crates/router/src/configs/defaults.rs b/crates/router/src/configs/defaults.rs index 659c94423d..a651d27adc 100644 --- a/crates/router/src/configs/defaults.rs +++ b/crates/router/src/configs/defaults.rs @@ -8773,15 +8773,6 @@ impl Default for super::settings::RequiredFields { value: None, } ), - ( - "billing.phone.country_code".to_string(), - RequiredFieldInfo { - required_field: "payment_method_data.billing.phone.country_code".to_string(), - display_name: "dialing_code".to_string(), - field_type: enums::FieldType::UserPhoneNumberCountryCode, - value: None, - } - ), ] ), } @@ -11069,7 +11060,7 @@ impl Default for super::settings::RequiredFields { RequiredFieldInfo { required_field: "payment_method_data.bank_debit.ach.account_number".to_string(), display_name: "bank_account_number".to_string(), - field_type: enums::FieldType::Text, + field_type: enums::FieldType::UserBankAccountNumber, value: None, } ), @@ -11111,7 +11102,7 @@ impl Default for super::settings::RequiredFields { RequiredFieldInfo { required_field: "payment_method_data.bank_debit.ach.account_number".to_string(), display_name: "bank_account_number".to_string(), - field_type: enums::FieldType::Text, + field_type: enums::FieldType::UserBankAccountNumber, value: None, } ), @@ -11159,9 +11150,9 @@ impl Default for super::settings::RequiredFields { ( "payment_method_data.bank_debit.sepa.iban".to_string(), RequiredFieldInfo { - required_field: "payment_method_data.bank_debit.bacs.iban".to_string(), - display_name: "bank_account_number".to_string(), - field_type: enums::FieldType::Text, + required_field: "payment_method_data.bank_debit.sepa.iban".to_string(), + display_name: "iban".to_string(), + field_type: enums::FieldType::UserIban, value: None, } ), @@ -11202,9 +11193,9 @@ impl Default for super::settings::RequiredFields { ( "payment_method_data.bank_debit.sepa.iban".to_string(), RequiredFieldInfo { - required_field: "payment_method_data.bank_debit.bacs.iban".to_string(), - display_name: "bank_account_number".to_string(), - field_type: enums::FieldType::Text, + required_field: "payment_method_data.bank_debit.sepa.iban".to_string(), + display_name: "iban".to_string(), + field_type: enums::FieldType::UserIban, value: None, } ) @@ -11233,12 +11224,21 @@ impl Default for super::settings::RequiredFields { value: None, } ), + ( + "billing.email".to_string(), + RequiredFieldInfo { + required_field: "payment_method_data.billing.email".to_string(), + display_name: "email".to_string(), + field_type: enums::FieldType::UserEmailAddress, + value: None, + } + ), ( "payment_method_data.bank_debit.sepa.iban".to_string(), RequiredFieldInfo { - required_field: "payment_method_data.bank_debit.bacs.iban".to_string(), - display_name: "bank_account_number".to_string(), - field_type: enums::FieldType::Text, + required_field: "payment_method_data.bank_debit.sepa.iban".to_string(), + display_name: "iban".to_string(), + field_type: enums::FieldType::UserIban, value: None, } ) @@ -11271,7 +11271,7 @@ impl Default for super::settings::RequiredFields { RequiredFieldInfo { required_field: "payment_method_data.bank_debit.bacs.account_number".to_string(), display_name: "bank_account_number".to_string(), - field_type: enums::FieldType::Text, + field_type: enums::FieldType::UserBankAccountNumber, value: None, } ), @@ -11343,7 +11343,7 @@ impl Default for super::settings::RequiredFields { RequiredFieldInfo { required_field: "payment_method_data.bank_debit.bacs.account_number".to_string(), display_name: "bank_account_number".to_string(), - field_type: enums::FieldType::Text, + field_type: enums::FieldType::UserBankAccountNumber, value: None, } ), @@ -11393,7 +11393,7 @@ impl Default for super::settings::RequiredFields { RequiredFieldInfo { required_field: "payment_method_data.bank_debit.becs.account_number".to_string(), display_name: "bank_account_number".to_string(), - field_type: enums::FieldType::Text, + field_type: enums::FieldType::UserBankAccountNumber, value: None, } ), @@ -11445,7 +11445,7 @@ impl Default for super::settings::RequiredFields { RequiredFieldInfo { required_field: "payment_method_data.bank_debit.bacs.account_number".to_string(), display_name: "bank_account_number".to_string(), - field_type: enums::FieldType::Text, + field_type: enums::FieldType::UserBankAccountNumber, value: None, } ),