fix(core): do not construct request if it is already available (#3826)

This commit is contained in:
Narayan Bhat
2024-02-26 19:31:36 +05:30
committed by GitHub
parent 2185cd38c1
commit 84d91a7b34

View File

@ -338,30 +338,31 @@ where
], ],
); );
let connector_request = connector_request.or(connector_integration let connector_request = match connector_request {
.build_request(req, &state.conf.connectors) Some(connector_request) => Some(connector_request),
.map_err(|error| { None => connector_integration
if matches!( .build_request(req, &state.conf.connectors)
error.current_context(), .map_err(|error| {
&errors::ConnectorError::RequestEncodingFailed if matches!(
| &errors::ConnectorError::RequestEncodingFailedWithReason(_) error.current_context(),
) { &errors::ConnectorError::RequestEncodingFailed
metrics::REQUEST_BUILD_FAILURE.add( | &errors::ConnectorError::RequestEncodingFailedWithReason(_)
&metrics::CONTEXT, ) {
1, metrics::REQUEST_BUILD_FAILURE.add(
&[metrics::request::add_attributes( &metrics::CONTEXT,
"connector", 1,
req.connector.to_string(), &[metrics::request::add_attributes(
)], "connector",
) req.connector.to_string(),
} )],
error )
})?); }
error
})?,
};
match connector_request { match connector_request {
Some(request) => { Some(request) => {
logger::debug!(connector_request=?request);
let masked_request_body = match &request.body { let masked_request_body = match &request.body {
Some(request) => match request { Some(request) => match request {
RequestContent::Json(i) RequestContent::Json(i)
@ -1828,7 +1829,7 @@ pub fn build_redirection_form(
threeDSsecureInterface.on('challenge', function(e) {{ threeDSsecureInterface.on('challenge', function(e) {{
console.log('Challenged'); console.log('Challenged');
document.getElementById('loader-wrapper').style.display = 'none'; document.getElementById('loader-wrapper').style.display = 'none';
}}); }});
threeDSsecureInterface.on('complete', function(e) {{ threeDSsecureInterface.on('complete', function(e) {{