From 76b47e64c4186ba0bf056427d9287482cf636188 Mon Sep 17 00:00:00 2001 From: Nishant Joshi Date: Tue, 20 Dec 2022 17:55:24 +0530 Subject: [PATCH] fix: remove and resolve `FIXME`s and `TODO`s from db module (#174) --- crates/common_utils/src/lib.rs | 3 ++- crates/router/src/core/errors.rs | 2 ++ crates/router/src/db/address.rs | 12 ++++++--- crates/router/src/db/configs.rs | 9 ++++--- crates/router/src/db/connector_response.rs | 5 +++- crates/router/src/db/customers.rs | 9 ++++--- crates/router/src/db/events.rs | 3 ++- crates/router/src/db/locker_mock_up.rs | 9 ++++--- crates/router/src/db/mandate.rs | 12 ++++++--- crates/router/src/db/merchant_account.rs | 12 ++++++--- .../src/db/merchant_connector_account.rs | 14 ++++++++--- crates/router/src/db/payment_attempt.rs | 25 +++++++++++-------- crates/router/src/db/payment_intent.rs | 12 +++++---- crates/router/src/db/payment_method.rs | 12 ++++++--- crates/router/src/db/process_tracker.rs | 15 +++++++---- crates/router/src/db/queue.rs | 17 +++++++++---- crates/router/src/db/refund.rs | 9 ++++--- crates/router/src/db/temp_card.rs | 9 ++++--- crates/router/src/lib.rs | 2 ++ crates/router/src/routes/payment_methods.rs | 1 + crates/router/src/scheduler/workflows.rs | 1 + crates/router/src/types/api/payments.rs | 2 +- 22 files changed, 130 insertions(+), 65 deletions(-) diff --git a/crates/common_utils/src/lib.rs b/crates/common_utils/src/lib.rs index 7276a9b92d..2329ddb375 100644 --- a/crates/common_utils/src/lib.rs +++ b/crates/common_utils/src/lib.rs @@ -10,7 +10,8 @@ clippy::panicking_unwrap, clippy::unreachable, clippy::unwrap_in_result, - clippy::unwrap_used + clippy::unwrap_used, + clippy::unimplemented )] #![doc = include_str!(concat!(env!("CARGO_MANIFEST_DIR" ), "/", "README.md"))] diff --git a/crates/router/src/core/errors.rs b/crates/router/src/core/errors.rs index 9bc2496aa9..f0c9981acd 100644 --- a/crates/router/src/core/errors.rs +++ b/crates/router/src/core/errors.rs @@ -76,6 +76,8 @@ pub enum StorageError { DuplicateValue(String), #[error("KV error")] KVError, + #[error("MockDb error")] + MockDbError, } impl From> for StorageError { diff --git a/crates/router/src/db/address.rs b/crates/router/src/db/address.rs index 9a763044a2..268d9c8649 100644 --- a/crates/router/src/db/address.rs +++ b/crates/router/src/db/address.rs @@ -95,7 +95,8 @@ impl AddressInterface for MockDb { &self, _address_id: &str, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn update_address( @@ -103,14 +104,16 @@ impl AddressInterface for MockDb { _address_id: String, _address: storage::AddressUpdate, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn insert_address( &self, _address: storage::AddressNew, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn update_address_by_merchant_id_customer_id( @@ -119,6 +122,7 @@ impl AddressInterface for MockDb { _merchant_id: &str, _address: storage::AddressUpdate, ) -> CustomResult, errors::StorageError> { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } } diff --git a/crates/router/src/db/configs.rs b/crates/router/src/db/configs.rs index 0b39d173e2..7b8a1fc10b 100644 --- a/crates/router/src/db/configs.rs +++ b/crates/router/src/db/configs.rs @@ -64,14 +64,16 @@ impl ConfigInterface for MockDb { &self, _config: storage::ConfigNew, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn find_config_by_key( &self, _key: &str, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn update_config_by_key( @@ -79,6 +81,7 @@ impl ConfigInterface for MockDb { _key: &str, _config_update: storage::ConfigUpdate, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } } diff --git a/crates/router/src/db/connector_response.rs b/crates/router/src/db/connector_response.rs index fb30a6edc3..dbb2041d0c 100644 --- a/crates/router/src/db/connector_response.rs +++ b/crates/router/src/db/connector_response.rs @@ -110,9 +110,12 @@ impl ConnectorResponseInterface for MockDb { _txn_id: &str, _storage_scheme: enums::MerchantStorageScheme, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } + // safety: interface only used for testing + #[allow(clippy::unwrap_used)] async fn update_connector_response( &self, this: storage::ConnectorResponse, diff --git a/crates/router/src/db/customers.rs b/crates/router/src/db/customers.rs index 3e9d83d22a..accfc96859 100644 --- a/crates/router/src/db/customers.rs +++ b/crates/router/src/db/customers.rs @@ -133,7 +133,8 @@ impl CustomerInterface for MockDb { _merchant_id: String, _customer: storage::CustomerUpdate, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn find_customer_by_customer_id_merchant_id( @@ -141,7 +142,8 @@ impl CustomerInterface for MockDb { _customer_id: &str, _merchant_id: &str, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } #[allow(clippy::panic)] @@ -171,6 +173,7 @@ impl CustomerInterface for MockDb { _customer_id: &str, _merchant_id: &str, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } } diff --git a/crates/router/src/db/events.rs b/crates/router/src/db/events.rs index 0d84daaf56..e3b55f71c7 100644 --- a/crates/router/src/db/events.rs +++ b/crates/router/src/db/events.rs @@ -32,6 +32,7 @@ impl EventInterface for MockDb { &self, _event: storage::EventNew, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } } diff --git a/crates/router/src/db/locker_mock_up.rs b/crates/router/src/db/locker_mock_up.rs index cc02372634..50227ee783 100644 --- a/crates/router/src/db/locker_mock_up.rs +++ b/crates/router/src/db/locker_mock_up.rs @@ -64,20 +64,23 @@ impl LockerMockUpInterface for MockDb { &self, _card_id: &str, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn insert_locker_mock_up( &self, _new: storage::LockerMockUpNew, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn delete_locker_mock_up( &self, _card_id: &str, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } } diff --git a/crates/router/src/db/mandate.rs b/crates/router/src/db/mandate.rs index aaafdd0039..32046f12fd 100644 --- a/crates/router/src/db/mandate.rs +++ b/crates/router/src/db/mandate.rs @@ -93,7 +93,8 @@ impl MandateInterface for MockDb { _merchant_id: &str, _mandate_id: &str, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn find_mandate_by_merchant_id_customer_id( @@ -101,7 +102,8 @@ impl MandateInterface for MockDb { _merchant_id: &str, _customer_id: &str, ) -> CustomResult, errors::StorageError> { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn update_mandate_by_merchant_id_mandate_id( @@ -110,13 +112,15 @@ impl MandateInterface for MockDb { _mandate_id: &str, _mandate: storage::MandateUpdate, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn insert_mandate( &self, _mandate: storage::MandateNew, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } } diff --git a/crates/router/src/db/merchant_account.rs b/crates/router/src/db/merchant_account.rs index 61b273d18d..750d8af5b9 100644 --- a/crates/router/src/db/merchant_account.rs +++ b/crates/router/src/db/merchant_account.rs @@ -159,7 +159,8 @@ impl MerchantAccountInterface for MockDb { match account { Some(account) => Ok(account.clone()), - None => todo!(), + // [#172]: Implement function for `MockDb` + None => Err(errors::StorageError::MockDbError)?, } } @@ -168,7 +169,8 @@ impl MerchantAccountInterface for MockDb { _this: storage::MerchantAccount, _merchant_account: storage::MerchantAccountUpdate, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } #[allow(clippy::panic)] @@ -190,13 +192,15 @@ impl MerchantAccountInterface for MockDb { &self, _publishable_key: &str, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn delete_merchant_account_by_merchant_id( &self, _merchant_id: &str, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } } diff --git a/crates/router/src/db/merchant_connector_account.rs b/crates/router/src/db/merchant_connector_account.rs index dc42160c0f..d422060632 100644 --- a/crates/router/src/db/merchant_connector_account.rs +++ b/crates/router/src/db/merchant_connector_account.rs @@ -129,6 +129,8 @@ impl MerchantConnectorAccountInterface for Store { #[async_trait::async_trait] impl MerchantConnectorAccountInterface for MockDb { + // safety: only used for testing + #[allow(clippy::unwrap_used)] async fn find_merchant_connector_account_by_merchant_id_connector( &self, merchant_id: &str, @@ -150,7 +152,8 @@ impl MerchantConnectorAccountInterface for MockDb { _merchant_id: &str, _merchant_connector_id: &i32, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } #[allow(clippy::panic)] @@ -181,7 +184,8 @@ impl MerchantConnectorAccountInterface for MockDb { &self, _merchant_id: &str, ) -> CustomResult, errors::StorageError> { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn update_merchant_connector_account( @@ -189,7 +193,8 @@ impl MerchantConnectorAccountInterface for MockDb { _this: storage::MerchantConnectorAccount, _merchant_connector_account: storage::MerchantConnectorAccountUpdate, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn delete_merchant_connector_account_by_merchant_id_merchant_connector_id( @@ -197,6 +202,7 @@ impl MerchantConnectorAccountInterface for MockDb { _merchant_id: &str, _merchant_connector_id: &i32, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } } diff --git a/crates/router/src/db/payment_attempt.rs b/crates/router/src/db/payment_attempt.rs index 8afe83519f..cd6a7fdb5c 100644 --- a/crates/router/src/db/payment_attempt.rs +++ b/crates/router/src/db/payment_attempt.rs @@ -152,8 +152,6 @@ mod storage { _storage_scheme: enums::MerchantStorageScheme, ) -> CustomResult { let conn = pg_connection(&self.master_pool).await; - // TODO: update logic to lookup all payment attempts for an intent - // and apply filter logic on top of them to get the desired one. PaymentAttempt::find_by_merchant_id_connector_txn_id( &conn, merchant_id, @@ -188,7 +186,8 @@ impl PaymentAttemptInterface for MockDb { _attempt_id: &str, _storage_scheme: enums::MerchantStorageScheme, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn find_payment_attempt_by_merchant_id_connector_txn_id( @@ -197,7 +196,8 @@ impl PaymentAttemptInterface for MockDb { _connector_txn_id: &str, _storage_scheme: enums::MerchantStorageScheme, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } #[allow(clippy::panic)] @@ -247,6 +247,8 @@ impl PaymentAttemptInterface for MockDb { Ok(payment_attempt) } + // safety: only used for testing + #[allow(clippy::unwrap_used)] async fn update_payment_attempt( &self, this: types::PaymentAttempt, @@ -271,7 +273,8 @@ impl PaymentAttemptInterface for MockDb { _merchant_id: &str, _storage_scheme: enums::MerchantStorageScheme, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn find_payment_attempt_by_transaction_id_payment_id_merchant_id( @@ -281,9 +284,12 @@ impl PaymentAttemptInterface for MockDb { _merchant_id: &str, _storage_scheme: enums::MerchantStorageScheme, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } + // safety: only used for testing + #[allow(clippy::unwrap_used)] async fn find_payment_attempt_last_successful_attempt_by_payment_id_merchant_id( &self, payment_id: &str, @@ -341,10 +347,9 @@ mod storage { "{}_{}", payment_attempt.merchant_id, payment_attempt.payment_id ); - // TODO: need to add an application generated payment attempt id to distinguish between multiple attempts for the same payment id - // Check for database presence as well Maybe use a read replica here ? + let created_attempt = PaymentAttempt { - id: 0i32, + id: Default::default(), payment_id: payment_attempt.payment_id.clone(), merchant_id: payment_attempt.merchant_id.clone(), attempt_id: payment_attempt.attempt_id.clone(), @@ -611,8 +616,6 @@ mod storage { match storage_scheme { enums::MerchantStorageScheme::PostgresOnly => { let conn = pg_connection(&self.master_pool).await; - // TODO: update logic to lookup all payment attempts for an intent - // and apply filter logic on top of them to get the desired one. PaymentAttempt::find_by_merchant_id_connector_txn_id( &conn, merchant_id, diff --git a/crates/router/src/db/payment_intent.rs b/crates/router/src/db/payment_intent.rs index 0dcad4d7e7..df170182a4 100644 --- a/crates/router/src/db/payment_intent.rs +++ b/crates/router/src/db/payment_intent.rs @@ -249,10 +249,7 @@ mod storage { .into_report() } - enums::MerchantStorageScheme::RedisKv => { - //TODO: Implement this - Err(errors::StorageError::KVError.into()) - } + enums::MerchantStorageScheme::RedisKv => Err(errors::StorageError::KVError.into()), } } } @@ -333,7 +330,8 @@ impl PaymentIntentInterface for MockDb { _pc: &api::PaymentListConstraints, _storage_scheme: enums::MerchantStorageScheme, ) -> CustomResult, errors::StorageError> { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } #[allow(clippy::panic)] @@ -372,6 +370,8 @@ impl PaymentIntentInterface for MockDb { Ok(payment_intent) } + // safety: only used for testing + #[allow(clippy::unwrap_used)] async fn update_payment_intent( &self, this: types::PaymentIntent, @@ -387,6 +387,8 @@ impl PaymentIntentInterface for MockDb { Ok(payment_intent.clone()) } + // safety: only used for testing + #[allow(clippy::unwrap_used)] async fn find_payment_intent_by_payment_id_merchant_id( &self, payment_id: &str, diff --git a/crates/router/src/db/payment_method.rs b/crates/router/src/db/payment_method.rs index 3f6d8ecd69..2a83d95006 100644 --- a/crates/router/src/db/payment_method.rs +++ b/crates/router/src/db/payment_method.rs @@ -88,14 +88,16 @@ impl PaymentMethodInterface for MockDb { &self, _payment_method_id: &str, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn insert_payment_method( &self, _m: storage::PaymentMethodNew, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn find_payment_method_by_customer_id_merchant_id_list( @@ -103,7 +105,8 @@ impl PaymentMethodInterface for MockDb { _customer_id: &str, _merchant_id: &str, ) -> CustomResult, errors::StorageError> { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn delete_payment_method_by_merchant_id_payment_method_id( @@ -111,6 +114,7 @@ impl PaymentMethodInterface for MockDb { _merchant_id: &str, _payment_method_id: &str, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } } diff --git a/crates/router/src/db/process_tracker.rs b/crates/router/src/db/process_tracker.rs index 396b511d59..2f3e5bce38 100644 --- a/crates/router/src/db/process_tracker.rs +++ b/crates/router/src/db/process_tracker.rs @@ -167,7 +167,8 @@ impl ProcessTrackerInterface for MockDb { _ids: Vec, _schedule_time: PrimitiveDateTime, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn find_processes_by_time_status( @@ -177,7 +178,8 @@ impl ProcessTrackerInterface for MockDb { _status: enums::ProcessTrackerStatus, _limit: Option, ) -> CustomResult, errors::StorageError> { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn insert_process( @@ -209,7 +211,8 @@ impl ProcessTrackerInterface for MockDb { _this: storage::ProcessTracker, _process: storage::ProcessTrackerUpdate, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn update_process_tracker( @@ -217,7 +220,8 @@ impl ProcessTrackerInterface for MockDb { _this: storage::ProcessTracker, _process: storage::ProcessTrackerUpdate, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn process_tracker_update_process_status_by_ids( @@ -225,6 +229,7 @@ impl ProcessTrackerInterface for MockDb { _task_ids: Vec, _task_update: storage::ProcessTrackerUpdate, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } } diff --git a/crates/router/src/db/queue.rs b/crates/router/src/db/queue.rs index 448bf958f8..4396c31b72 100644 --- a/crates/router/src/db/queue.rs +++ b/crates/router/src/db/queue.rs @@ -126,7 +126,10 @@ impl QueueInterface for MockDb { _group_name: &str, _consumer_name: &str, ) -> CustomResult, ProcessTrackerError> { - todo!() + // [#172]: Implement function for `MockDb` + Err(ProcessTrackerError::ResourceFetchingFailed { + resource_name: "consumer_tasks".to_string(), + })? } async fn consumer_group_create( @@ -135,7 +138,8 @@ impl QueueInterface for MockDb { _group: &str, _id: &RedisEntryId, ) -> CustomResult<(), RedisError> { - todo!() + // [#172]: Implement function for `MockDb` + Err(RedisError::ConsumerGroupCreateFailed)? } async fn acquire_pt_lock( @@ -145,11 +149,13 @@ impl QueueInterface for MockDb { _lock_val: &str, _ttl: i64, ) -> bool { - todo!() + // [#172]: Implement function for `MockDb` + false } async fn release_pt_lock(&self, _tag: &str, _lock_key: &str) -> bool { - todo!() + // [#172]: Implement function for `MockDb` + false } async fn stream_append_entry( @@ -158,7 +164,8 @@ impl QueueInterface for MockDb { _entry_id: &RedisEntryId, _fields: Vec<(&str, String)>, ) -> CustomResult<(), RedisError> { - todo!() + // [#172]: Implement function for `MockDb` + Err(RedisError::StreamAppendFailed)? } async fn get_key(&self, key: &str) -> CustomResult, RedisError> { diff --git a/crates/router/src/db/refund.rs b/crates/router/src/db/refund.rs index 9215010455..8c71a80b96 100644 --- a/crates/router/src/db/refund.rs +++ b/crates/router/src/db/refund.rs @@ -553,7 +553,8 @@ impl RefundInterface for MockDb { _merchant_id: &str, _storage_scheme: enums::MerchantStorageScheme, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn insert_refund( @@ -614,7 +615,8 @@ impl RefundInterface for MockDb { _refund: storage_types::RefundUpdate, _storage_scheme: enums::MerchantStorageScheme, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn find_refund_by_merchant_id_refund_id( @@ -642,6 +644,7 @@ impl RefundInterface for MockDb { _merchant_id: &str, _storage_scheme: enums::MerchantStorageScheme, ) -> CustomResult, errors::StorageError> { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } } diff --git a/crates/router/src/db/temp_card.rs b/crates/router/src/db/temp_card.rs index 639da61bd2..0b3af9cce4 100644 --- a/crates/router/src/db/temp_card.rs +++ b/crates/router/src/db/temp_card.rs @@ -100,20 +100,23 @@ impl TempCardInterface for MockDb { &self, _transaction_id: &str, ) -> CustomResult, errors::StorageError> { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn insert_tempcard_with_token( &self, _card: storage::TempCard, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } async fn find_tempcard_by_token( &self, _token: &i32, ) -> CustomResult { - todo!() + // [#172]: Implement function for `MockDb` + Err(errors::StorageError::MockDbError)? } } diff --git a/crates/router/src/lib.rs b/crates/router/src/lib.rs index 21d3535fd6..aec94fa21a 100644 --- a/crates/router/src/lib.rs +++ b/crates/router/src/lib.rs @@ -13,8 +13,10 @@ clippy::panic, clippy::panic_in_result_fn, clippy::panicking_unwrap, + clippy::todo, clippy::unreachable, clippy::unwrap_in_result, + clippy::unwrap_used )] #![recursion_limit = "256"] diff --git a/crates/router/src/routes/payment_methods.rs b/crates/router/src/routes/payment_methods.rs index c1e3be217f..868dc2fe75 100644 --- a/crates/router/src/routes/payment_methods.rs +++ b/crates/router/src/routes/payment_methods.rs @@ -158,6 +158,7 @@ pub async fn payment_method_delete_api( #[cfg(test)] mod tests { + #![allow(clippy::unwrap_used)] use api_models::payment_methods::ListPaymentMethodRequest; use super::*; diff --git a/crates/router/src/scheduler/workflows.rs b/crates/router/src/scheduler/workflows.rs index a8dbc1b555..a8076eed10 100644 --- a/crates/router/src/scheduler/workflows.rs +++ b/crates/router/src/scheduler/workflows.rs @@ -76,6 +76,7 @@ pub trait ProcessTrackerWorkflow: Send + Sync { #[cfg(test)] mod workflow_tests { + #![allow(clippy::unwrap_used)] use super::PTRunner; use crate::utils::StringExt; diff --git a/crates/router/src/types/api/payments.rs b/crates/router/src/types/api/payments.rs index d68f2f3ce7..97975d6aca 100644 --- a/crates/router/src/types/api/payments.rs +++ b/crates/router/src/types/api/payments.rs @@ -178,7 +178,7 @@ pub trait Payment: #[cfg(test)] mod payments_test { - #![allow(clippy::expect_used)] + #![allow(clippy::expect_used, clippy::unwrap_used)] use super::*;