rust/hyperswitch
1
0
Fork 0
mirror of https://github.com/juspay/hyperswitch.git synced 2025-10-29 17:19:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(connector): [NMI] Populating ErrorResponse with required fields and Mapping connector_response_reference_id (#3214)

Browse Source 
Co-authored-by: Prasunna Soppa <prasunna.soppa@juspay.in>
This commit is contained in:
Sakil Mostak
2024-01-05 18:56:07 +05:30
committed by GitHub
parent c3172ef606
commit 64babd3478
2 changed files with 34 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
crates/router/src/connector/nmi.rs
View File

@ -75,10 +75,12 @@ impl ConnectorCommon for Nmi {
.parse_struct("StandardResponse") .parse_struct("StandardResponse")
.change_context(errors::ConnectorError::ResponseDeserializationFailed)?; .change_context(errors::ConnectorError::ResponseDeserializationFailed)?;
Ok(ErrorResponse { Ok(ErrorResponse {
message: response.responsetext, message: response.responsetext.to_owned(),
status_code: res.status_code, status_code: res.status_code,
reason: None, reason: Some(response.responsetext),
..Default::default() code: response.response_code,
attempt_status: None,
connector_transaction_id: Some(response.transactionid),
}) })
} }
} }

53
crates/router/src/connector/nmi/transformers.rs
View File

@ -143,6 +143,7 @@ pub struct NmiVaultResponse {
pub responsetext: String, pub responsetext: String,
pub customer_vault_id: Option<String>, pub customer_vault_id: Option<String>,
pub response_code: String, pub response_code: String,
pub transactionid: String,
} }
impl impl
@ -205,7 +206,7 @@ impl
mandate_reference: None, mandate_reference: None,
connector_metadata: None, connector_metadata: None,
network_txn_id: None, network_txn_id: None,
connector_response_reference_id: None, connector_response_reference_id: Some(item.response.transactionid),
incremental_authorization_allowed: None, incremental_authorization_allowed: None,
}), }),
enums::AttemptStatus::AuthenticationPending, enums::AttemptStatus::AuthenticationPending,
@ -213,11 +214,11 @@ impl
Response::Declined | Response::Error => ( Response::Declined | Response::Error => (
Err(types::ErrorResponse { Err(types::ErrorResponse {
code: item.response.response_code, code: item.response.response_code,
message: item.response.responsetext, message: item.response.responsetext.to_owned(),
reason: None, reason: Some(item.response.responsetext),
status_code: item.http_code, status_code: item.http_code,
attempt_status: None, attempt_status: None,
connector_transaction_id: None, connector_transaction_id: Some(item.response.transactionid),
}), }),
enums::AttemptStatus::Failure, enums::AttemptStatus::Failure,
), ),
@ -346,12 +347,14 @@ impl
let (response, status) = match item.response.response { let (response, status) = match item.response.response {
Response::Approved => ( Response::Approved => (
Ok(types::PaymentsResponseData::TransactionResponse { Ok(types::PaymentsResponseData::TransactionResponse {
resource_id: types::ResponseId::ConnectorTransactionId(item.response.orderid), resource_id: types::ResponseId::ConnectorTransactionId(
item.response.transactionid,
),
redirection_data: None, redirection_data: None,
mandate_reference: None, mandate_reference: None,
connector_metadata: None, connector_metadata: None,
network_txn_id: None, network_txn_id: None,
connector_response_reference_id: None, connector_response_reference_id: Some(item.response.orderid),
incremental_authorization_allowed: None, incremental_authorization_allowed: None,
}), }),
if let Some(diesel_models::enums::CaptureMethod::Automatic) = if let Some(diesel_models::enums::CaptureMethod::Automatic) =
@ -382,11 +385,11 @@ impl ForeignFrom<(NmiCompleteResponse, u16)> for types::ErrorResponse {
fn foreign_from((response, http_code): (NmiCompleteResponse, u16)) -> Self { fn foreign_from((response, http_code): (NmiCompleteResponse, u16)) -> Self {
Self { Self {
code: response.response_code, code: response.response_code,
message: response.responsetext, message: response.responsetext.to_owned(),
reason: None, reason: Some(response.responsetext),
status_code: http_code, status_code: http_code,
attempt_status: None, attempt_status: None,
connector_transaction_id: None, connector_transaction_id: Some(response.transactionid),
} }
} }
} }
@ -632,13 +635,13 @@ impl
Response::Approved => ( Response::Approved => (
Ok(types::PaymentsResponseData::TransactionResponse { Ok(types::PaymentsResponseData::TransactionResponse {
resource_id: types::ResponseId::ConnectorTransactionId( resource_id: types::ResponseId::ConnectorTransactionId(
item.response.transactionid, item.response.transactionid.to_owned(),
), ),
redirection_data: None, redirection_data: None,
mandate_reference: None, mandate_reference: None,
connector_metadata: None, connector_metadata: None,
network_txn_id: None, network_txn_id: None,
connector_response_reference_id: None, connector_response_reference_id: Some(item.response.orderid),
incremental_authorization_allowed: None, incremental_authorization_allowed: None,
}), }),
enums::AttemptStatus::CaptureInitiated, enums::AttemptStatus::CaptureInitiated,
@ -726,13 +729,13 @@ impl<T>
Response::Approved => ( Response::Approved => (
Ok(types::PaymentsResponseData::TransactionResponse { Ok(types::PaymentsResponseData::TransactionResponse {
resource_id: types::ResponseId::ConnectorTransactionId( resource_id: types::ResponseId::ConnectorTransactionId(
item.response.transactionid, item.response.transactionid.to_owned(),
), ),
redirection_data: None, redirection_data: None,
mandate_reference: None, mandate_reference: None,
connector_metadata: None, connector_metadata: None,
network_txn_id: None, network_txn_id: None,
connector_response_reference_id: None, connector_response_reference_id: Some(item.response.orderid),
incremental_authorization_allowed: None, incremental_authorization_allowed: None,
}), }),
enums::AttemptStatus::Charged, enums::AttemptStatus::Charged,
@ -757,11 +760,11 @@ impl ForeignFrom<(StandardResponse, u16)> for types::ErrorResponse {
fn foreign_from((response, http_code): (StandardResponse, u16)) -> Self { fn foreign_from((response, http_code): (StandardResponse, u16)) -> Self {
Self { Self {
code: response.response_code, code: response.response_code,
message: response.responsetext, message: response.responsetext.to_owned(),
reason: None, reason: Some(response.responsetext),
status_code: http_code, status_code: http_code,
attempt_status: None, attempt_status: None,
connector_transaction_id: None, connector_transaction_id: Some(response.transactionid),
} }
} }
} }
@ -782,13 +785,13 @@ impl TryFrom<types::PaymentsResponseRouterData<StandardResponse>>
Response::Approved => ( Response::Approved => (
Ok(types::PaymentsResponseData::TransactionResponse { Ok(types::PaymentsResponseData::TransactionResponse {
resource_id: types::ResponseId::ConnectorTransactionId( resource_id: types::ResponseId::ConnectorTransactionId(
item.response.transactionid, item.response.transactionid.to_owned(),
), ),
redirection_data: None, redirection_data: None,
mandate_reference: None, mandate_reference: None,
connector_metadata: None, connector_metadata: None,
network_txn_id: None, network_txn_id: None,
connector_response_reference_id: None, connector_response_reference_id: Some(item.response.orderid),
incremental_authorization_allowed: None, incremental_authorization_allowed: None,
}), }),
if let Some(diesel_models::enums::CaptureMethod::Automatic) = if let Some(diesel_models::enums::CaptureMethod::Automatic) =
@ -832,13 +835,13 @@ impl<T>
Response::Approved => ( Response::Approved => (
Ok(types::PaymentsResponseData::TransactionResponse { Ok(types::PaymentsResponseData::TransactionResponse {
resource_id: types::ResponseId::ConnectorTransactionId( resource_id: types::ResponseId::ConnectorTransactionId(
item.response.transactionid, item.response.transactionid.to_owned(),
), ),
redirection_data: None, redirection_data: None,
mandate_reference: None, mandate_reference: None,
connector_metadata: None, connector_metadata: None,
network_txn_id: None, network_txn_id: None,
connector_response_reference_id: None, connector_response_reference_id: Some(item.response.orderid),
incremental_authorization_allowed: None, incremental_authorization_allowed: None,
}), }),
enums::AttemptStatus::VoidInitiated, enums::AttemptStatus::VoidInitiated,
@ -1163,8 +1166,12 @@ pub enum NmiWebhookEventType {
impl ForeignFrom<NmiWebhookEventType> for webhooks::IncomingWebhookEvent { impl ForeignFrom<NmiWebhookEventType> for webhooks::IncomingWebhookEvent {
fn foreign_from(status: NmiWebhookEventType) -> Self { fn foreign_from(status: NmiWebhookEventType) -> Self {
match status { match status {
NmiWebhookEventType::SaleSuccess => Self::PaymentIntentSuccess, NmiWebhookEventType::SaleSuccess | NmiWebhookEventType::CaptureSuccess => {
NmiWebhookEventType::SaleFailure => Self::PaymentIntentFailure, Self::PaymentIntentSuccess
}
NmiWebhookEventType::SaleFailure | NmiWebhookEventType::CaptureFailure => {
Self::PaymentIntentFailure
}
NmiWebhookEventType::RefundSuccess => Self::RefundSuccess, NmiWebhookEventType::RefundSuccess => Self::RefundSuccess,
NmiWebhookEventType::RefundFailure => Self::RefundFailure, NmiWebhookEventType::RefundFailure => Self::RefundFailure,
NmiWebhookEventType::VoidSuccess => Self::PaymentIntentCancelled, NmiWebhookEventType::VoidSuccess => Self::PaymentIntentCancelled,
@ -1175,8 +1182,6 @@ impl ForeignFrom<NmiWebhookEventType> for webhooks::IncomingWebhookEvent {
| NmiWebhookEventType::AuthUnknown | NmiWebhookEventType::AuthUnknown
| NmiWebhookEventType::VoidFailure | NmiWebhookEventType::VoidFailure
| NmiWebhookEventType::VoidUnknown | NmiWebhookEventType::VoidUnknown
| NmiWebhookEventType::CaptureSuccess
| NmiWebhookEventType::CaptureFailure
| NmiWebhookEventType::CaptureUnknown => Self::EventNotSupported, | NmiWebhookEventType::CaptureUnknown => Self::EventNotSupported,
} }
} }