fix: make kv log extraction easier (#2666)

This commit is contained in:
Kartikeya Hegde
2023-10-30 17:08:18 +05:30
committed by GitHub
parent d682471001
commit 577ef1ae1a

View File

@ -107,7 +107,7 @@ where
let result = async { let result = async {
match op { match op {
KvOperation::Hset(value, sql) => { KvOperation::Hset(value, sql) => {
logger::debug!("Operation: {operation} value: {value:?}"); logger::debug!(kv_operation= %operation, value = ?value);
redis_conn redis_conn
.set_hash_fields(key, value, Some(consts::KV_TTL)) .set_hash_fields(key, value, Some(consts::KV_TTL))
@ -133,7 +133,7 @@ where
} }
KvOperation::HSetNx(field, value, sql) => { KvOperation::HSetNx(field, value, sql) => {
logger::debug!("Operation: {operation} value: {value:?}"); logger::debug!(kv_operation= %operation, value = ?value);
let result = redis_conn let result = redis_conn
.serialize_and_set_hash_field_if_not_exist( .serialize_and_set_hash_field_if_not_exist(
@ -153,7 +153,7 @@ where
} }
KvOperation::SetNx(value, sql) => { KvOperation::SetNx(value, sql) => {
logger::debug!("Operation: {operation} value: {value:?}"); logger::debug!(kv_operation= %operation, value = ?value);
let result = redis_conn let result = redis_conn
.serialize_and_set_key_if_not_exist(key, value, Some(consts::KV_TTL.into())) .serialize_and_set_key_if_not_exist(key, value, Some(consts::KV_TTL.into()))
@ -178,14 +178,14 @@ where
result result
.await .await
.map(|result| { .map(|result| {
logger::debug!("KvOperation {operation} succeeded"); logger::debug!(kv_operation= %operation, status="success");
let keyvalue = router_env::opentelemetry::KeyValue::new("operation", operation.clone()); let keyvalue = router_env::opentelemetry::KeyValue::new("operation", operation.clone());
metrics::KV_OPERATION_SUCCESSFUL.add(&metrics::CONTEXT, 1, &[keyvalue]); metrics::KV_OPERATION_SUCCESSFUL.add(&metrics::CONTEXT, 1, &[keyvalue]);
result result
}) })
.map_err(|err| { .map_err(|err| {
logger::error!("KvOperation for {operation} failed with {err:?}"); logger::error!(kv_operation = %operation, status="error", error = ?err);
let keyvalue = router_env::opentelemetry::KeyValue::new("operation", operation); let keyvalue = router_env::opentelemetry::KeyValue::new("operation", operation);
metrics::KV_OPERATION_FAILED.add(&metrics::CONTEXT, 1, &[keyvalue]); metrics::KV_OPERATION_FAILED.add(&metrics::CONTEXT, 1, &[keyvalue]);