rust/hyperswitch
1
0
Fork 0
mirror of https://github.com/juspay/hyperswitch.git synced 2025-11-01 02:57:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(router): send connection_closed errors as 5xx instead of 2xx (#2093)

Browse Source
This commit is contained in:
Sai Harsha Vardhan
2023-09-06 19:45:33 +05:30
committed by GitHub
parent 5a49802f56
commit 4d58bdbe29
2 changed files with 0 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
crates/router/src/consts.rs
View File

@ -13,9 +13,6 @@ pub(crate) const ALPHABETS: [char; 62] = [
pub const REQUEST_TIME_OUT: u64 = 30; pub const REQUEST_TIME_OUT: u64 = 30;
pub const REQUEST_TIMEOUT_ERROR_CODE: &str = "TIMEOUT"; pub const REQUEST_TIMEOUT_ERROR_CODE: &str = "TIMEOUT";
pub const REQUEST_TIMEOUT_ERROR_MESSAGE: &str = "Connector did not respond in specified time"; pub const REQUEST_TIMEOUT_ERROR_MESSAGE: &str = "Connector did not respond in specified time";
pub const CONNECTION_CLOSED_ERROR_CODE: &str = "CONNECTION_CLOSED";
pub const CONNECTION_CLOSED_ERROR_MESSAGE: &str =
"Connection closed before a message could complete";
///Payment intent fulfillment default timeout (in seconds) ///Payment intent fulfillment default timeout (in seconds)
pub const DEFAULT_FULFILLMENT_TIME: i64 = 15 * 60; pub const DEFAULT_FULFILLMENT_TIME: i64 = 15 * 60;

12
crates/router/src/services/api.rs
View File

@ -395,18 +395,6 @@ where
router_data.response = Err(error_response); router_data.response = Err(error_response);
router_data.connector_http_status_code = Some(504); router_data.connector_http_status_code = Some(504);
Ok(router_data) Ok(router_data)
} else if error.current_context().is_connection_closed() {
let error_response = ErrorResponse {
code: consts::CONNECTION_CLOSED_ERROR_CODE.to_string(),
message: consts::CONNECTION_CLOSED_ERROR_MESSAGE.to_string(),
reason: Some(
consts::CONNECTION_CLOSED_ERROR_MESSAGE.to_string(),
),
status_code: 504,
};
router_data.response = Err(error_response);
router_data.connector_http_status_code = Some(504);
Ok(router_data)
} else { } else {
Err(error.change_context( Err(error.change_context(
errors::ConnectorError::ProcessingStepFailed(None), errors::ConnectorError::ProcessingStepFailed(None),