rust/hyperswitch
1
0
Fork 0
mirror of https://github.com/juspay/hyperswitch.git synced 2025-11-03 05:17:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: add metrics to drainer (#497)

Browse Source
This commit is contained in:
Nishant Joshi
2023-02-06 13:03:53 +05:30
committed by GitHub
parent d09ed14453
commit 4a820dcd7d
7 changed files with 233 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

147
crates/drainer/src/lib.rs
View File

@ -1,6 +1,7 @@
mod connection;
pub mod env;
pub mod errors;
pub(crate) mod metrics;
pub mod services;
pub mod settings;
mod utils;
@ -19,12 +20,14 @@ pub async fn start_drainer(
max_read_count: u64,
) -> errors::DrainerResult<()> {
let mut stream_index: u8 = 0;
let mut jobs_picked: u8 = 0;
loop {
if utils::is_stream_available(stream_index, store.clone()).await {
tokio::spawn(drainer_handler(store.clone(), stream_index, max_read_count));
jobs_picked += 1;
}
stream_index = utils::increment_stream_index(stream_index, number_of_streams);
(stream_index, jobs_picked) =
utils::increment_stream_index((stream_index, jobs_picked), number_of_streams);
}
}
@ -55,9 +58,17 @@ async fn drainer(
// parse_stream_entries returns error if no entries is found, handle it
let (entries, last_entry_id) = utils::parse_stream_entries(&stream_read, stream_name)?;
let read_count = entries.len();
metrics::JOBS_PICKED_PER_STREAM.add(
&metrics::CONTEXT,
u64::try_from(read_count).unwrap_or(u64::MIN),
&[metrics::KeyValue {
key: "stream".into(),
value: stream_name.to_string().into(),
}],
);
// TODO: Handle errors when deserialization fails and when DB error occurs
for entry in entries {
let typed_sql = entry.1.get("typed_sql").map_or(String::new(), Clone::clone);
@ -72,41 +83,80 @@ async fn drainer(
let update_op = "update";
let payment_intent = "payment_intent";
let payment_attempt = "payment_attempt";
let refund = "refund";
match db_op {
// TODO: Handle errors
kv::DBOperation::Insert { insertable } => match insertable {
kv::Insertable::PaymentIntent(a) => {
macro_util::handle_resp!(a.insert(&conn).await, insert_op, payment_intent)
}
kv::Insertable::PaymentAttempt(a) => {
macro_util::handle_resp!(a.insert(&conn).await, insert_op, payment_attempt)
}
kv::Insertable::Refund(a) => {
macro_util::handle_resp!(a.insert(&conn).await, "ins", "ref")
}
},
kv::DBOperation::Update { updatable } => match updatable {
kv::Updateable::PaymentIntentUpdate(a) => {
macro_util::handle_resp!(
a.orig.update(&conn, a.update_data).await,
update_op,
payment_intent
)
}
kv::Updateable::PaymentAttemptUpdate(a) => {
macro_util::handle_resp!(
a.orig.update(&conn, a.update_data).await,
update_op,
payment_attempt
)
}
kv::Updateable::RefundUpdate(a) => {
macro_util::handle_resp!(a.orig.update(&conn, a.update_data).await, "up", "ref")
}
},
kv::DBOperation::Insert { insertable } => {
let (_, execution_time) = common_utils::date_time::time_it(|| async {
match insertable {
kv::Insertable::PaymentIntent(a) => {
macro_util::handle_resp!(
a.insert(&conn).await,
insert_op,
payment_intent
)
}
kv::Insertable::PaymentAttempt(a) => {
macro_util::handle_resp!(
a.insert(&conn).await,
insert_op,
payment_attempt
)
}
kv::Insertable::Refund(a) => {
macro_util::handle_resp!(a.insert(&conn).await, insert_op, refund)
}
}
})
.await;
metrics::QUERY_EXECUTION_TIME.record(
&metrics::CONTEXT,
execution_time,
&[metrics::KeyValue {
key: "operation".into(),
value: insert_op.into(),
}],
);
}
kv::DBOperation::Update { updatable } => {
let (_, execution_time) = common_utils::date_time::time_it(|| async {
match updatable {
kv::Updateable::PaymentIntentUpdate(a) => {
macro_util::handle_resp!(
a.orig.update(&conn, a.update_data).await,
update_op,
payment_intent
)
}
kv::Updateable::PaymentAttemptUpdate(a) => {
macro_util::handle_resp!(
a.orig.update(&conn, a.update_data).await,
update_op,
payment_attempt
)
}
kv::Updateable::RefundUpdate(a) => {
macro_util::handle_resp!(
a.orig.update(&conn, a.update_data).await,
update_op,
refund
)
}
}
})
.await;
metrics::QUERY_EXECUTION_TIME.record(
&metrics::CONTEXT,
execution_time,
&[metrics::KeyValue {
key: "operation".into(),
value: update_op.into(),
}],
);
}
kv::DBOperation::Delete => {
// TODO: Implement this
println!("Not implemented!");
// [#224]: Implement this
logger::error!("Not implemented!");
}
};
}
@ -115,7 +165,12 @@ async fn drainer(
utils::trim_from_stream(stream_name, last_entry_id.as_str(), &store.redis_conn).await?;
if read_count != entries_trimmed {
// TODO: log
logger::error!(
read_entries = %read_count,
trimmed_entries = %entries_trimmed,
?entries,
"Assertion Failed no. of entries read from the stream doesn't match no. of entries trimmed"
);
}
Ok(())
@ -126,8 +181,24 @@ mod macro_util {
macro_rules! handle_resp {
($result:expr,$op_type:expr, $table:expr) => {
match $result {
Ok(aa) => logger::info!("Ok|{}|{}|{:?}|", $op_type, $table, aa),
Err(err) => logger::error!("Err|{}|{}|{:?}|", $op_type, $table, err),
Ok(inner_result) => {
logger::info!(operation = %$op_type, table = %$table, ?inner_result);
metrics::SUCCESSFUL_QUERY_EXECUTION.add(&metrics::CONTEXT, 1, &[
metrics::KeyValue {
key: "operation".into(),
value: $table.into(),
}
]);
}
Err(err) => {
logger::error!(operation = %$op_type, table = %$table, ?err);
metrics::ERRORS_WHILE_QUERY_EXECUTION.add(&metrics::CONTEXT, 1, &[
metrics::KeyValue {
key: "operation".into(),
value: $table.into(),
}
]);
}
}
};
}