chore: remove Connectors enum dependency from ConnectorIntegrationV2 trait (#5840)

This commit is contained in:
Hrithikesh
2024-09-11 13:20:43 +05:30
committed by GitHub
parent be346e5d96
commit 296ca311c9
2 changed files with 2 additions and 7 deletions

View File

@ -9,8 +9,7 @@ use router_env::metrics::add_attributes;
use serde_json::json; use serde_json::json;
use crate::{ use crate::{
api::CaptureSyncMethod, configs::Connectors, errors, api::CaptureSyncMethod, errors, events::connector_api_logs::ConnectorEvent, metrics, types,
events::connector_api_logs::ConnectorEvent, metrics, types,
}; };
/// alias for Box of a type that implements trait ConnectorIntegrationV2 /// alias for Box of a type that implements trait ConnectorIntegrationV2
@ -47,7 +46,6 @@ pub trait ConnectorIntegrationV2<Flow, ResourceCommonData, Req, Resp>:
fn get_headers( fn get_headers(
&self, &self,
_req: &RouterDataV2<Flow, ResourceCommonData, Req, Resp>, _req: &RouterDataV2<Flow, ResourceCommonData, Req, Resp>,
_connectors: &Connectors,
) -> CustomResult<Vec<(String, Maskable<String>)>, errors::ConnectorError> { ) -> CustomResult<Vec<(String, Maskable<String>)>, errors::ConnectorError> {
Ok(vec![]) Ok(vec![])
} }
@ -66,7 +64,6 @@ pub trait ConnectorIntegrationV2<Flow, ResourceCommonData, Req, Resp>:
fn get_url( fn get_url(
&self, &self,
_req: &RouterDataV2<Flow, ResourceCommonData, Req, Resp>, _req: &RouterDataV2<Flow, ResourceCommonData, Req, Resp>,
_connectors: &Connectors,
) -> CustomResult<String, errors::ConnectorError> { ) -> CustomResult<String, errors::ConnectorError> {
Ok(String::new()) Ok(String::new())
} }
@ -75,7 +72,6 @@ pub trait ConnectorIntegrationV2<Flow, ResourceCommonData, Req, Resp>:
fn get_request_body( fn get_request_body(
&self, &self,
_req: &RouterDataV2<Flow, ResourceCommonData, Req, Resp>, _req: &RouterDataV2<Flow, ResourceCommonData, Req, Resp>,
_connectors: &Connectors,
) -> CustomResult<RequestContent, errors::ConnectorError> { ) -> CustomResult<RequestContent, errors::ConnectorError> {
Ok(RequestContent::Json(Box::new(json!(r#"{}"#)))) Ok(RequestContent::Json(Box::new(json!(r#"{}"#))))
} }
@ -92,7 +88,6 @@ pub trait ConnectorIntegrationV2<Flow, ResourceCommonData, Req, Resp>:
fn build_request_v2( fn build_request_v2(
&self, &self,
_req: &RouterDataV2<Flow, ResourceCommonData, Req, Resp>, _req: &RouterDataV2<Flow, ResourceCommonData, Req, Resp>,
_connectors: &Connectors,
) -> CustomResult<Option<Request>, errors::ConnectorError> { ) -> CustomResult<Option<Request>, errors::ConnectorError> {
metrics::UNIMPLEMENTED_FLOW.add( metrics::UNIMPLEMENTED_FLOW.add(
&metrics::CONTEXT, &metrics::CONTEXT,

View File

@ -570,7 +570,7 @@ where
} }
ConnectorIntegrationEnum::New(new_integration) => { ConnectorIntegrationEnum::New(new_integration) => {
let new_router_data = ResourceCommonData::from_old_router_data(req)?; let new_router_data = ResourceCommonData::from_old_router_data(req)?;
new_integration.build_request_v2(&new_router_data, connectors) new_integration.build_request_v2(&new_router_data)
} }
} }
} }