rust/hyperswitch
1
0
Fork 0
mirror of https://github.com/juspay/hyperswitch.git synced 2025-11-01 19:42:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(cards,router): Remove duplicated card number interface (#4404)

Browse Source 
Co-authored-by: Sanchith Hegde <22217505+SanchithHegde@users.noreply.github.com>
This commit is contained in:
YongJoon Kim
2024-05-16 22:20:40 +09:00
committed by GitHub
parent 0fdbd7ef25
commit 27ae437a88
3 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
crates/api_models/src/payment_methods.rs
View File

@ -361,7 +361,7 @@ impl From<CardDetailFromLocker> for payments::AdditionalCardInfo {
card_isin: item.card_isin, card_isin: item.card_isin,
card_extended_bin: item card_extended_bin: item
.card_number .card_number
.map(|card_number| card_number.get_card_extended_bin()), .map(|card_number| card_number.get_extended_card_bin()),
card_exp_month: item.expiry_month, card_exp_month: item.expiry_month,
card_exp_year: item.expiry_year, card_exp_year: item.expiry_year,
card_holder_name: item.card_holder_name, card_holder_name: item.card_holder_name,

4
crates/cards/src/validate.rs
View File

@ -24,7 +24,6 @@ impl CardNumber {
pub fn get_card_isin(self) -> String { pub fn get_card_isin(self) -> String {
self.0.peek().chars().take(6).collect::<String>() self.0.peek().chars().take(6).collect::<String>()
} }
pub fn get_extended_card_bin(self) -> String { pub fn get_extended_card_bin(self) -> String {
self.0.peek().chars().take(8).collect::<String>() self.0.peek().chars().take(8).collect::<String>()
} }
@ -42,9 +41,6 @@ impl CardNumber {
.rev() .rev()
.collect::<String>() .collect::<String>()
} }
pub fn get_card_extended_bin(self) -> String {
self.0.peek().chars().take(8).collect::<String>()
}
} }
impl FromStr for CardNumber { impl FromStr for CardNumber {

2
crates/router/src/core/payments/helpers.rs
View File

@ -3719,7 +3719,7 @@ pub async fn get_additional_payment_data(
let card_extended_bin = match enable_extended_bin { let card_extended_bin = match enable_extended_bin {
Some(config) if config.config == "true" => { Some(config) if config.config == "true" => {
Some(card_data.card_number.clone().get_card_extended_bin()) Some(card_data.card_number.clone().get_extended_card_bin())
} }
_ => None, _ => None,
}; };