chore: address Rust 1.86.0 clippy lints (#7735)

crates/router/src/connector/netcetera/netcetera_types.rs

@@ -1113,8 +1113,8 @@ pub struct MerchantRiskIndicator {
     /// New field introduced:
     /// - transChar -> Indicates to the ACS specific transactions identified by the Merchant.
     ///      - Size: Variable, 1-2 elements. JSON Data Type: Array of String. Accepted values:
-    ///                     - 01 -> Cryptocurrency transaction
-    ///                     - 02 -> NFT transaction
+    ///          - 01 -> Cryptocurrency transaction
+    ///          - 02 -> NFT transaction
     trans_char: Option<String>,
 }
 
@@ -1558,19 +1558,19 @@ pub struct Sdk {
     ///    Creates a JSON object of the following data as the JWS payload to be signed:
     ///
     ///    - SDK Reference Number -> Identifies the vendor and version of the 3DS SDK that is utilised for a specific
-    ///                              transaction. The value is assigned by EMVCo when the Letter of Approval of the
-    ///                              specific 3DS SDK is issued. The field is limited to 32 characters.
+    ///      transaction. The value is assigned by EMVCo when the Letter of Approval of the
+    ///      specific 3DS SDK is issued. The field is limited to 32 characters.
     ///    - SDK Signature Timestamp -> Date and time indicating when the 3DS SDK generated the Split-SDK Server Signed
-    ///                                 Content converted into UTC. The value is limited to 14 characters. Accepted
-    ///                                 format: YYYYMMDDHHMMSS.
+    ///      Content converted into UTC. The value is limited to 14 characters. Accepted
+    ///      format: YYYYMMDDHHMMSS.
     ///    - SDK Transaction ID -> Universally unique transaction identifier assigned by the 3DS SDK to identify a
-    ///                            single transaction. The field is limited to 36 characters and it shall be in a
-    ///                            canonical format as defined in IETF RFC 4122. This may utilize any of the specified
-    ///                            versions as long as the output meets specific requirements.
+    ///      single transaction. The field is limited to 36 characters and it shall be in a
+    ///      canonical format as defined in IETF RFC 4122. This may utilize any of the specified
+    ///      versions as long as the output meets specific requirements.
     ///    - Split-SDK Server ID -> DS assigned Split-SDK Server identifier. Each DS can provide a unique ID to each
-    ///                             Split-SDK Server on an individual basis. The field is limited to 32 characters.
-    ///                             Any individual DS may impose specific formatting and character requirements on the
-    ///                             contents of this field.
+    ///      Split-SDK Server on an individual basis. The field is limited to 32 characters.
+    ///      Any individual DS may impose specific formatting and character requirements on the
+    ///      contents of this field.
     ///
     ///    Generates a digital signature of the full JSON object according to JWS (RFC 7515) using JWS Compact
     ///    Serialization. The parameter values for this version of the specification and to be included in the JWS
@@ -1705,7 +1705,7 @@ pub struct SplitSdkType {
     /// Limited Split-SDK Indicator: If the Split-SDK client has limited capabilities
     ///    - Length: 1 character
     ///    - Value accepted:
-    ///       • Y = Limited
+    ///      • Y = Limited
     ///    - Only present if value = Y
     limited_ind: Option<String>,
 }

crates/router/src/connector/netcetera/transformers.rs

@@ -700,9 +700,9 @@ pub struct ResultsResponseData {
     /// - `U`: Authentication / Account verification could not be performed; technical or other problem.
     /// - `C`: A challenge is required to complete the authentication.
     /// - `R`: Authentication / Account verification Rejected. Issuer is rejecting authentication/verification
-    ///       and request that authorization not be attempted.
+    ///   and request that authorization not be attempted.
     /// - `A`: Attempts processing performed; Not authenticated / verified, but a proof of attempt
-    ///       authentication / verification is provided.
+    ///   authentication / verification is provided.
     /// - `D`: A challenge is required to complete the authentication. Decoupled Authentication confirmed.
     /// - `I`: Informational Only; 3DS Requestor challenge preference acknowledged.
     pub trans_status: Option<common_enums::TransactionStatus>,

crates/router/src/core/errors/utils.rs

@@ -178,7 +178,7 @@ impl<T> ConnectorErrorExt<T> for error_stack::Result<T, errors::ConnectorError>
             | errors::ConnectorError::RequestTimeoutReceived
             | errors::ConnectorError::CurrencyNotSupported { .. }
             | errors::ConnectorError::InvalidConnectorConfig { .. }
-            | errors::ConnectorError::AmountConversionFailed { .. }
+            | errors::ConnectorError::AmountConversionFailed
             | errors::ConnectorError::GenericError { .. } => {
                 err.change_context(errors::ApiErrorResponse::RefundFailed { data: None })
             }
@@ -369,7 +369,7 @@ impl<T> ConnectorErrorExt<T> for error_stack::Result<T, errors::ConnectorError>
                 | errors::ConnectorError::RequestTimeoutReceived
                 | errors::ConnectorError::CurrencyNotSupported { .. }
                 | errors::ConnectorError::ProcessingStepFailed(None)
-                | errors::ConnectorError::AmountConversionFailed { .. }
+                | errors::ConnectorError::AmountConversionFailed
                 | errors::ConnectorError::GenericError { .. } => {
                     logger::error!(%error,"Setup Mandate flow failed");
                     errors::ApiErrorResponse::PaymentAuthorizationFailed { data: None }

crates/router/src/events/audit_events.rs

@@ -78,9 +78,9 @@ impl Event for AuditEvent {
             AuditEventType::RefundFail => "refund_fail",
             AuditEventType::PaymentCancelled { .. } => "payment_cancelled",
             AuditEventType::PaymentUpdate { .. } => "payment_update",
-            AuditEventType::PaymentApprove { .. } => "payment_approve",
-            AuditEventType::PaymentCreate { .. } => "payment_create",
-            AuditEventType::PaymentStatus { .. } => "payment_status",
+            AuditEventType::PaymentApprove => "payment_approve",
+            AuditEventType::PaymentCreate => "payment_create",
+            AuditEventType::PaymentStatus => "payment_status",
             AuditEventType::PaymentCompleteAuthorize => "payment_complete_authorize",
             AuditEventType::PaymentReject { .. } => "payment_rejected",
         };

crates/router/tests/connectors/cashtocode.rs

@@ -68,7 +68,7 @@ impl CashtocodeTest {
             router_return_url: Some(String::from("https://google.com")),
             webhook_url: None,
             complete_authorize_url: None,
-            customer_id: if let Ok(id) = cust_id { Some(id) } else { None },
+            customer_id: cust_id.ok(),
             surcharge_details: None,
             request_incremental_authorization: false,
             metadata: None,