rust/hyperswitch
1
0
Fork 0
mirror of https://github.com/juspay/hyperswitch.git synced 2025-11-01 11:06:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove error propagation if card name not found in locker (#2998)

Browse Source
This commit is contained in:
Chethan Rao
2023-11-28 20:09:50 +05:30
committed by GitHub
parent cdbb3853cd
commit 1c5a9b5452
1 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
crates/router/src/core/payments/helpers.rs
View File

@ -1459,26 +1459,23 @@ pub async fn retrieve_card_with_permanent_token(
.change_context(errors::ApiErrorResponse::InternalServerError) .change_context(errors::ApiErrorResponse::InternalServerError)
.attach_printable("failed to fetch card information from the permanent locker")?; .attach_printable("failed to fetch card information from the permanent locker")?;
let name = card let name_on_card = if let Some(name_on_card) = card.name_on_card.clone() {
.name_on_card if card.name_on_card.unwrap_or_default().expose().is_empty() {
.get_required_value("name_on_card")
.change_context(errors::ApiErrorResponse::InternalServerError)
.attach_printable("card holder name was not saved in permanent locker")?;
let name_on_card = if name.clone().expose().is_empty() {
card_token_data card_token_data
.and_then(|token_data| token_data.card_holder_name.clone()) .and_then(|token_data| token_data.card_holder_name.clone())
.filter(|name_on_card| !name_on_card.clone().expose().is_empty()) .filter(|name_on_card| !name_on_card.clone().expose().is_empty())
.ok_or(errors::ApiErrorResponse::MissingRequiredField {
field_name: "card_holder_name",
})?
} else { } else {
name Some(name_on_card)
}
} else {
card_token_data
.and_then(|token_data| token_data.card_holder_name.clone())
.filter(|name_on_card| !name_on_card.clone().expose().is_empty())
}; };
let api_card = api::Card { let api_card = api::Card {
card_number: card.card_number, card_number: card.card_number,
card_holder_name: name_on_card, card_holder_name: name_on_card.unwrap_or(masking::Secret::from("".to_string())),
card_exp_month: card.card_exp_month, card_exp_month: card.card_exp_month,
card_exp_year: card.card_exp_year, card_exp_year: card.card_exp_year,
card_cvc: card_cvc.unwrap_or_default(), card_cvc: card_cvc.unwrap_or_default(),