python/mysqlclient
1
0
Fork 0
mirror of https://github.com/PyMySQL/mysqlclient.git synced 2025-08-15 11:10:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add Context Manager Interface to Connection. (#413)

Browse Source 
Fixes #400.
This commit is contained in:
Inada Naoki
2019-11-29 21:15:17 +09:00
committed by GitHub
parent 8fd628ef0f
commit 643220972e
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
MySQLdb/connections.py
View File

@ -207,6 +207,12 @@ class Connection(_mysql.connection):
self.autocommit(autocommit) self.autocommit(autocommit)
self.messages = [] self.messages = []
def __enter__(self):
return self
def __exit__(self, exc_type, exc_value, traceback):
self.close()
def autocommit(self, on): def autocommit(self, on):
on = bool(on) on = bool(on)
if self.get_autocommit() != on: if self.get_autocommit() != on:

5
tests/test_MySQLdb_nonstandard.py
View File

@ -99,3 +99,8 @@ class CoreAPI(unittest.TestCase):
def test_fileno(self): def test_fileno(self):
self.assertGreaterEqual(self.conn.fileno(), 0) self.assertGreaterEqual(self.conn.fileno(), 0)
def test_context_manager(self):
with connection_factory() as conn:
self.assertFalse(conn.closed)
self.assertTrue(conn.closed)