python/mysqlclient
1
0
Fork 0
mirror of https://github.com/PyMySQL/mysqlclient.git synced 2025-08-16 03:50:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix a memory leak if the connect fails

Browse Source
This commit is contained in:
adustman
2002-03-01 22:27:12 +00:00
parent 04ac4fd874
commit 21a41c915c
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
MySQLdb/_mysql.c
View File

@ -239,6 +239,8 @@ _mysql_connect(
c = PyObject_NEW(_mysql_ConnectionObject, c = PyObject_NEW(_mysql_ConnectionObject,
&_mysql_ConnectionObject_Type); &_mysql_ConnectionObject_Type);
if (c == NULL) return NULL; if (c == NULL) return NULL;
c->converter = NULL;
c->open = 0;
if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|ssssisOiiisss:connect", if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|ssssisOiiisss:connect",
kwlist, kwlist,
&host, &user, &passwd, &db, &host, &user, &passwd, &db,
@ -246,8 +248,10 @@ _mysql_connect(
&connect_timeout, &connect_timeout,
&compress, &named_pipe, &compress, &named_pipe,
&init_command, &read_default_file, &init_command, &read_default_file,
&read_default_group)) &read_default_group)) {
Py_DECREF(c);
return NULL; return NULL;
}
if (!conv) if (!conv)
conv = PyDict_New(); conv = PyDict_New();
@ -287,7 +291,6 @@ _mysql_connect(
if (!conn) { if (!conn) {
_mysql_Exception(c); _mysql_Exception(c);
c->open = 0;
Py_DECREF(c); Py_DECREF(c);
return NULL; return NULL;
} }