python/mysqlclient
1
0
Fork 0
mirror of https://github.com/PyMySQL/mysqlclient.git synced 2025-08-16 03:50:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

deprecate Connection.__enter__

Browse Source
This commit is contained in:
INADA Naoki
2017-02-20 16:47:56 +09:00
committed by INADA Naoki
parent d587e81a7f
commit 118861f8cb
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
MySQLdb/connections.py
View File

@ -265,12 +265,10 @@ class Connection(_mysql.connection):
def cursor(self, cursorclass=None): def cursor(self, cursorclass=None):
""" """
Create a cursor on which queries may be performed. The Create a cursor on which queries may be performed. The
optional cursorclass parameter is used to create the optional cursorclass parameter is used to create the
Cursor. By default, self.cursorclass=cursors.Cursor is Cursor. By default, self.cursorclass=cursors.Cursor is
used. used.
""" """
return (cursorclass or self.cursorclass)(self) return (cursorclass or self.cursorclass)(self)
@ -286,6 +284,9 @@ class Connection(_mysql.connection):
_mysql.connection.query(self, query) _mysql.connection.query(self, query)
def __enter__(self): def __enter__(self):
from warnings import warn
warn("context interface will be changed. Use explicit conn.commit() or conn.rollback().",
DeprecationWarning, 2)
if self.get_autocommit(): if self.get_autocommit():
self.query("BEGIN") self.query("BEGIN")
return self.cursor() return self.cursor()
@ -319,7 +320,7 @@ class Connection(_mysql.connection):
DEPRECATED: Will be removed in 1.3. DEPRECATED: Will be removed in 1.3.
Use an SQL BEGIN statement instead.""" Use an SQL BEGIN statement instead."""
from warnings import warn from warnings import warn
warn("begin() is non-standard and will be removed in 1.3", warn("begin() is non-standard and will be removed in 1.4",
DeprecationWarning, 2) DeprecationWarning, 2)
self.query("BEGIN") self.query("BEGIN")
@ -386,3 +387,5 @@ class Connection(_mysql.connection):
NotSupportedError = NotSupportedError NotSupportedError = NotSupportedError
errorhandler = defaulterrorhandler errorhandler = defaulterrorhandler
# vim: colorcolumn=100