python/fastapi-users
1
0
Fork 0
mirror of https://github.com/fastapi-users/fastapi-users.git synced 2025-11-04 06:37:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Ensure columns in SQL schema are not nullable

Browse Source
This commit is contained in:
François Voron
2019-10-11 13:08:03 +02:00
parent 76bb7bf6a5
commit f3b7fa662a
2 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
fastapi_users/db/sqlalchemy.py
View File

@ -13,10 +13,10 @@ class SQLAlchemyBaseUserTable:
__tablename__ = "user" __tablename__ = "user"
id = Column(String, primary_key=True) id = Column(String, primary_key=True)
email = Column(String, unique=True, index=True) email = Column(String, unique=True, index=True, nullable=False)
hashed_password = Column(String) hashed_password = Column(String, nullable=False)
is_active = Column(Boolean, default=True) is_active = Column(Boolean, default=True, nullable=False)
is_superuser = Column(Boolean, default=False) is_superuser = Column(Boolean, default=False, nullable=False)
class SQLAlchemyUserDatabase(BaseUserDatabase): class SQLAlchemyUserDatabase(BaseUserDatabase):

8
tests/test_db_sqlalchemy.py
View File

@ -71,6 +71,14 @@ async def test_queries(sqlalchemy_user_db):
with pytest.raises(sqlite3.IntegrityError): with pytest.raises(sqlite3.IntegrityError):
await sqlalchemy_user_db.create(user) await sqlalchemy_user_db.create(user)
# Exception when inserting non-nullable fields
with pytest.raises(sqlite3.IntegrityError):
wrong_user = BaseUserDB(
id="222",
hashed_password="aaa"
)
await sqlalchemy_user_db.create(wrong_user)
# Unknown user # Unknown user
unknown_user = await sqlalchemy_user_db.get_by_email("galahad@camelot.bt") unknown_user = await sqlalchemy_user_db.get_by_email("galahad@camelot.bt")
assert unknown_user is None assert unknown_user is None