python/fastapi-users
1
0
Fork 0
mirror of https://github.com/fastapi-users/fastapi-users.git synced 2025-08-17 13:54:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix #18: check for existing user on registration

Browse Source
This commit is contained in:
François Voron
2019-10-19 18:31:08 +02:00
parent a5618399a1
commit a4171f8bea
3 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
docs/usage/routes.md
View File

@ -26,6 +26,9 @@ Register a new user.
!!! fail "`422 Validation Error`" !!! fail "`422 Validation Error`"
!!! fail "`400 Bad Request`"
A user already exists with this email.
## `POST /login` ## `POST /login`
Login a user. Login a user.

5
fastapi_users/router.py
View File

@ -34,6 +34,11 @@ def get_user_router(
@router.post("/register", response_model=models.User) @router.post("/register", response_model=models.User)
async def register(user: models.UserCreate): # type: ignore async def register(user: models.UserCreate): # type: ignore
existing_user = await user_db.get_by_email(user.email)
if existing_user is not None:
raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST)
hashed_password = get_password_hash(user.password) hashed_password = get_password_hash(user.password)
db_user = models.UserDB(**user.dict(), hashed_password=hashed_password) db_user = models.UserDB(**user.dict(), hashed_password=hashed_password)
created_user = await user_db.create(db_user) created_user = await user_db.create(db_user)

7
tests/test_router.py
View File

@ -76,9 +76,14 @@ class TestRegister:
response = test_app_client.post("/register", json=json) response = test_app_client.post("/register", json=json)
assert response.status_code == status.HTTP_422_UNPROCESSABLE_ENTITY assert response.status_code == status.HTTP_422_UNPROCESSABLE_ENTITY
def test_valid_body(self, test_app_client: TestClient): def test_existing_user(self, test_app_client: TestClient):
json = {"email": "king.arthur@camelot.bt", "password": "guinevere"} json = {"email": "king.arthur@camelot.bt", "password": "guinevere"}
response = test_app_client.post("/register", json=json) response = test_app_client.post("/register", json=json)
assert response.status_code == status.HTTP_400_BAD_REQUEST
def test_valid_body(self, test_app_client: TestClient):
json = {"email": "lancelot@camelot.bt", "password": "guinevere"}
response = test_app_client.post("/register", json=json)
assert response.status_code == status.HTTP_200_OK assert response.status_code == status.HTTP_200_OK
response_json = response.json() response_json = response.json()