From 70d2a7a5299ffcf04e9f33b394eee55654c9afee Mon Sep 17 00:00:00 2001 From: long2ice Date: Fri, 4 Jun 2021 17:54:02 +0800 Subject: [PATCH] Use `str` type for `pk` path param. (#52) --- CHANGELOG.md | 4 ++++ fastapi_admin/routes/resources.py | 6 +++--- pyproject.toml | 2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bee5056..04ecf40 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## 1.0 +### 1.0.2 + +- Use `str` type for `pk` path param. (#52) + ### 1.0.1 - Add `column_attributes`. diff --git a/fastapi_admin/routes/resources.py b/fastapi_admin/routes/resources.py index 509d431..97ec1ef 100644 --- a/fastapi_admin/routes/resources.py +++ b/fastapi_admin/routes/resources.py @@ -79,7 +79,7 @@ async def list_view( async def update( request: Request, resource: str = Path(...), - pk: int = Path(...), + pk: str = Path(...), model_resource: ModelResource = Depends(get_model_resource), resources=Depends(get_resources), model=Depends(get_model), @@ -136,7 +136,7 @@ async def update( async def update_view( request: Request, resource: str = Path(...), - pk: int = Path(...), + pk: str = Path(...), model_resource: ModelResource = Depends(get_model_resource), resources=Depends(get_resources), model=Depends(get_model), @@ -237,7 +237,7 @@ async def create( @router.delete("/{resource}/delete/{pk}") -async def delete(request: Request, pk: int, model: Model = Depends(get_model)): +async def delete(request: Request, pk: str, model: Model = Depends(get_model)): await model.filter(pk=pk).delete() return RedirectResponse(url=request.headers.get("referer"), status_code=HTTP_303_SEE_OTHER) diff --git a/pyproject.toml b/pyproject.toml index 79b77df..1fd4350 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -18,7 +18,7 @@ packages = [ ] readme = "README.md" repository = "https://github.com/fastapi-admin/fastapi-admin.git" -version = "1.0.1" +version = "1.0.2" [tool.poetry.dependencies] Babel = "*"