pre-commit/pre-commit-hooks
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit-hooks.git synced 2025-08-14 17:31:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make optional argument use an immutable set for the default value

Browse Source 
in no-commit-to-branch. Make other sets immutable to satisfy type-checking
and be consistent
This commit is contained in:
Marc Jay
2019-04-20 23:07:14 +01:00
parent 6568414fc5
commit a7af812449
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pre_commit_hooks/no_commit_to_branch.py
View File

@ -2,16 +2,16 @@ from __future__ import print_function
import argparse
import re
from typing import FrozenSet
from typing import Optional
from typing import Sequence
from typing import Set
from pre_commit_hooks.util import CalledProcessError
from pre_commit_hooks.util import cmd_output
def is_on_branch(protected, patterns=set()):
# type: (Set[str], Set[str]) -> bool
def is_on_branch(protected, patterns=frozenset()):
# type: (FrozenSet[str], FrozenSet[str]) -> bool
try:
ref_name = cmd_output('git', 'symbolic-ref', 'HEAD')
except CalledProcessError:
@ -33,13 +33,13 @@ def main(argv=None): # type: (Optional[Sequence[str]]) -> int
'-p', '--pattern', action='append',
help=(
'regex pattern for branch name to disallow commits to, '
'May be specified multiple times'
'may be specified multiple times'
),
)
args = parser.parse_args(argv)
protected = set(args.branch or ('master',))
patterns = set(args.pattern or ())
protected = frozenset(args.branch or ('master',))
patterns = frozenset(args.pattern or ())
return int(is_on_branch(protected, patterns))