pre-commit/pre-commit-hooks
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit-hooks.git synced 2025-08-15 01:54:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

Check Git core.fileMode rather than infer from OS.

Browse Source 
There was already a guard preventing the check-executables-have-shebangs
hook from raising false positives on win32 by looking up the Git file
mode rather than relying on the file mode in the file system. Git already
automatically probes the file system for executable bit support. Leverage
Git's core.fileMode config variable to prevent false positives on all
file systems that don't track executable bits.
This commit is contained in:
Kurt von Laven
2022-02-18 23:51:58 -08:00
parent f5c26753e4
commit 2cbabf90cc
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pre_commit_hooks/check_executables_have_shebangs.py
View File

@ -15,7 +15,10 @@ EXECUTABLE_VALUES = frozenset(('1', '3', '5', '7'))
def check_executables(paths: list[str]) -> int: def check_executables(paths: list[str]) -> int:
if sys.platform == 'win32': # pragma: win32 cover fs_tracks_executable_bit = cmd_output(
'git', 'config', 'core.fileMode', retcode=None,
).strip()
if fs_tracks_executable_bit == 'false': # pragma: win32 cover
return _check_git_filemode(paths) return _check_git_filemode(paths)
else: # pragma: win32 no cover else: # pragma: win32 no cover
retv = 0 retv = 0