php/yii2
1
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2025-11-21 17:20:57 +08:00
Code Issues Packages Projects Releases Wiki Activity
9,307 Commits 10 Branches 79 Tags
8d082c11a1c502487b200842927e1a5733abbc7d
Commit Graph

59 Commits

Author SHA1 Message Date
Yuan Chong
baee44c97b OAuth API Response with 20x status should be in normal 
Hello,

I used **Yii2 authclient** to build a Github OAuth (2.0) client, and performed a POST call to create a Github repository hook. But I got this exception:

```
exception 'yii\authclient\InvalidResponseException' with message '
Request failed with code: 201, message:
{
	"url": "https://api.github.com/repos/ychongsaytc/example/hooks/1000000",
	"test_url": "https://api.github.com/repos/ychongsaytc/example/hooks/1000000/test",
	"id": 1000000,
	"name": "web",
	"active": true,
	"events": ["push"],
	"config": {
		"url": "https://example.com/payload",
		"content_type": "form",
		"secret": null
	},
	"last_response": {
		"code": null,
		"status": "unused",
		"message": null
	},
	"updated_at": "2014-09-14T03:02:55Z",
	"created_at": "2014-09-14T03:02:55Z"
}
' in /home/ubuntu/public_html/live/vendor/yiisoft/yii2-authclient/BaseOAuth.php:206
```

I think a successful API call is not always exactly return **200** status, like **Create a hook** API of Github: https://developer.github.com/v3/repos/hooks/

It will return `201 Created` if hook was successfully created.

In my opinion, is status code starts with **20** in normal scenario?

close #5011
 2014-09-14 12:59:11 +02:00
dima
97b4c505ad fix authchoice.js 2014-09-10 20:36:35 +03:00
Alexander Makarov
9885aac0ae Removed unused "use" statements 2014-09-07 15:56:06 +04:00
Qiang Xue
5a1cf0f3a5 Adjusted the location of AuthChoice assets. [skip ci] 2014-08-29 11:33:47 -04:00
Carsten Brandt
7736853837 property code style extensions 2014-07-30 00:40:46 +02:00
Alexander Makarov
100ba6c3ab Replaced substr_compare with strncmp where possible 2014-07-30 02:32:47 +04:00
Carsten Brandt
1f31f27787 phpdoc 2014-07-29 22:19:14 +02:00
Klimov Paul
fedf8eccd9 yii\authclient\widgets\AuthChoice now preserves initial settings while opening popup 2014-07-28 17:56:03 +03:00
Alexander Makarov
07f01bcf2b Used substr_compare instead of substr when we don't care about result 2014-07-23 16:37:49 +04:00
Klimov Paul
c9dff5305e Redundant yii\authclient\OpenId::sendStreamRequest() removed. 2014-07-16 16:42:15 +03:00
Klimov Paul
78daea1bfb OAuth extension adjusted to support any custom request type. 2014-07-16 16:37:50 +03:00
Klimov Paul
9757029191 yii\authclient\InvalidResponseException added 2014-07-11 14:38:20 +03:00
Klimov Paul
a1a9d9a3bc Method yii\authclient\BaseOAuth::mergeCurlOptions() advanced to merge array values 2014-07-11 12:30:30 +03:00
Klimov Paul
fbce722d85 Request HTTP headers argument added to yii\authclient\BaseOAuth::api() method 2014-07-11 12:27:33 +03:00
Klimov Paul
fe46caf74c User attributes fetching at VKontakte adjusted 2014-07-11 11:19:17 +03:00
Klimov Paul
3943641077 User attributes requesting at GoogleOAuth switched to Google+ API 2014-07-11 10:49:41 +03:00
Arthur Khachaturov
dbf10f1848 Missing semicolon 2014-07-02 16:30:26 +04:00
Carsten Brandt
6578cfbdab updated phpdoc and classmap 2014-06-25 18:24:23 +02:00
Alexander Makarov
0c14f47f9a Fixes #3793: Changed inline autocomplete hints style to get more IDEs support 2014-06-20 17:40:00 +04:00
Klimov Paul
243f0134c9 OpenId return URL comparison advanced to prevent url encode problem 2014-05-30 12:55:28 +03:00
Klimov Paul
984bb9874f list of predefined Auth clients updated 2014-05-28 11:11:20 +03:00
Carsten Brandt
d75f0c7288 removed @link tags from apidoc and replaced with markdown 2014-05-25 22:29:31 +02:00
Carsten Brandt
b7e493fca0 Tabs to spaces to be consistent 
```
vendor/bin/indent --spaces -r framework/
vendor/bin/indent --tabs -r . --pattern=*.json
vendor/bin/indent --spaces -r . --pattern=*.md
vendor/bin/indent --spaces -r . --pattern=yii.*.js
vendor/bin/indent --spaces -r . --pattern=*.css
```
 2014-05-23 16:58:21 +02:00
Paul Klimov
47960e8f0b Fix a typo 2014-05-09 15:35:14 +03:00
Paul Klimov
aa34d3121d VKontakte OAuth support added 2014-05-09 13:39:54 +03:00
Carsten Brandt
c27ac8ef0e updated phpdoc 2014-04-26 03:39:46 +02:00
Carsten Brandt
fe14f0c5e3 fixed all the PHPdoc in extensions 2014-04-23 03:25:11 +02:00
Alexander Makarov
c7c708d454 Removed unused imports 2014-04-17 15:35:09 +04:00
Qiang Xue
f4c38faf74 prepare for next release. 2014-04-13 21:22:29 -04:00
Qiang Xue
8bbcff70db prepare for 2.0.0-beta release. 2014-04-13 17:58:59 -04:00
Qiang Xue
0b29c9607d fixed broken API links [skip ci] 2014-04-09 22:22:49 -04:00
Carsten Brandt
3fdcf11f24 updated phpdoc 2014-04-09 18:51:45 +02:00
Klimov Paul
e3f4214978 Tabs replaced by spaces at AuthChoice asset files. 2014-04-07 16:29:00 +03:00
Klimov Paul
4f0089bb0d Microsoft Live OAuth2 client added. 2014-04-07 16:22:00 +03:00
Klimov Paul
7f0ab92d8e Widget 'yii\authclient\widgets\Choice' renamed to 'yii\authclient\widgets\AuthChoice' 2014-04-07 15:38:16 +03:00
Alexander Makarov
0d3e85caff Merge pull request #2883 from kartik-v/patch-14 
Simplify inline script code
 2014-03-26 14:28:20 +03:00
Kartik Visweswaran
cd4038bfa8 Simplify inline script code 
Simplify inline script code (removed extra space)
 2014-03-26 16:32:06 +05:30
Kartik Visweswaran
14137a123e Correct classname typo 
Correct classname to `BaseOAuth` instead of `BaseClient` in PHP Doc.
 2014-03-26 16:26:52 +05:30
Kartik Visweswaran
dd4ddfe06c Simplify inline script code 
Simplify the rendering of the inline script (using direct markup), eliminating need for using PHP variable to store value using HEREDOC.
 2014-03-26 16:24:29 +05:30
Carsten Brandt
1e75427393 updated classmap and phpdoc 2014-03-24 23:26:30 +01:00
Qiang Xue
8c2e39235f Turn module and application into DI containers. 2014-03-17 23:57:01 -04:00
SonicGD
b5f8a4dc22 Reformat code te be PSR-2 compatible 2014-03-16 10:46:21 +06:00
Carsten Brandt
6fff5662df better use @see for See in phpdoc 2014-03-11 05:38:35 +01:00
Carsten Brandt
c94a40e90d added a large amount of missing documentation 2014-03-11 05:38:35 +01:00
Alexander Makarov
5d6c314d4e Adjusted URL helper, fixed usage 2014-03-10 15:25:15 +04:00
Alexander Makarov
92b381795b Adjusted Url helper methods 2014-03-10 01:34:05 +04:00
Alexander Makarov
3400eb5215 #2630: yii\heplers\Html::url moved to new yii\helpers\Url::create 2014-03-09 16:41:55 +04:00
Luciano Baraglia
269d1303a9 Code style fixes 2014-03-08 20:47:04 -03:00
AlexGx
c906d43343 fix php5.4 array syntax 2014-03-05 00:26:40 +02:00
AlexGx
1982efbdfe many phpcs fixes 2014-03-05 00:22:55 +02:00