Commit Graph

4065 Commits

Author SHA1 Message Date
armab
a324b26c7f BaseMailer: strip <style> content from TextBody fix
If ```$htmlLayout``` contains <style> tags with CSS rules,
strip_tags here: https://github.com/yiisoft/yii2/blob/master/framework/mail/BaseMailer.php#L189
won't clean those CSS rules.

Actual html: 
```html
<html>
    <head>
        <style>
            .text-secondary {color: #93959A;}
            [...]
            [Other CSS rules]
            [...]
        </style>
    </head>
    <body>
        <div>Some content</div>
    </body>
</html>
```

Will look this way in TEXT version of Email: 
```
.text-secondary {color: #93959A;}
[...]
[Other CSS rules]
[...]
Some content
```

--------------

If TEXT version of Email differs drastically from visible content of HTML version,
it can be result that some penalty points will apply to such mails: 
http://wiki.apache.org/spamassassin/Rules/MPART_ALT_DIFF_COUNT


Since it's default behaviour for both yii2-app-advanced and yii2-app-basic (where stripped from tags html used for TextBody),
I believe people will stumble in this for sure, without even knowing that their emails can be penalized.


You can reproduce it by placing CSS styles in email view or layout
and test it here: http://www.mail-tester.com/ (SpamAssassin section).
2014-05-02 17:01:03 +03:00
Alexander Makarov
a4c644d3a3 Fixes #3325: fixed generated markup for conditional comments
No changelog line since feature was introduced after beta
2014-05-02 15:29:26 +04:00
Alexander Makarov
009238156e Fixed slashed to match guide 2014-05-02 14:47:19 +04:00
Qiang Xue
0880656be3 Fixes #3311. 2014-05-01 22:19:48 -04:00
Yeung Song
9dcdbd5e30 update document for BaseYii::setAlias method.
update
2014-05-02 05:42:30 +08:00
Qiang Xue
48c7e328c9 Finished behavior guide [skip ci] 2014-04-30 21:21:53 -04:00
Carsten Brandt
2e892c42e4 added docs about build automation tool
fixes #2852
2014-04-30 23:44:56 +02:00
Qiang Xue
5b6e79dc14 Fixes #3298: Supported configuring View::theme using a class name 2014-04-30 08:36:28 -04:00
Qiang Xue
7d31cba3a8 Finished event guide. [skip ci] 2014-04-29 19:03:06 -04:00
Qiang Xue
d954618796 Added support to insert an event handler at the beginning of class-level event handler queue 2014-04-29 18:31:54 -04:00
Alexander Makarov
340278b59c Fixes #3183: fixed regression after #3175 2014-04-30 01:31:11 +04:00
Alexander Makarov
d1558770d9 Added issue number to bootstrap/preload change 2014-04-29 20:38:03 +04:00
Alexander Makarov
a620342315 Adjusted phpdoc, tests and changelog for StringHelper::truncate and StringHelper::truncateWords 2014-04-29 18:23:48 +04:00
Alexander Makarov
8d18d722b2 Merge branch 'stringhelper-truncate' of github.com:Alex-Code/yii2 into Alex-Code-stringhelper-truncate
Conflicts:
	framework/CHANGELOG.md
2014-04-29 18:03:44 +04:00
Paul K
b09d0f12af overwrite -> override 2014-04-29 13:54:21 +02:00
Carsten Brandt
6f7be5ee5c filterWhere for postgres ILIKE
fixes #3252
2014-04-29 13:22:31 +02:00
Carsten Brandt
5c748ddb42 added case insensitve LIKE to PostgresQueryBuilder
fixes #3252

also improved unit tests for querybuilder buildLikeCondition
2014-04-29 12:04:10 +02:00
Qiang Xue
453ed4d93a fixed #3268 2014-04-27 17:22:07 -04:00
Qiang Xue
9b71adb4fa Fixes #3268: Fixed the bug that the schema name in a table name was not respected by yii\db\mysql\Schema 2014-04-27 12:14:30 -04:00
Qiang Xue
4fcd5003de Fixes #2906: Added support for using conditional comments for js and css files registered through asset bundles and Html helper 2014-04-26 20:25:48 -04:00
Carsten Brandt
3437c571a1 phpdoc controller did not find some setters
fixes #3255
2014-04-26 13:03:08 +02:00
Qiang Xue
7b374c4126 Fixes #3230: Added yii\filters\AccessControl::user to support access control with different actors 2014-04-25 22:22:03 -04:00
Carsten Brandt
c27ac8ef0e updated phpdoc 2014-04-26 03:39:46 +02:00
lynicidn
7c390d62d6 typo in comments
property can be set via [[setComponents()]]
2014-04-26 02:53:45 +04:00
Qiang Xue
f48a7aedfa Fixes #3251: controller should be created using DI container. 2014-04-25 10:10:51 -04:00
Carsten Brandt
4f9e4e2c78 ensure assetmanager and baseurl to handle relative urls correctly 2014-04-25 04:06:07 +02:00
Carsten Brandt
6fe63a217f view did not use the correct assetmanager 2014-04-25 04:06:07 +02:00
Carsten Brandt
78a8694eb5 file helper did not preserve relative paths 2014-04-25 04:06:07 +02:00
Agrumas
c5a564f0ff Lithuanian translation 2014-04-24 23:20:24 +03:00
Philippe Gaultier
4727ecdb1b Set correct ticked ID 2014-04-24 17:10:02 +02:00
Philippe Gaultier
f0acb178b3 Update changelog 2014-04-24 17:06:56 +02:00
Philippe Gaultier
20e96cca05 Fix DateTime cast 2014-04-24 17:06:44 +02:00
Michael Härtl
1e3989e5d1 Fix call to AssetConverter::convert() in AssetBundle 2014-04-24 13:01:05 +02:00
Ceana Razvan
48635c2d3e Update Response.php
$_SERVER['SERVER_PROTOCOL'] returns 'HTTP/1.0' or 'HTTP/1.1'
2014-04-24 03:42:23 +03:00
Qiang Xue
3e3e443544 Refactored the fix for #3222. 2014-04-23 19:36:56 -04:00
Qiang Xue
cbcc7b6a48 Fixes #2264: CookieCollection::has() will return false for expired or removed cookies 2014-04-23 09:28:05 -04:00
Carsten Brandt
119f0f0172 Merge branch 'master' of github.com:yiisoft/yii2
* 'master' of github.com:yiisoft/yii2:
  Refactored filter error display for GridView.
  Fixes #3008: Added `Html::errorSummary()`
2014-04-23 03:25:44 +02:00
Carsten Brandt
91965fd391 phpdoc formatting issues 2014-04-23 02:55:17 +02:00
Qiang Xue
c15aceb094 Refactored filter error display for GridView. 2014-04-22 20:46:23 -04:00
Carsten Brandt
12d34849cc improved phpdoc command 2014-04-23 02:13:53 +02:00
Qiang Xue
7ca1be3504 Fixes #3008: Added Html::errorSummary() 2014-04-22 19:55:13 -04:00
Carsten Brandt
83a63f2346 fixed wrong client validation issue in numbervalidator
fixes #3118
2014-04-23 01:29:53 +02:00
Qiang Xue
4f6e1d305f Refactored the code for #3154 2014-04-22 18:56:05 -04:00
Carsten Brandt
61841345eb Merge pull request #3164 from ivan-kolmychek/3154-gridview-filter-error-indication
GridView filter error indication added (#3154)
2014-04-23 00:25:11 +02:00
Qiang Xue
f1ff318abc Merge branch 'master' of git://github.com/yiisoft/yii2 2014-04-22 14:54:12 -04:00
Qiang Xue
051b4194e9 Fixes #3216. 2014-04-22 14:54:02 -04:00
Carsten Brandt
2b593da08f phpdoc issue
[ci skip]
2014-04-22 20:14:49 +02:00
Qiang Xue
d859fca569 Fixes #3216: Fixed the bug that yii.activeForm.destroy() did not remove submit event handlers 2014-04-22 12:46:37 -04:00
Qiang Xue
b55ce76479 Fixes #1263: Fixed the issue that Gii and Debug modules might be affected by incompatible asset manager configuration 2014-04-22 12:42:51 -04:00
Qiang Xue
9c5429740d Fixes #3212: removed unnecessary prepare() call. 2014-04-22 11:51:28 -04:00