Commit Graph

3198 Commits

Author SHA1 Message Date
Carsten Brandt
e82b40abee avoid duplicate slashes on empty values
fixes #13522
close #13525
2017-02-08 09:41:04 +01:00
Carsten Brandt
456d23272c added failing test for #13522
regression after 2.0.11 release.
2017-02-08 09:40:53 +01:00
Carsten Brandt
fba4e43469 added failing test for #13533
issue #13533
PR #13534
2017-02-08 09:10:19 +01:00
Robert Korulczyk
4c46c6a096 Improve messages test on HHVM. (#13520) 2017-02-06 09:54:13 +01:00
Carsten Brandt
25b78aa615 Fixes #13508: Fixed duplicate attachment of behavior BC break
Fixes BC break introduced in
954c771fdb (diff-d45d5e14cbb9739c2e1c63b53ba5e363L669)
2017-02-04 15:47:04 +03:00
Bizley
1749c46c5d Fixes #11502: Fixed yii\console\controllers\MessageController to properly populate missing languages in case of extraction with "db" format 2017-02-02 02:50:34 +03:00
Carsten Brandt
a7f8d0efb4 added test for #12697 2017-01-31 13:42:38 +01:00
ErickSkrauch
c641513583 Implementation of support UrlRule with relative host definition
close #12697
fixes #12691
2017-01-31 13:42:31 +01:00
Carsten Brandt
1e4484748b Merge pull request #13477 from yiisoft/urlmanager-test
Refactored UrlManagerTest to cover more use cases
2017-01-31 11:54:03 +01:00
Elvira Sheina
d39c491022 Fix BC breaking #13475 (#13478) 2017-01-31 11:56:46 +03:00
Carsten Brandt
8faedcbd7c Refactored UrlManagerTest to cover more use cases
UrlManager is a complex class with a large bunch of options that needs
to be tested
and we had a few regressions in the past even though there are already a
lot of tests
covering it. Test coverage measured by lines does not help us determine
how good it is tested,
we need test coverage for every major path through the code.

I have refactored the UrlManager tests to reflect the different options
and cases to
have a better overview of which cases are covered and which are not.

UrlManager has two main operation modes:

- "default" url format, which is the simple case. These are covered by
  methods in `UrlManagerTest`.

- "pretty" url format. This is the complex case, which involves UrlRules
  and url parsing.
  I have created two separate classes for this case:
  Url creation for "pretty" url format is covered by
`UrlManagerCreateUrlTest`.
  Url parsing for "pretty" url format is covered by
`UrlManagerParseUrlTest`.

Each of the test classes have a `getUrlManager` method that creates a
UrlManager instance
with a specific configuration and certain variations in options.
It is also tested that options that are not relevant in a certain
operation mode have no effect on the result.

To make sure to not remove tests that have existed before, here is a map
of where code has been moved.
The following test methods existed in the [old test
class](4187718c14/tests/framework/web/UrlManagerTest.php):

- `testCreateUrl()` split between UrlManagerTest and
  UrlManagerCreateUrlTest variations should all be covered by
`variationsProvider()`.
- `testCreateUrlWithNullParams()` covered by UrlManagerCreateUrlTest by
  `testWithNullParams()`
- `testCreateUrlWithEmptyPattern()`
- `testCreateAbsoluteUrl()` covered in UrlManagerCreateUrlTest by new
  tests via `variationsProvider()`.
- `testCreateAbsoluteUrlWithSuffix()` covered in UrlManagerCreateUrlTest
  by `testAbsolutePatterns`.

- `testParseRequest()` covered by UrlManagerParseUrlTest, UrlNormalizer
  related parts moved to UrlNormalizerTest.
- `testParseRESTRequest()` moved to UrlManagerParseUrlTest
- `testHash()` covered in different tests in UrlManagerCreateUrlTest.
- `testMultipleHostsRules($host)` kept as is.

Before:

    $ vendor/bin/phpunit tests/framework/web/UrlManagerTest.php
    ...
    OK (12 tests, 89 assertions)

After:

    $ vendor/bin/phpunit tests/framework/web/UrlManager*.php
    ...
    OK (72 tests, 648 assertions)
2017-01-31 02:38:35 +01:00
Carsten Brandt
4187718c14 added missing groups to tests 2017-01-30 23:03:11 +01:00
PowerGamer1
37b8cbb2d0 Fixes #12758: Added the ability to use instances of \yii\db\Query class as values in the \yii\db\QueryBuilder::insert() method 2017-01-29 00:54:46 +03:00
Alexander Makarov
c4175be7a3 Adjusted command test for incorrect inserts to use data provider 2017-01-29 00:22:10 +03:00
voroks
25f08afc96 Fixes #8293: yii\db\Query can be passed to insert method in yii\db\QueryBuilder 2017-01-28 23:47:26 +03:00
Alexander Makarov
1cc327f108 Run common batch insert tests for SQLite 2017-01-28 14:41:57 +03:00
Dmitriy Bashkarev
be4ebdd049 Fixes #13134: Added logging URL rules (bashkarev) 2017-01-27 19:03:45 +03:00
Alexey Rogachev
37f19a0256 Fixes #13300, #13307, #13310, #13312
- Bug #13300: Allow pjax with "data-pjax" with no value in `yii.js`.
- Bug #13307: Preventing of race conditions in script filter in `yii.js` works incorrectly.
- Bug #13310: Handle relative and absolute URLs coincidence in CSS filter in `yii.js`.
- Bug #13312: `skipOuterContainers` option was incorrectly passed to pjax in `handleAction` in `yii.js`.
- Partially fixes #13299.

Adds tests for #8014, #11921, #10974, #11494, #10358, #10097.
2017-01-25 11:00:13 +03:00
Tobias Munk
77188682f0 Merge commit 'd4d6c1dabf555e6f14a668df6fcc515bceef2830' into feature/docker-testing 2017-01-24 15:41:39 +01:00
Tobias Munk
478331efe8 updated build
- added git files to dockerignore
- updated local testing
- updated build on branches
2017-01-24 15:41:04 +01:00
Herbert Maschke
d4d6c1dabf Tests for 13393 (#13439)
* add some unit tests regarding redirection for ResponseTest

* also tests yii\web\controller redirect
2017-01-24 16:58:01 +03:00
Herbert Maschke
a6da9d5da8 Added unit tests regarding redirection for ResponseTest (#13437) 2017-01-24 15:05:28 +03:00
Klimov Paul
c73de31a90 Fixed yii\web\MultipartFormDataParser adds an extra newline to every value 2017-01-23 13:18:31 +02:00
Robert Korulczyk
507cc52658 Allow omit default params on URL creation
Fixes #10970
2017-01-22 22:19:13 +02:00
Elvira Sheina
b82caa97e8 Fixes #7820: Add or relation for targetAttribute in yii\validators\UniqueValidator 2017-01-22 19:45:18 +03:00
SilverFire - Dmitry Naumenko
3d549374bf Added BlameableBehaviorTest 2017-01-22 16:21:53 +02:00
Tobias Munk
b6d14cab26 Merge commit '3f66fb6cdfd498a119bfb34562549d07ff2ff9e0' into feature/docker-testing 2017-01-20 01:24:39 +01:00
Tobias Munk
25cc36c524 fixed network setup 2017-01-20 00:16:12 +01:00
Tobias Munk
cc1f398946 updated docs 2017-01-19 22:47:17 +01:00
Tobias Munk
f5ab85c393 updated debug settings (+56 squashed commits)
Squashed commits:
[c42f30c] updated base image, added docs & local test script
[88f0c40] debug
[6220c94] fixed network isolation
[c63c7c3] test mssql only on test/mssql branch
[74efc78] fixed isolation in after_script
[02b895b] updated test setup
[3335f39] updated retry
[bd123b2] updated service checks
[45e4c90] updated build
[d54da7a] updated after_script
[5a4c726] 🏭 wait for mysql
[08db878] fixed typo
[ea53c1e] updated build stages
[9807ce3] fixed typos
[cf9f64e] fixed mssql testing
[08001d6] added db create for mssql
[62f6b65] run travis (gitlab simulation) only in travis branch
[cf63da4] streamlined build
[76808ac] updated test jobs
[18d79b5] fixed test error
[7b2bce6] updated build & composer.lock
[244623a] updated build
[86bd71b] fixed cleanup
[86ab2e8] fixed cleanup
[091d4b8] fixed tests
[2d315b5] fixed build config
[2913644] fixed project names
[f53b823] refactored build config
[5a791fb] refactored docker db-tests
[b4479b0] revert
[a975fa5] updated gitlab build
[4e4e5e4] updated mssql setup
[d6ff03b] added sleep workaround
[578b102] removed host volumes in test
[928f50b] fixed path
[967ab10] updated tests
[520f317] bootstrap cubrid
[5f245e1] 🏭 fixed cubrid tests
[940dbbc] 🏭 pinned cubrid version 9.3.6.0002
[8d5ea69] 📝 dockerized test commands
[9954b54] updated cubrid
[fb3afac] updated docs
[3f63ced] updated isolation
[bdc3c83] 🏭 build cubrid
[b777911] 🏭 disabled mssql, updated cubrid
[36534e7] added travis-a-like stage
[6546f02] updated GitLab build
[c046096] updated test setup
- added mssql and cubrid stack
[5a0e635] disabled host-volume
[75cf342] fixed test
[8de0794] fixed testing
[465d27a] added stages
[63aa950] added script
[68eecef] fixed typo
[00e4b88] updated Docker build
[f9072cc] added dockerized test setup
2017-01-19 18:01:08 +01:00
João Pedro Pereira
3692941ead Fixes #11464: Foreign key name is not provided by schema 2017-01-16 00:27:20 +03:00
Alexander Makarov
eee7b9663c Merge branch 'master' into fix-numbervalidator-comma-decimal-separator 2017-01-15 22:41:09 +03:00
Klimov Paul
d4ac47abe7 Added yii\validators\EachValidator::$stopOnFirstError allowing addition of more than one error 2017-01-13 17:59:10 +02:00
Klimov Paul
b93856cdfd Unit test for yii\caching\DbDependency added 2017-01-13 12:16:37 +02:00
Klimov Paul
3946ac0dab Added yii\widgets\InputWidget::$field field, allowing access to the related yii\widget\ActiveField instance 2017-01-13 11:36:33 +02:00
Robert Korulczyk
6d277ddafb Tests for create URLs with multiple domain rules. (#13351) 2017-01-08 21:58:33 +03:00
a.kompaniets
50f3012f68 fixed currency format with custom decimal fraction
fixes #12345
close #12648
2017-01-03 00:03:40 +01:00
Carsten Brandt
a51dadc866 added test for #12345 2017-01-03 00:03:40 +01:00
Vladimir
f3bc11c724 Implement #13219: Ability to not shuffle masters connections (#13241)
* Implement #13219: Ability to not shuffle masters connections

* Enh: add master connection getter

* Add test case for #13241 which implements #13219

* Doc comments [skip ci]

* Doc comments

* Fix: wrong return value when no masters

* Revert `getMasterPdo()` 4a786c7e10

* Fix: try to fix too slow test

* Refact: fix Single Responsibility; Fix possible BC break

* Update Connection.php

* Update Connection.php

* Update Connection.php

* Update Connection.php

* Updated CHANGELOG

* Fix: grammatic mistake

* Refact: property renamed from `randomizeMasters` to `shuffleMasters`

* Refact: split and try to simplify tests
2017-01-02 02:15:13 +01:00
bashkarev
338e5967cb Added Logging of memory usage
calculateTimings added options: `memory`, `memoryDiff` memory_get_usage only the used memory is reported.

close #13268
2017-01-02 02:01:49 +01:00
SilverFire - Dmitry Naumenko
f6b9aac0bf Ehanced yii\web\ErrorAction test coverage 2016-12-31 21:38:55 +02:00
SilverFire - Dmitry Naumenko
24ad05de5b Refactored yii\web\ErrorAction to make it reusable 2016-12-31 21:29:12 +02:00
SilverFire - Dmitry Naumenko
edc3d0a35f Enhanced TestCase::invokeMethod(), ::getInaccessibleProperty() to revoke access after calling 2016-12-31 21:27:48 +02:00
Pavel Ivanov
4db3bcd64c Fixes #13277: Invalid parsing of -- in CLI 2016-12-31 16:31:07 +02:00
SilverFire - Dmitry Naumenko
178d319556 Added Cache::getOrSet() 2016-12-30 23:49:18 +02:00
Carsten Brandt
96ee5c373e added more tests for SwiftMailer vulnerability CVE-2016-10074
https://legalhackers.com/advisories/SwiftMailer-Exploit-Remote-Code-Exec-CVE-2016-10074-Vuln.html
2016-12-28 23:50:10 +01:00
SilverFire - Dmitry Naumenko
6af2a43390 Added EmailValidatorTest to prove CVE-2016-10074 does not affect EmailValidator 2016-12-29 00:21:23 +02:00
Alexander Makarov
c33583aede Fixed naming for #13214 as suggested by Paul 2016-12-26 22:42:14 +07:00
Alexander Makarov
c175c6b73a Merge branch 'master' into xml-formatter-root-and-object-tags 2016-12-26 18:17:15 +03:00
Klimov Paul
6211f9c030 MigrateControllerTestTrait fix for HHVM 2016-12-26 16:02:22 +02:00