php/yii2
1
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2025-11-26 03:30:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed condition building for booleans

Browse Source
This commit is contained in:
Alexander Makarov
2014-09-07 20:26:55 +04:00
parent 7c7783a548
commit f7fc1faa97
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/redis/LuaScriptBuilder.php
View File

@@ -268,6 +268,9 @@ EOF;
if (is_array($value)) { // IN condition if (is_array($value)) { // IN condition
$parts[] = $this->buildInCondition('in', [$column, $value], $columns); $parts[] = $this->buildInCondition('in', [$column, $value], $columns);
} else { } else {
if (is_bool($value)) {
$value = (int)$value;
}
$column = $this->addColumn($column, $columns); $column = $this->addColumn($column, $columns);
if ($value === null) { if ($value === null) {
$parts[] = "$column==nil"; $parts[] = "$column==nil";

6
tests/unit/extensions/redis/ActiveRecordTest.php
View File

@@ -161,12 +161,6 @@ class ActiveRecordTest extends RedisTestCase
$this->markTestSkipped('Redis does not store/find null values correctly.'); $this->markTestSkipped('Redis does not store/find null values correctly.');
} }
public function testBooleanAttribute()
{
// https://github.com/yiisoft/yii2/issues/1311
$this->markTestSkipped('Redis does not store/find boolean values correctly.');
}
public function testFindEagerViaRelationPreserveOrder() public function testFindEagerViaRelationPreserveOrder()
{ {
$this->markTestSkipped('Redis does not support orderBy.'); $this->markTestSkipped('Redis does not support orderBy.');