diff --git a/framework/db/ColumnSchemaBuilder.php b/framework/db/ColumnSchemaBuilder.php index 23f15c88c1..d8e823d847 100644 --- a/framework/db/ColumnSchemaBuilder.php +++ b/framework/db/ColumnSchemaBuilder.php @@ -20,15 +20,14 @@ use yii\base\Object; */ class ColumnSchemaBuilder extends Object { - /** - * The following are the categories of column data types. - * @since 2.0.8 - */ - const CAT_PK = 'pk'; - const CAT_STRING = 'string'; - const CAT_NUMERIC = 'numeric'; - const CAT_TIME = 'time'; - const CAT_OTHER = 'other'; + // Internally used constants representing categories that abstract column types fall under. + // See $categoryMap for mappings of column types to category. + // @since 2.0.8 + const CATEGORY_PK = 'pk'; + const CATEGORY_STRING = 'string'; + const CATEGORY_NUMERIC = 'numeric'; + const CATEGORY_TIME = 'time'; + const CATEGORY_OTHER = 'other'; /** * @var string the column type definition such as INTEGER, VARCHAR, DATETIME, etc. @@ -75,25 +74,25 @@ class ColumnSchemaBuilder extends Object * @var array mapping of abstract column types (keys) to type categories (values). */ public $categoryMap = [ - Schema::TYPE_PK => self::CAT_PK, - Schema::TYPE_BIGPK => self::CAT_PK, - Schema::TYPE_UNSIGNEDPK => self::CAT_PK, - Schema::TYPE_CHAR => self::CAT_STRING, - Schema::TYPE_STRING => self::CAT_STRING, - Schema::TYPE_TEXT => self::CAT_STRING, - Schema::TYPE_SMALLINT => self::CAT_NUMERIC, - Schema::TYPE_INTEGER => self::CAT_NUMERIC, - Schema::TYPE_BIGINT => self::CAT_NUMERIC, - Schema::TYPE_FLOAT => self::CAT_NUMERIC, - Schema::TYPE_DOUBLE => self::CAT_NUMERIC, - Schema::TYPE_DECIMAL => self::CAT_NUMERIC, - Schema::TYPE_DATETIME => self::CAT_TIME, - Schema::TYPE_TIMESTAMP => self::CAT_TIME, - Schema::TYPE_TIME => self::CAT_TIME, - Schema::TYPE_DATE => self::CAT_TIME, - Schema::TYPE_BINARY => self::CAT_OTHER, - Schema::TYPE_BOOLEAN => self::CAT_NUMERIC, - Schema::TYPE_MONEY => self::CAT_NUMERIC, + Schema::TYPE_PK => self::CATEGORY_PK, + Schema::TYPE_BIGPK => self::CATEGORY_PK, + Schema::TYPE_UNSIGNEDPK => self::CATEGORY_PK, + Schema::TYPE_CHAR => self::CATEGORY_STRING, + Schema::TYPE_STRING => self::CATEGORY_STRING, + Schema::TYPE_TEXT => self::CATEGORY_STRING, + Schema::TYPE_SMALLINT => self::CATEGORY_NUMERIC, + Schema::TYPE_INTEGER => self::CATEGORY_NUMERIC, + Schema::TYPE_BIGINT => self::CATEGORY_NUMERIC, + Schema::TYPE_FLOAT => self::CATEGORY_NUMERIC, + Schema::TYPE_DOUBLE => self::CATEGORY_NUMERIC, + Schema::TYPE_DECIMAL => self::CATEGORY_NUMERIC, + Schema::TYPE_DATETIME => self::CATEGORY_TIME, + Schema::TYPE_TIMESTAMP => self::CATEGORY_TIME, + Schema::TYPE_TIME => self::CATEGORY_TIME, + Schema::TYPE_DATE => self::CATEGORY_TIME, + Schema::TYPE_BINARY => self::CATEGORY_OTHER, + Schema::TYPE_BOOLEAN => self::CATEGORY_NUMERIC, + Schema::TYPE_MONEY => self::CATEGORY_NUMERIC, ]; /** @@ -207,7 +206,7 @@ class ColumnSchemaBuilder extends Object public function __toString() { switch ($this->getTypeCategory()) { - case self::CAT_PK: + case self::CATEGORY_PK: $format = '{type}{length}{pos}'; break; default: diff --git a/framework/db/cubrid/ColumnSchemaBuilder.php b/framework/db/cubrid/ColumnSchemaBuilder.php index 3a4ada91d2..a9a049add5 100644 --- a/framework/db/cubrid/ColumnSchemaBuilder.php +++ b/framework/db/cubrid/ColumnSchemaBuilder.php @@ -47,10 +47,10 @@ class ColumnSchemaBuilder extends AbstractColumnSchemaBuilder public function __toString() { switch ($this->getTypeCategory()) { - case self::CAT_PK: + case self::CATEGORY_PK: $format = '{type}{length}{pos}'; break; - case self::CAT_NUMERIC: + case self::CATEGORY_NUMERIC: $format = '{type}{length}{unsigned}{notnull}{unique}{default}{check}{pos}'; break; default: diff --git a/framework/db/mysql/ColumnSchemaBuilder.php b/framework/db/mysql/ColumnSchemaBuilder.php index ddc980a0f9..e5da1caef9 100644 --- a/framework/db/mysql/ColumnSchemaBuilder.php +++ b/framework/db/mysql/ColumnSchemaBuilder.php @@ -47,10 +47,10 @@ class ColumnSchemaBuilder extends AbstractColumnSchemaBuilder public function __toString() { switch ($this->getTypeCategory()) { - case self::CAT_PK: + case self::CATEGORY_PK: $format = '{type}{length}{pos}'; break; - case self::CAT_NUMERIC: + case self::CATEGORY_NUMERIC: $format = '{type}{length}{unsigned}{notnull}{unique}{default}{check}{pos}'; break; default: diff --git a/framework/db/mysql/Schema.php b/framework/db/mysql/Schema.php index acb0245ce0..7159a22181 100644 --- a/framework/db/mysql/Schema.php +++ b/framework/db/mysql/Schema.php @@ -52,10 +52,6 @@ class Schema extends \yii\db\Schema 'enum' => self::TYPE_STRING, ]; - /** - * @var array mapping from type groups to - */ - /** * Quotes a table name for use in a query. * A simple table name has no schema prefix. diff --git a/framework/db/oci/ColumnSchemaBuilder.php b/framework/db/oci/ColumnSchemaBuilder.php index f483083dcb..b86ad16d8a 100644 --- a/framework/db/oci/ColumnSchemaBuilder.php +++ b/framework/db/oci/ColumnSchemaBuilder.php @@ -47,10 +47,10 @@ class ColumnSchemaBuilder extends AbstractColumnSchemaBuilder public function __toString() { switch ($this->getTypeCategory()) { - case self::CAT_PK: + case self::CATEGORY_PK: $format = '{type}{length}{pos}'; break; - case self::CAT_NUMERIC: + case self::CATEGORY_NUMERIC: $format = '{type}{length}{unsigned}{default}{notnull}{check}{pos}'; break; default: diff --git a/framework/db/sqlite/ColumnSchemaBuilder.php b/framework/db/sqlite/ColumnSchemaBuilder.php index fe11de2c70..985873e058 100644 --- a/framework/db/sqlite/ColumnSchemaBuilder.php +++ b/framework/db/sqlite/ColumnSchemaBuilder.php @@ -32,10 +32,10 @@ class ColumnSchemaBuilder extends AbstractColumnSchemaBuilder public function __toString() { switch ($this->getTypeCategory()) { - case self::CAT_PK: + case self::CATEGORY_PK: $format = '{type}{length}'; break; - case self::CAT_NUMERIC: + case self::CATEGORY_NUMERIC: $format = '{type}{length}{unsigned}{notnull}{unique}{check}{default}'; break; default: