php/yii2
1
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2025-08-23 04:00:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

ensure atomicity of operations

Browse Source
This commit is contained in:
Carsten Brandt
2013-09-25 11:41:41 +02:00
parent c6c164dc71
commit f3aa807d8f
1 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
framework/yii/redis/ActiveRecord.php
View File

@ -7,7 +7,6 @@
namespace yii\redis; namespace yii\redis;
use yii\base\InvalidCallException;
use yii\base\InvalidConfigException; use yii\base\InvalidConfigException;
use yii\base\NotSupportedException; use yii\base\NotSupportedException;
use yii\db\TableSchema; use yii\db\TableSchema;
@ -19,7 +18,7 @@ use yii\helpers\StringHelper;
* @author Carsten Brandt <mail@cebe.cc> * @author Carsten Brandt <mail@cebe.cc>
* @since 2.0 * @since 2.0
*/ */
abstract class ActiveRecord extends \yii\db\ActiveRecord class ActiveRecord extends \yii\db\ActiveRecord
{ {
/** /**
* @var array cache for TableSchema instances * @var array cache for TableSchema instances
@ -81,17 +80,19 @@ abstract class ActiveRecord extends \yii\db\ActiveRecord
} }
$newPk = static::buildKey($newPk); $newPk = static::buildKey($newPk);
$newKey = static::tableName() . ':a:' . $newPk; $newKey = static::tableName() . ':a:' . $newPk;
$db->executeCommand('HMSET', $args); // rename index if pk changed
// rename index
if ($newPk != $pk) { if ($newPk != $pk) {
// TODO make this atomic $db->executeCommand('MULTI');
$db->executeCommand('HMSET', $args);
$db->executeCommand('LINSERT', array(static::tableName(), 'AFTER', $pk, $newPk)); $db->executeCommand('LINSERT', array(static::tableName(), 'AFTER', $pk, $newPk));
$db->executeCommand('LREM', array(static::tableName(), 0, $pk)); $db->executeCommand('LREM', array(static::tableName(), 0, $pk));
$db->executeCommand('RENAME', array($key, $newKey)); $db->executeCommand('RENAME', array($key, $newKey));
$db->executeCommand('EXEC');
} else {
$db->executeCommand('HMSET', $args);
} }
$n++; $n++;
} }
return $n; return $n;
} }
@ -143,7 +144,9 @@ abstract class ActiveRecord extends \yii\db\ActiveRecord
{ {
$db = static::getDb(); $db = static::getDb();
$attributeKeys = array(); $attributeKeys = array();
foreach(static::fetchPks($condition) as $pk) { $pks = static::fetchPks($condition);
$db->executeCommand('MULTI');
foreach($pks as $pk) {
$pk = static::buildKey($pk); $pk = static::buildKey($pk);
$db->executeCommand('LREM', array(static::tableName(), 0, $pk)); $db->executeCommand('LREM', array(static::tableName(), 0, $pk));
$attributeKeys[] = static::tableName() . ':a:' . $pk; $attributeKeys[] = static::tableName() . ':a:' . $pk;
@ -151,7 +154,9 @@ abstract class ActiveRecord extends \yii\db\ActiveRecord
if (empty($attributeKeys)) { if (empty($attributeKeys)) {
return 0; return 0;
} }
return $db->executeCommand('DEL', $attributeKeys);// TODO make this atomic or document as NOT $db->executeCommand('DEL', $attributeKeys);
$result = $db->executeCommand('EXEC');
return end($result);
} }
private static function fetchPks($condition) private static function fetchPks($condition)