php/yii2
1
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2025-11-12 11:40:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

ActiveRecord::insert() and ActiveRecord::update() refactoring

Browse Source
This commit is contained in:
Alexander Kochetov
2013-05-07 18:10:50 +04:00
parent dd5969147d
commit f12518f45c
1 changed files with 47 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

101
framework/db/ActiveRecord.php
View File

@@ -667,36 +667,33 @@ class ActiveRecord extends Model
*/ */
public function insert($runValidation = true, $attributes = null) public function insert($runValidation = true, $attributes = null)
{ {
if ($runValidation && !$this->validate($attributes)) { if ($runValidation && !$this->validate($attributes) && !$this->beforeSave(true)) {
return false; return false;
} }
if ($this->beforeSave(true)) { $values = $this->getDirtyAttributes($attributes);
$values = $this->getDirtyAttributes($attributes); if (empty($values)) {
if ($values === array()) { foreach ($this->primaryKey() as $key) {
foreach ($this->primaryKey() as $key) { $values[$key] = isset($this->_attributes[$key]) ? $this->_attributes[$key] : null;
$values[$key] = isset($this->_attributes[$key]) ? $this->_attributes[$key] : null;
}
}
$db = static::getDb();
$command = $db->createCommand()->insert($this->tableName(), $values);
if ($command->execute()) {
$table = $this->getTableSchema();
if ($table->sequenceName !== null) {
foreach ($table->primaryKey as $name) {
if (!isset($this->_attributes[$name])) {
$this->_oldAttributes[$name] = $this->_attributes[$name] = $db->getLastInsertID($table->sequenceName);
break;
}
}
}
foreach ($values as $name => $value) {
$this->_oldAttributes[$name] = $value;
}
$this->afterSave(true);
return true;
} }
} }
return false; $db = static::getDb();
$command = $db->createCommand()->insert($this->tableName(), $values);
if ($command->execute()) {
$table = $this->getTableSchema();
if ($table->sequenceName !== null) {
foreach ($table->primaryKey as $name) {
if (!isset($this->_attributes[$name])) {
$this->_oldAttributes[$name] = $this->_attributes[$name] = $db->getLastInsertID($table->sequenceName);
break;
}
}
}
foreach ($values as $name => $value) {
$this->_oldAttributes[$name] = $value;
}
$this->afterSave(true);
return true;
}
} }
/** /**
@@ -750,39 +747,35 @@ class ActiveRecord extends Model
*/ */
public function update($runValidation = true, $attributes = null) public function update($runValidation = true, $attributes = null)
{ {
if ($runValidation && !$this->validate($attributes)) { if ($runValidation && !$this->validate($attributes) && !$this->beforeSave(false)) {
return false; return false;
} }
if ($this->beforeSave(false)) { $values = $this->getDirtyAttributes($attributes);
$values = $this->getDirtyAttributes($attributes); if (!empty($values)) {
if ($values !== array()) { $condition = $this->getOldPrimaryKey(true);
$condition = $this->getOldPrimaryKey(true); $lock = $this->optimisticLock();
$lock = $this->optimisticLock(); if ($lock !== null) {
if ($lock !== null) { if (!isset($values[$lock])) {
if (!isset($values[$lock])) { $values[$lock] = $this->$lock + 1;
$values[$lock] = $this->$lock + 1;
}
$condition[$lock] = $this->$lock;
} }
// We do not check the return value of updateAll() because it's possible $condition[$lock] = $this->$lock;
// that the UPDATE statement doesn't change anything and thus returns 0.
$rows = $this->updateAll($values, $condition);
if ($lock !== null && !$rows) {
throw new StaleObjectException('The object being updated is outdated.');
}
foreach ($values as $name => $value) {
$this->_oldAttributes[$name] = $this->_attributes[$name];
}
$this->afterSave(false);
return $rows;
} else {
return 0;
} }
// We do not check the return value of updateAll() because it's possible
// that the UPDATE statement doesn't change anything and thus returns 0.
$rows = $this->updateAll($values, $condition);
if ($lock !== null && !$rows) {
throw new StaleObjectException('The object being updated is outdated.');
}
foreach ($values as $name => $value) {
$this->_oldAttributes[$name] = $this->_attributes[$name];
}
$this->afterSave(false);
return $rows;
} else { } else {
return false; return 0;
} }
} }