php/yii2
1
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2025-08-26 06:15:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

#14543: Adjusted implementation of migration name length limit

Browse Source
This commit is contained in:
Carsten Brandt
2017-10-26 23:20:37 +02:00
committed by Alexander Makarov
parent 336404e0b9
commit e311001ef5
4 changed files with 65 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
framework/console/controllers/MigrateController.php
View File

@ -73,6 +73,13 @@ use yii\helpers\Console;
*/
class MigrateController extends BaseMigrateController
{
/**
* Maximum length of a migration name.
* @since 2.0.13
*/
const MAX_NAME_LENGTH = 180;
/**
* @var string the name of the table for keeping applied migration information.
*/
@ -167,10 +174,7 @@ class MigrateController extends BaseMigrateController
public function beforeAction($action)
{
if (parent::beforeAction($action)) {
if ($action->id !== 'create') {
$this->db = Instance::ensure($this->db, Connection::className());
}
$this->db = Instance::ensure($this->db, Connection::className());
return true;
}
@ -258,7 +262,7 @@ class MigrateController extends BaseMigrateController
$tableName = $this->db->schema->getRawTableName($this->migrationTable);
$this->stdout("Creating migration history table \"$tableName\"...", Console::FG_YELLOW);
$this->db->createCommand()->createTable($this->migrationTable, [
'version' => 'varchar(180) NOT NULL PRIMARY KEY',
'version' => 'varchar(' . static::MAX_NAME_LENGTH . ') NOT NULL PRIMARY KEY',
'apply_time' => 'integer',
])->execute();
$this->db->createCommand()->insert($this->migrationTable, [
@ -317,6 +321,25 @@ class MigrateController extends BaseMigrateController
])->execute();
}
private $_migrationNameLimit;
/**
* @inheritdoc
* @since 2.0.13
*/
protected function getMigrationNameLimit()
{
if ($this->_migrationNameLimit !== null) {
return $this->_migrationNameLimit;
}
$tableSchema = $this->db->schema ? $this->db->schema->getTableSchema($this->migrationTable, true) : null;
if ($tableSchema !== null) {
return $this->_migrationNameLimit = $tableSchema->columns['version']->size;
}
return static::MAX_NAME_LENGTH;
}
/**
* @inheritdoc
* @since 2.0.8