php/yii2
1
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2025-08-26 06:15:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

#14543: Adjusted implementation of migration name length limit

Browse Source
This commit is contained in:
Carsten Brandt
2017-10-26 23:20:37 +02:00
committed by Alexander Makarov
parent 336404e0b9
commit e311001ef5
4 changed files with 65 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
framework/console/controllers/BaseMigrateController.php
View File

@ -31,10 +31,6 @@ abstract class BaseMigrateController extends Controller
*/
const BASE_MIGRATION = 'm000000_000000_base';
/**
* Maximum length of migration name
*/
const MAX_NAME_LENGTH = 180;
/**
* @var string the default command action.
@ -189,6 +185,11 @@ abstract class BaseMigrateController extends Controller
}
foreach ($migrations as $migration) {
$nameLimit = $this->getMigrationNameLimit();
if ($nameLimit !== null && strlen($migration) > $nameLimit) {
$this->stdout("\nThe migration name '$migration' is too long. Its not possible to apply this migration.\n", Console::FG_RED);
return ExitCode::UNSPECIFIED_ERROR;
}
$this->stdout("\t$migration\n");
}
$this->stdout("\n");
@ -196,11 +197,6 @@ abstract class BaseMigrateController extends Controller
$applied = 0;
if ($this->confirm('Apply the above ' . ($n === 1 ? 'migration' : 'migrations') . '?')) {
foreach ($migrations as $migration) {
if (strlen($migration) > static::MAX_NAME_LENGTH) {
$this->stdout("\nThe migration name is too long. The rest of the migrations are canceled.\n", Console::FG_RED);
return ExitCode::UNSPECIFIED_ERROR;
}
if (!$this->migrateUp($migration)) {
$this->stdout("\n$applied from $n " . ($applied === 1 ? 'migration was' : 'migrations were') . " applied.\n", Console::FG_RED);
$this->stdout("\nMigration failed. The rest of the migrations are canceled.\n", Console::FG_RED);
@ -633,7 +629,8 @@ abstract class BaseMigrateController extends Controller
list($namespace, $className) = $this->generateClassName($name);
// Abort if name is too long
if (strlen($className) > static::MAX_NAME_LENGTH) {
$nameLimit = $this->getMigrationNameLimit();
if ($nameLimit !== null && strlen($className) > $nameLimit) {
throw new Exception('The migration name is too long.');
}
@ -949,6 +946,18 @@ abstract class BaseMigrateController extends Controller
throw new NotSupportedException('This command is not implemented in ' . get_class($this));
}
/**
* Return the maximum name length for a migration.
*
* Subclasses may override this method to define a limit.
* @return int|null the maximum name length for a migration or `null` if no limit applies.
* @since 2.0.13
*/
protected function getMigrationNameLimit()
{
return null;
}
/**
* Returns the migration history.
* @param int $limit the maximum number of records in the history to be returned. `null` for "no limit".