php/yii2
1
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2025-11-03 05:48:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add void return to method in tests. (#20602)

Browse Source
This commit is contained in:
Wilmer Arambula
2025-10-14 06:37:35 -03:00
committed by GitHub
parent 30824c5dcf
commit d71f7309ae
249 changed files with 2749 additions and 2538 deletions
Download Patch File Download Diff File Expand all files Collapse all files

88
tests/framework/db/QueryBuilderTest.php
View File

@ -8,6 +8,10 @@
namespace yiiunit\framework\db;
use Yii;
use Exception;
use Closure;
use yii\base\NotSupportedException;
use yii\db\ColumnSchemaBuilder;
use yii\db\conditions\BetweenColumnsCondition;
use yii\db\conditions\LikeCondition;
@ -48,13 +52,13 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @param bool $reset
* @param bool $open
* @return QueryBuilder
* @throws \Exception
* @throws Exception
*/
protected function getQueryBuilder($reset = true, $open = false)
{
$connection = $this->getConnection($reset, $open);
\Yii::$container->set('db', $connection);
Yii::$container->set('db', $connection);
switch ($this->driverName) {
case 'mysql':
@ -70,7 +74,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
case 'oci':
return new OracleQueryBuilder($connection);
}
throw new \Exception('Test is not implemented for ' . $this->driverName);
throw new Exception('Test is not implemented for ' . $this->driverName);
}
/**
@ -1060,7 +1064,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
return array_values($items);
}
public function testGetColumnType()
public function testGetColumnType(): void
{
$qb = $this->getQueryBuilder();
@ -1081,7 +1085,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
}
}
public function testCreateTableColumnTypes()
public function testCreateTableColumnTypes(): void
{
$qb = $this->getQueryBuilder();
if ($qb->db->getTableSchema('column_type_table', true) !== null) {
@ -1321,9 +1325,9 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @dataProvider buildFromDataProvider
* @param $table
* @param $expected
* @throws \Exception
* @throws Exception
*/
public function testBuildFrom($table, $expected)
public function testBuildFrom($table, $expected): void
{
$params = [];
$sql = $this->getQueryBuilder()->buildFrom([$table], $params);
@ -1345,9 +1349,9 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @param array $condition
* @param string $expected
* @param array $expectedParams
* @throws \Exception
* @throws Exception
*/
public function testBuildCondition($condition, $expected, $expectedParams)
public function testBuildCondition($condition, $expected, $expectedParams): void
{
$query = (new Query())->where($condition);
list($sql, $params) = $this->getQueryBuilder()->build($query);
@ -1361,7 +1365,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @param string $expected
* @param array $expectedParams
*/
public function testBuildFilterCondition($condition, $expected, $expectedParams)
public function testBuildFilterCondition($condition, $expected, $expectedParams): void
{
$query = (new Query())->filterWhere($condition);
list($sql, $params) = $this->getQueryBuilder()->build($query);
@ -1399,7 +1403,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @dataProvider primaryKeysProvider
* @param string $sql
*/
public function testAddDropPrimaryKey($sql, \Closure $builder)
public function testAddDropPrimaryKey($sql, Closure $builder): void
{
$this->assertSame($this->getConnection(false)->quoteSql($sql), $builder($this->getQueryBuilder(false)));
}
@ -1435,7 +1439,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @dataProvider foreignKeysProvider
* @param string $sql
*/
public function testAddDropForeignKey($sql, \Closure $builder)
public function testAddDropForeignKey($sql, Closure $builder): void
{
$this->assertSame($this->getConnection(false)->quoteSql($sql), $builder($this->getQueryBuilder(false)));
}
@ -1483,7 +1487,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @dataProvider indexesProvider
* @param string $sql
*/
public function testCreateDropIndex($sql, \Closure $builder)
public function testCreateDropIndex($sql, Closure $builder): void
{
$this->assertSame($this->getConnection(false)->quoteSql($sql), $builder($this->getQueryBuilder(false)));
}
@ -1520,7 +1524,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @dataProvider uniquesProvider
* @param string $sql
*/
public function testAddDropUnique($sql, \Closure $builder)
public function testAddDropUnique($sql, Closure $builder): void
{
$this->assertSame($this->getConnection(false)->quoteSql($sql), $builder($this->getQueryBuilder(false)));
}
@ -1549,7 +1553,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @dataProvider checksProvider
* @param string $sql
*/
public function testAddDropCheck($sql, \Closure $builder)
public function testAddDropCheck($sql, Closure $builder): void
{
$this->assertSame($this->getConnection(false)->quoteSql($sql), $builder($this->getQueryBuilder(false)));
}
@ -1578,7 +1582,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @dataProvider defaultValuesProvider
* @param string $sql
*/
public function testAddDropDefaultValue($sql, \Closure $builder)
public function testAddDropDefaultValue($sql, Closure $builder): void
{
$this->assertSame($this->getConnection(false)->quoteSql($sql), $builder($this->getQueryBuilder(false)));
}
@ -1596,7 +1600,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @param string $cond
* @param string $expectedQuerySql
*/
public function testBuildWhereExists($cond, $expectedQuerySql)
public function testBuildWhereExists($cond, $expectedQuerySql): void
{
$expectedQueryParams = [];
@ -1614,7 +1618,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
$this->assertEquals($expectedQueryParams, $actualQueryParams);
}
public function testBuildWhereExistsWithParameters()
public function testBuildWhereExistsWithParameters(): void
{
$expectedQuerySql = $this->replaceQuotes(
'SELECT [[id]] FROM [[TotalExample]] [[t]] WHERE (EXISTS (SELECT [[1]] FROM [[Website]] [[w]] WHERE (w.id = t.website_id) AND (w.merchant_id = :merchant_id))) AND (t.some_column = :some_value)'
@ -1638,7 +1642,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
$this->assertEquals($expectedQueryParams, $queryParams);
}
public function testBuildWhereExistsWithArrayParameters()
public function testBuildWhereExistsWithArrayParameters(): void
{
$expectedQuerySql = $this->replaceQuotes(
'SELECT [[id]] FROM [[TotalExample]] [[t]] WHERE (EXISTS (SELECT [[1]] FROM [[Website]] [[w]] WHERE (w.id = t.website_id) AND (([[w]].[[merchant_id]]=:qp0) AND ([[w]].[[user_id]]=:qp1)))) AND ([[t]].[[some_column]]=:qp2)'
@ -1666,7 +1670,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* This test contains three select queries connected with UNION and UNION ALL constructions.
* It could be useful to use "phpunit --group=db --filter testBuildUnion" command for run it.
*/
public function testBuildUnion()
public function testBuildUnion(): void
{
$expectedQuerySql = $this->replaceQuotes(
'(SELECT [[id]] FROM [[TotalExample]] [[t1]] WHERE (w > 0) AND (x < 2)) UNION ( SELECT [[id]] FROM [[TotalTotalExample]] [[t2]] WHERE w > 5 ) UNION ALL ( SELECT [[id]] FROM [[TotalTotalExample]] [[t3]] WHERE w = 3 )'
@ -1690,7 +1694,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
$this->assertEquals([], $queryParams);
}
public function testBuildWithQuery()
public function testBuildWithQuery(): void
{
$expectedQuerySql = $this->replaceQuotes(
'WITH a1 AS (SELECT [[id]] FROM [[t1]] WHERE expr = 1), a2 AS ((SELECT [[id]] FROM [[t2]] INNER JOIN [[a1]] ON t2.id = a1.id WHERE expr = 2) UNION ( SELECT [[id]] FROM [[t3]] WHERE expr = 3 )) SELECT * FROM [[a2]]'
@ -1721,7 +1725,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
$this->assertEquals([], $queryParams);
}
public function testBuildWithQueryRecursive()
public function testBuildWithQueryRecursive(): void
{
$expectedQuerySql = $this->replaceQuotes(
'WITH RECURSIVE a1 AS (SELECT [[id]] FROM [[t1]] WHERE expr = 1) SELECT * FROM [[a1]]'
@ -1740,7 +1744,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
$this->assertEquals([], $queryParams);
}
public function testSelectSubquery()
public function testSelectSubquery(): void
{
$subquery = (new Query())
->select('COUNT(*)')
@ -1756,7 +1760,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
$this->assertEmpty($params);
}
public function testComplexSelect()
public function testComplexSelect(): void
{
$query = (new Query())
->select([
@ -1777,7 +1781,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
$this->assertEmpty($params);
}
public function testSelectExpression()
public function testSelectExpression(): void
{
$query = (new Query())
->select(new Expression('1 AS ab'))
@ -1809,7 +1813,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
/**
* @see https://github.com/yiisoft/yii2/issues/10869
*/
public function testFromIndexHint()
public function testFromIndexHint(): void
{
$query = (new Query())->from([new Expression('{{%user}} USE INDEX (primary)')]);
list($sql, $params) = $this->getQueryBuilder()->build($query);
@ -1826,7 +1830,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
$this->assertEmpty($params);
}
public function testFromSubquery()
public function testFromSubquery(): void
{
// query subquery
$subquery = (new Query())->from('user')->where('account_id = accounts.id');
@ -1859,7 +1863,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
$this->assertEmpty($params);
}
public function testOrderBy()
public function testOrderBy(): void
{
// simple string
$query = (new Query())
@ -1903,7 +1907,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
$this->assertEquals([':to' => 4], $params);
}
public function testGroupBy()
public function testGroupBy(): void
{
// simple string
$query = (new Query())
@ -2044,7 +2048,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @param string $expectedSQL
* @param array $expectedParams
*/
public function testInsert($table, $columns, $params, $expectedSQL, $expectedParams)
public function testInsert($table, $columns, $params, $expectedSQL, $expectedParams): void
{
$actualParams = $params;
$actualSQL = $this->getQueryBuilder()->insert($table, $columns, $actualParams);
@ -2055,7 +2059,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
/**
* Dummy test to speed up QB's tests which rely on DB schema
*/
public function testInitFixtures()
public function testInitFixtures(): void
{
$this->assertInstanceOf('yii\db\QueryBuilder', $this->getQueryBuilder(true, true));
}
@ -2268,10 +2272,10 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @param array|null $updateColumns
* @param string|string[] $expectedSQL
* @param array $expectedParams
* @throws \yii\base\NotSupportedException
* @throws \Exception
* @throws NotSupportedException
* @throws Exception
*/
public function testUpsert($table, $insertColumns, $updateColumns, $expectedSQL, $expectedParams)
public function testUpsert($table, $insertColumns, $updateColumns, $expectedSQL, $expectedParams): void
{
$actualParams = [];
$actualSQL = $this->getQueryBuilder(true, $this->driverName === 'sqlite')->upsert($table, $insertColumns, $updateColumns, $actualParams);
@ -2341,9 +2345,9 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @param array $columns
* @param array $value
* @param string $expected
* @throws \Exception
* @throws Exception
*/
public function testBatchInsert($table, $columns, $value, $expected)
public function testBatchInsert($table, $columns, $value, $expected): void
{
$queryBuilder = $this->getQueryBuilder();
@ -2380,7 +2384,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @param string $expectedSQL
* @param array $expectedParams
*/
public function testUpdate($table, $columns, $condition, $expectedSQL, $expectedParams)
public function testUpdate($table, $columns, $condition, $expectedSQL, $expectedParams): void
{
$actualParams = [];
$actualSQL = $this->getQueryBuilder()->update($table, $columns, $condition, $actualParams);
@ -2412,7 +2416,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @param string $expectedSQL
* @param array $expectedParams
*/
public function testDelete($table, $condition, $expectedSQL, $expectedParams)
public function testDelete($table, $condition, $expectedSQL, $expectedParams): void
{
$actualParams = [];
$actualSQL = $this->getQueryBuilder()->delete($table, $condition, $actualParams);
@ -2420,7 +2424,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
$this->assertSame($expectedParams, $actualParams);
}
public function testCommentColumn()
public function testCommentColumn(): void
{
$qb = $this->getQueryBuilder();
@ -2437,7 +2441,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
$this->assertEquals($this->replaceQuotes($expected), $sql);
}
public function testCommentTable()
public function testCommentTable(): void
{
$qb = $this->getQueryBuilder();
@ -2518,7 +2522,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
* @param string $expected
* @param array $expectedParams
*/
public function testBuildLikeCondition($condition, $expected, $expectedParams)
public function testBuildLikeCondition($condition, $expected, $expectedParams): void
{
$query = (new Query())->where($condition);
list($sql, $params) = $this->getQueryBuilder()->build($query);
@ -2529,7 +2533,7 @@ abstract class QueryBuilderTest extends DatabaseTestCase
/**
* @see https://github.com/yiisoft/yii2/issues/15653
*/
public function testIssue15653()
public function testIssue15653(): void
{
$query = (new Query())
->from('admin_user')