php/yii2
1
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2025-11-17 14:57:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

Added yii\web\ErrorHandler::loggableGlobals, removed $_ENV and $_SERVER from dumping by default

Browse Source
This commit is contained in:
SilverFire - Dmitry Naumenko
2015-11-22 17:13:51 +02:00
parent 038c3fba43
commit c651dbb798
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
framework/CHANGELOG.md
View File

@@ -72,6 +72,7 @@ Yii Framework 2 Change Log
- Chg #9369: `Yii::$app->user->can()` now returns `false` instead of erroring in case `authManager` component is not configured (creocoder) - Chg #9369: `Yii::$app->user->can()` now returns `false` instead of erroring in case `authManager` component is not configured (creocoder)
- Chg #9411: `DetailView` now automatically sets container tag ID in case it's not specified (samdark) - Chg #9411: `DetailView` now automatically sets container tag ID in case it's not specified (samdark)
- Chg #9953: `TimestampBehavior::getValue()` changed to make value processing consistent with `AttributeBehavior::getValue()` (silverfire) - Chg #9953: `TimestampBehavior::getValue()` changed to make value processing consistent with `AttributeBehavior::getValue()` (silverfire)
- Chg #6419: Added `yii\web\ErrorHandler::loggableGlobals` to make list logging global variables customizable. `$_ENV` and `$_SERVER` are not logged by default anymore (silverfire)
- New #10083: Added wrapper for PHP webserver (samdark) - New #10083: Added wrapper for PHP webserver (samdark)
- New: Added new requirement: ICU Data version >= 49.1 (SilverFire) - New: Added new requirement: ICU Data version >= 49.1 (SilverFire)

14
framework/web/ErrorHandler.php
View File

@@ -59,7 +59,13 @@ class ErrorHandler extends \yii\base\ErrorHandler
* @var string the path of the view file for rendering previous exceptions. * @var string the path of the view file for rendering previous exceptions.
*/ */
public $previousExceptionView = '@yii/views/errorHandler/previousException.php'; public $previousExceptionView = '@yii/views/errorHandler/previousException.php';
/**
* @var array the variables that will be dumped from the $GLOBALS array.
* Defaults to: `['_GET', '_POST', '_FILES', '_COOKIE', '_SESSION']`
* @see renderRequest()
* @since 2.0.7
*/
public $loggableGlobals = ['_GET', '_POST', '_FILES', '_COOKIE', '_SESSION'];
/** /**
* Renders the exception. * Renders the exception.
@@ -289,13 +295,15 @@ class ErrorHandler extends \yii\base\ErrorHandler
} }
/** /**
* Renders the request information. * Renders the global variables of the request.
* List of global variables is defined in [[loggableGlobals]].
* @return string the rendering result * @return string the rendering result
* @see loggableGlobals
*/ */
public function renderRequest() public function renderRequest()
{ {
$request = ''; $request = '';
foreach (['_GET', '_POST', '_SERVER', '_FILES', '_COOKIE', '_SESSION', '_ENV'] as $name) { foreach ($this->loggableGlobals as $name) {
if (!empty($GLOBALS[$name])) { if (!empty($GLOBALS[$name])) {
$request .= '$' . $name . ' = ' . VarDumper::export($GLOBALS[$name]) . ";\n\n"; $request .= '$' . $name . ' = ' . VarDumper::export($GLOBALS[$name]) . ";\n\n";
} }