php/yii2
1
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2025-11-09 17:57:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

ensure error will always result in a failing HTTP status code

Browse Source 
fixes #8326
proper fix for #7571 which did not work in all situations
This commit is contained in:
Carsten Brandt
2015-05-08 22:38:49 +02:00
parent beff332c1c
commit 8f1811919f
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
framework/base/ErrorHandler.php
View File

@ -87,6 +87,12 @@ abstract class ErrorHandler extends Component
// disable error capturing to avoid recursive errors while handling exceptions
$this->unregister();
// set preventive HTTP status code to 500 in case error handling somehow fails and headers are sent
// HTTP exceptions will override this value in renderException()
if (PHP_SAPI !== 'cli') {
http_response_code(500);
}
try {
$this->logException($exception);
if ($this->discardExistingOutput) {
@ -98,7 +104,8 @@ abstract class ErrorHandler extends Component
}
} catch (\Exception $e) {
// an other exception could be thrown while displaying the exception
$msg = (string) $e;
$msg = "An Error occurred while handling another error:\n";
$msg .= (string) $e;
$msg .= "\nPrevious exception:\n";
$msg .= (string) $exception;
if (YII_DEBUG) {
@ -112,10 +119,6 @@ abstract class ErrorHandler extends Component
}
$msg .= "\n\$_SERVER = " . VarDumper::export($_SERVER);
error_log($msg);
if (PHP_SAPI !== 'cli') {
http_response_code(500);
}
exit(1);
}