diff --git a/tests/framework/data/ActiveDataProviderTest.php b/tests/framework/data/ActiveDataProviderTest.php index f62b0122c4..94f52e80d9 100644 --- a/tests/framework/data/ActiveDataProviderTest.php +++ b/tests/framework/data/ActiveDataProviderTest.php @@ -22,7 +22,7 @@ use yiiunit\data\ar\Order; * @group data * @group db */ -class ActiveDataProviderTest extends DatabaseTestCase +abstract class ActiveDataProviderTest extends DatabaseTestCase { protected function setUp() { diff --git a/tests/framework/db/ActiveRecordTest.php b/tests/framework/db/ActiveRecordTest.php index 3c3ce4c9a2..3db0e646f7 100644 --- a/tests/framework/db/ActiveRecordTest.php +++ b/tests/framework/db/ActiveRecordTest.php @@ -1,4 +1,5 @@ Schema::TYPE_CHAR]); - $this->assertSame('', $columnSchema->dbTypecast('')); - } -} diff --git a/tests/framework/db/CommandTest.php b/tests/framework/db/CommandTest.php index 585ec0f9f4..aefd6193a9 100644 --- a/tests/framework/db/CommandTest.php +++ b/tests/framework/db/CommandTest.php @@ -8,11 +8,7 @@ use yii\db\DataReader; use yii\db\Expression; use yii\db\Schema; -/** - * @group db - * @group mysql - */ -class CommandTest extends DatabaseTestCase +abstract class CommandTest extends DatabaseTestCase { public function testConstruct() { diff --git a/tests/framework/db/ConnectionTest.php b/tests/framework/db/ConnectionTest.php index 444fbd8885..5bb6444d6b 100644 --- a/tests/framework/db/ConnectionTest.php +++ b/tests/framework/db/ConnectionTest.php @@ -5,11 +5,7 @@ namespace yiiunit\framework\db; use yii\db\Connection; use yii\db\Transaction; -/** - * @group db - * @group mysql - */ -class ConnectionTest extends DatabaseTestCase +abstract class ConnectionTest extends DatabaseTestCase { public function testConstruct() diff --git a/tests/framework/db/DatabaseTestCase.php b/tests/framework/db/DatabaseTestCase.php index ec80f95ceb..774371e087 100644 --- a/tests/framework/db/DatabaseTestCase.php +++ b/tests/framework/db/DatabaseTestCase.php @@ -1,4 +1,5 @@ driverName === null) { + throw new \Exception('driverName is not set for a DatabaseTestCase.'); + } + parent::setUp(); $databases = self::getParam('databases'); $this->database = $databases[$this->driverName]; diff --git a/tests/framework/db/QueryTest.php b/tests/framework/db/QueryTest.php index 660ce099dc..020c4907e2 100644 --- a/tests/framework/db/QueryTest.php +++ b/tests/framework/db/QueryTest.php @@ -5,11 +5,7 @@ namespace yiiunit\framework\db; use yii\db\Expression; use yii\db\Query; -/** - * @group db - * @group mysql - */ -class QueryTest extends DatabaseTestCase +abstract class QueryTest extends DatabaseTestCase { public function testSelect() { diff --git a/tests/framework/db/SchemaTest.php b/tests/framework/db/SchemaTest.php index 4fa1352f66..a2dd590023 100644 --- a/tests/framework/db/SchemaTest.php +++ b/tests/framework/db/SchemaTest.php @@ -4,14 +4,11 @@ namespace yiiunit\framework\db; use PDO; use yii\caching\FileCache; +use yii\db\ColumnSchema; use yii\db\Expression; use yii\db\Schema; -/** - * @group db - * @group mysql - */ -class SchemaTest extends DatabaseTestCase +abstract class SchemaTest extends DatabaseTestCase { public function pdoAttributesProvider() { @@ -373,4 +370,11 @@ class SchemaTest extends DatabaseTestCase } } } + + public function testColumnSchemaDbTypecastWithEmptyCharType() + { + $columnSchema = new ColumnSchema(['type' => Schema::TYPE_CHAR]); + $this->assertSame('', $columnSchema->dbTypecast('')); + } + } diff --git a/tests/framework/db/cubrid/CubridActiveDataProviderTest.php b/tests/framework/db/cubrid/ActiveDataProviderTest.php similarity index 54% rename from tests/framework/db/cubrid/CubridActiveDataProviderTest.php rename to tests/framework/db/cubrid/ActiveDataProviderTest.php index f01e69f087..8a36d67b32 100644 --- a/tests/framework/db/cubrid/CubridActiveDataProviderTest.php +++ b/tests/framework/db/cubrid/ActiveDataProviderTest.php @@ -1,14 +1,13 @@