From 80051137536ec32ab8962463598f7e1affdedfb8 Mon Sep 17 00:00:00 2001 From: Maksim Spirkov <63721828+mspirkov@users.noreply.github.com> Date: Fri, 10 Oct 2025 23:01:42 +0300 Subject: [PATCH] Fix PHPStan errors in `yii\rbac\PhpManager` (#20588) --- framework/rbac/PhpManager.php | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/framework/rbac/PhpManager.php b/framework/rbac/PhpManager.php index 9ab385d7f4..bfbfb7f02e 100644 --- a/framework/rbac/PhpManager.php +++ b/framework/rbac/PhpManager.php @@ -401,9 +401,10 @@ class PhpManager extends BaseManager { $roles = $this->getDefaultRoleInstances(); foreach ($this->getAssignments($userId) as $name => $assignment) { - $role = $this->items[$assignment->roleName]; - if ($role->type === Item::TYPE_ROLE) { - $roles[$name] = $role; + $item = $this->items[$assignment->roleName]; + if ($item->type === Item::TYPE_ROLE) { + /** @var Role $item */ + $roles[$name] = $item; } } @@ -490,9 +491,10 @@ class PhpManager extends BaseManager { $permissions = []; foreach ($this->getAssignments($userId) as $name => $assignment) { - $permission = $this->items[$assignment->roleName]; - if ($permission->type === Item::TYPE_PERMISSION) { - $permissions[$name] = $permission; + $item = $this->items[$assignment->roleName]; + if ($item->type === Item::TYPE_PERMISSION) { + /** @var Permission $item */ + $permissions[$name] = $item; } }