Fix #19098: Add yii\helper\BaseHtml::$normalizeClassAttribute to fix duplicate classes

This commit is contained in:
Anton
2021-12-27 21:44:48 +03:00
committed by GitHub
parent 02fe7f42c8
commit 6fb16bc30f
3 changed files with 19 additions and 4 deletions

View File

@ -36,6 +36,7 @@ Yii Framework 2 Change Log
- Bug #19031: Fix displaying console help for parameters with declared types (WinterSilence)
- Bug #19030: Add DI container usage to `yii\base\Widget::end()` (papppeter)
- Bug #19096: Fix `Request::getIsConsoleRequest()` may return erroneously when testing a Web application in Codeception (WinterSilence)
- Enh #19098: Add `yii\helper\BaseHtml::$normalizeClassAttribute` to fix duplicate classes (WinterSilence)
- Enh #19108: Optimize `Component::hasEventHandlers()` and `Component::trigger()` (WinterSilence)

View File

@ -94,8 +94,15 @@ class BaseHtml
* @since 2.0.3
*/
public static $dataAttributes = ['aria', 'data', 'data-ng', 'ng'];
/**
* @var bool whether to removes duplicate class names in tag attribute `class`
* @see mergeCssClasses()
* @see renderTagAttributes()
* @since 2.0.44
*/
public static $normalizeClassAttribute = false;
/**
* Encodes special characters into HTML entities.
* The [[\yii\base\Application::charset|application charset]] will be used for encoding.
@ -1981,6 +1988,11 @@ class BaseHtml
if (empty($value)) {
continue;
}
if (static::$normalizeClassAttribute === true && count($value) > 1) {
// removes duplicate classes
$value = explode(' ', implode(' ', $value));
$value = array_unique($value);
}
$html .= " $name=\"" . static::encode(implode(' ', $value)) . '"';
} elseif ($name === 'style') {
if (empty($value)) {
@ -2047,7 +2059,7 @@ class BaseHtml
}
}
return array_unique($existingClasses);
return static::$normalizeClassAttribute ? array_unique($existingClasses) : $existingClasses;
}
/**