Fix #17932: Fix regression in detection of AJAX requests (#17937)

framework/CHANGELOG.md

@@ -4,7 +4,7 @@ Yii Framework 2 Change Log
 2.0.34 under development
 ------------------------
 
-- no changes in this release.
+- Bug #17932: Fix regression in detection of AJAX requests (samdark)
 
 
 2.0.33 March 24, 2020

framework/web/Request.php

@@ -487,13 +487,7 @@ class Request extends \yii\base\Request
      */
     public function getIsAjax()
     {
-        $origin = $this->headers->get('Origin');
+        return $this->headers->get('X-Requested-With') === 'XMLHttpRequest';
-
-        return
-            ($this->headers->get('X-Requested-With') === 'XMLHttpRequest') ||
-            ($this->headers->get('Sec-Fetch-Mode') === 'cors') ||
-            ($this->headers->get('Sec-Fetch-Site') === 'cross-site') ||
-            ($origin !== null && $origin !== $this->getHostInfo());
     }
 
     /**

tests/framework/web/RequestTest.php

@@ -908,24 +908,6 @@ class RequestTest extends TestCase
                 ],
                 true,
             ],
-            [
-                [
-                    'HTTP_Sec-Fetch-Mode' => 'cors',
-                ],
-                true,
-            ],
-            [
-                [
-                    'HTTP_Sec-Fetch-Site' => 'cross-site',
-                ],
-                true,
-            ],
-            [
-                [
-                    'HTTP_Origin' => 'https://example.com/',
-                ],
-                true,
-            ],
         ];
     }