From 5d7e7f4d9187b54237379521d35a9065fcc84d8b Mon Sep 17 00:00:00 2001 From: Alexander Makarov Date: Tue, 4 Feb 2014 13:31:26 +0400 Subject: [PATCH] Moved creating user to static method of the model --- apps/advanced/common/models/User.php | 12 ++++++++++++ apps/advanced/frontend/models/forms/SignupForm.php | 5 +---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/apps/advanced/common/models/User.php b/apps/advanced/common/models/User.php index 91550a1cbc..3cc5a77d7c 100644 --- a/apps/advanced/common/models/User.php +++ b/apps/advanced/common/models/User.php @@ -27,6 +27,18 @@ class User extends ActiveRecord implements IdentityInterface const ROLE_USER = 10; + public static function create($attributes) + { + /** @var User $user */ + $user = new static(); + $user->setAttributes($attributes); + if ($user->save()) { + return $user; + } else { + return null; + } + } + /** * @inheritdoc */ diff --git a/apps/advanced/frontend/models/forms/SignupForm.php b/apps/advanced/frontend/models/forms/SignupForm.php index e5693d6bf0..4872e1fb8b 100644 --- a/apps/advanced/frontend/models/forms/SignupForm.php +++ b/apps/advanced/frontend/models/forms/SignupForm.php @@ -41,10 +41,7 @@ class SignupForm extends Model public function signup() { if ($this->validate()) { - $user = User::create($this->attributes); - if ($user->save()) { - return $user; - } + return User::create($this->attributes); } return null; }