php/yii2
1
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2025-11-01 11:39:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #16766: yii\filters\ContentNegotiator was not setting Vary header to inform cache recipients

Browse Source
This commit is contained in:
Kot
2018-10-07 19:03:01 +03:00
committed by Alexander Makarov
parent af3b8b2f23
commit 4e6eb5c814
3 changed files with 48 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
tests/framework/filters/ContentNegotiatorTest.php
View File

@ -76,4 +76,45 @@ class ContentNegotiatorTest extends TestCase
$filter->beforeAction($action);
}
public function testVaryHeader()
{
list($action, $filter) = $this->mockActionAndFilter();
$filter->formats = [];
$filter->languages = [];
$filter->beforeAction($action);
$this->assertFalse($filter->response->getHeaders()->has('Vary'));
list($action, $filter) = $this->mockActionAndFilter();
$filter->formats = ['application/json' => Response::FORMAT_JSON];
$filter->languages = ['en'];
$filter->beforeAction($action);
$this->assertFalse($filter->response->getHeaders()->has('Vary')); // There is still nothing to vary
list($action, $filter) = $this->mockActionAndFilter();
$filter->formats = [
'application/json' => Response::FORMAT_JSON,
'application/xml' => Response::FORMAT_XML,
];
$filter->languages = [];
$filter->beforeAction($action);
$this->assertContains('Accept', $filter->response->getHeaders()->get('Vary', [], false));
list($action, $filter) = $this->mockActionAndFilter();
$filter->formats = [];
$filter->languages = ['en', 'de'];
$filter->beforeAction($action);
$this->assertContains('Accept-Language', $filter->response->getHeaders()->get('Vary', [], false));
list($action, $filter) = $this->mockActionAndFilter();
$filter->formats = [
'application/json' => Response::FORMAT_JSON,
'application/xml' => Response::FORMAT_XML,
];
$filter->languages = ['en', 'de'];
$filter->beforeAction($action);
$varyHeader = $filter->response->getHeaders()->get('Vary', [], false);
$this->assertContains('Accept', $varyHeader);
$this->assertContains('Accept-Language', $varyHeader);
}
}