php/yii2
1
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2025-11-02 21:41:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix #19804: Change $this->oldAttributes to $this->_oldAttributes to avoid calling a method unnecessarily

Browse Source
This commit is contained in:
Thiago Talma
2023-04-18 12:54:54 -03:00
committed by GitHub
parent 1a07bb14d9
commit 246a581637
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
framework/CHANGELOG.md
View File

@ -24,6 +24,7 @@ Yii Framework 2 Change Log
- Bug #19770: Fix `yii\mutex\MysqlMutex` `keyPrefix` expression param binding (kamarton) - Bug #19770: Fix `yii\mutex\MysqlMutex` `keyPrefix` expression param binding (kamarton)
- Enh #19794: Add caching in `yii\web\Request` for `getUserIP()` and `getSecureForwardedHeaderTrustedParts()` (rhertogh) - Enh #19794: Add caching in `yii\web\Request` for `getUserIP()` and `getSecureForwardedHeaderTrustedParts()` (rhertogh)
- Bug #19795: Fix `yii\web\Response::redirect()` to prevent setting headers with URL containing new line character (bizley) - Bug #19795: Fix `yii\web\Response::redirect()` to prevent setting headers with URL containing new line character (bizley)
- Enh #19804: Change `$this->oldAttributes` to `$this->_oldAttributes` to avoid calling a method unnecessarily (thiagotalma)
2.0.47 November 18, 2022 2.0.47 November 18, 2022
------------------------ ------------------------

4
framework/db/BaseActiveRecord.php
View File

@ -1762,8 +1762,8 @@ abstract class BaseActiveRecord extends Model implements ActiveRecordInterface
*/ */
private function isAttributeDirty($attribute, $value) private function isAttributeDirty($attribute, $value)
{ {
$old_attribute = $this->oldAttributes[$attribute]; $old_attribute = $this->_oldAttributes === null || !array_key_exists($attribute, $this->_oldAttributes) ? [] : $this->_oldAttributes[$attribute];
if (is_array($value) && is_array($this->oldAttributes[$attribute])) { if (is_array($value) && is_array($this->_oldAttributes[$attribute])) {
$value = ArrayHelper::recursiveSort($value); $value = ArrayHelper::recursiveSort($value);
$old_attribute = ArrayHelper::recursiveSort($old_attribute); $old_attribute = ArrayHelper::recursiveSort($old_attribute);
} }