php/yii2
1
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2025-08-26 14:26:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #6375

Browse Source
This commit is contained in:
Alexander Makarov
2015-10-08 13:18:32 +03:00
parent 9b2089b913
commit 22076bfc77
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
docs/internals/pull-request-qa.md Normal file
View File

@ -0,0 +1,11 @@
Pull request quality assurance
==============================
When checking if PR could be merged or not the following criteria should be considered among others:
- There should be either an issue linked to PR or PR should have a good description on what is it fixing or adding.
- Unit tests. Not mandatory but very appreciated. These should fail without the code that the PR is fixing.
- CHANGELOG entry should present. It should be put into next release section, ordered by issue type and number.
Nicknames of people responsible should present.
- [Code style](core-code-style.md) and [views code style](view-code-style.md) should be OK. These could be fixed while
merging if the person merging prefers it that way.