php/yii2
1
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2025-11-01 03:26:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix #20198: Boolean values of the value HTML attribute are now converted to integer values

Browse Source
This commit is contained in:
Evgeniy Moiseenko
2024-06-17 18:57:37 +03:00
committed by GitHub
parent 140570d186
commit 0e50cee88f
3 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
framework/CHANGELOG.md
View File

@ -7,6 +7,7 @@ Yii Framework 2 Change Log
- Bug #16116: Codeception: oci does not support enabling/disabling integrity check (@terabytesoftw) - Bug #16116: Codeception: oci does not support enabling/disabling integrity check (@terabytesoftw)
- Bug #20191: Fix `ActiveRecord::getDirtyAttributes()` for JSON columns with multi-dimensional array values (brandonkelly) - Bug #20191: Fix `ActiveRecord::getDirtyAttributes()` for JSON columns with multi-dimensional array values (brandonkelly)
- Bug #20175: Fix bad result for pagination when used with GridView (@lav45) - Bug #20175: Fix bad result for pagination when used with GridView (@lav45)
- Enh #20198: Boolean values of the `value` HTML attribute are now converted to integer values (@s1lver)
2.0.50 May 30, 2024 2.0.50 May 30, 2024

4
framework/helpers/BaseHtml.php
View File

@ -2003,8 +2003,10 @@ class BaseHtml
$html = ''; $html = '';
foreach ($attributes as $name => $value) { foreach ($attributes as $name => $value) {
if (is_bool($value)) { if (is_bool($value)) {
if ($value) { if ($value && 'value' !== $name) {
$html .= " $name"; $html .= " $name";
} elseif ('value' === $name) {
$html .= " $name=\"" . static::encode((int)$value) . '"';
} }
} elseif (is_array($value)) { } elseif (is_array($value)) {
if (in_array($name, static::$dataAttributes)) { if (in_array($name, static::$dataAttributes)) {

10
tests/framework/helpers/HtmlTest.php
View File

@ -1231,6 +1231,16 @@ EOD;
$this->assertEquals('', Html::renderTagAttributes(['class' => []])); $this->assertEquals('', Html::renderTagAttributes(['class' => []]));
$this->assertEquals(' style="width: 100px; height: 200px;"', Html::renderTagAttributes(['style' => ['width' => '100px', 'height' => '200px']])); $this->assertEquals(' style="width: 100px; height: 200px;"', Html::renderTagAttributes(['style' => ['width' => '100px', 'height' => '200px']]));
$this->assertEquals('', Html::renderTagAttributes(['style' => []])); $this->assertEquals('', Html::renderTagAttributes(['style' => []]));
$this->assertEquals(' type="submit" value="1"', Html::renderTagAttributes(['type' => 'submit', 'value' => true]));
$this->assertEquals(' type="submit" value="0"', Html::renderTagAttributes(['type' => 'submit', 'value' => false]));
$this->assertEquals(
' type="submit" value="1" disabled',
Html::renderTagAttributes(['type' => 'submit', 'value' => true, 'disabled' => true])
);
$this->assertEquals(
' type="submit" value="0"',
Html::renderTagAttributes(['type' => 'submit', 'value' => false, 'disabled' => false])
);
$attributes = [ $attributes = [
'data' => [ 'data' => [