mirror of
https://github.com/containers/podman.git
synced 2025-08-06 11:32:07 +08:00
258749e43d
When I originally wrote this code I had no idea what POST
would look like so I did a sloppy job, deferring making it
usable. Now that we have some real-world examples in place,
I have a better understanding of what params look like and
how to make tests more readable/maintainable. (Deferring isn't
always bad: one of my early ideas was to separate params using
commas; that would've been a disaster because some JSON values,
such as arrays, include commas).
This commit implements a better way of dealing with POST:
* The main concept is still 'key=value'
* When value is a JSON object (dictionary, array), it
can be quoted.
* Multiple params are simply separated by spaces.
The 3-digit HTTP code is a prominent, readable separator
between POST params and expected results. The parsing
code is a little uglier, but test developers need
never see that. The important thing is that writing
tests is now easier.
* POST params can be empty (this removes the need for a
useless '')
I snuck in one unrelated change: one of the newly-added
tests, .NetworkSettings, was failing when run rootless
(which is how I test on my setup). I made it conditional.
Signed-off-by: Ed Santiago <santiago@redhat.com>
48 lines
1.1 KiB
Bash
48 lines
1.1 KiB
Bash
# -*- sh -*-
|
|
#
|
|
# test more container-related endpoints
|
|
#
|
|
|
|
red='\e[31m'
|
|
nc='\e[0m'
|
|
|
|
podman pull "${IMAGE}" &>/dev/null
|
|
|
|
# Ensure clean slate
|
|
podman rm -a -f &>/dev/null
|
|
|
|
CTR="WaitTestingCtr"
|
|
|
|
t POST "containers/nonExistent/wait?condition=next-exit" 404
|
|
|
|
podman create --name "${CTR}" --entrypoint '["sleep", "0.5"]' "${IMAGE}"
|
|
|
|
t POST "containers/${CTR}/wait?condition=non-existent-cond" 400
|
|
|
|
t POST "containers/${CTR}/wait?condition=not-running" 200
|
|
|
|
t POST "containers/${CTR}/wait?condition=next-exit" 200 &
|
|
child_pid=$!
|
|
podman start "${CTR}"
|
|
wait "${child_pid}"
|
|
|
|
|
|
# check if headers are sent in advance before body
|
|
WAIT_TEST_ERROR=""
|
|
curl -I -X POST "http://$HOST:$PORT/containers/${CTR}/wait?condition=next-exit" &> "/dev/null" &
|
|
child_pid=$!
|
|
sleep 0.5
|
|
if kill -2 "${child_pid}" 2> "/dev/null"; then
|
|
echo -e "${red}NOK: Failed to get response headers immediately.${nc}" 1>&2;
|
|
WAIT_TEST_ERROR="1"
|
|
fi
|
|
|
|
t POST "containers/${CTR}/wait?condition=removed" 200 &
|
|
child_pid=$!
|
|
podman container rm "${CTR}"
|
|
wait "${child_pid}"
|
|
|
|
if [[ "${WAIT_TEST_ERROR}" ]] ; then
|
|
exit 1;
|
|
fi
|